From: Stephen Hemminger <stephen@networkplumber.org>
To: Wang Weidong <wangweidong1@huawei.com>
Cc: vyasevic@redhat.com, netdev <netdev@vger.kernel.org>,
bridge@lists.linux-foundation.org,
David Miller <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed
Date: Fri, 30 May 2014 07:34:46 -0700 [thread overview]
Message-ID: <20140530073446.14b87673@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <53869842.4060202@huawei.com>
On Thu, 29 May 2014 10:15:30 +0800
Wang Weidong <wangweidong1@huawei.com> wrote:
> As commit 2796d0c648c94("bridge: Automatically manage port
> promiscuous mode."), make the add_if use dev_set_allmulti
> instead of dev_set_promiscuous, so when add_if failed, we
> should do dev_set_allmulti(dev, -1).
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Good catch.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Wang Weidong <wangweidong1@huawei.com>
Cc: David Miller <davem@davemloft.net>,
<bridge@lists.linux-foundation.org>,
netdev <netdev@vger.kernel.org>, <vyasevic@redhat.com>
Subject: Re: [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed
Date: Fri, 30 May 2014 07:34:46 -0700 [thread overview]
Message-ID: <20140530073446.14b87673@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <53869842.4060202@huawei.com>
On Thu, 29 May 2014 10:15:30 +0800
Wang Weidong <wangweidong1@huawei.com> wrote:
> As commit 2796d0c648c94("bridge: Automatically manage port
> promiscuous mode."), make the add_if use dev_set_allmulti
> instead of dev_set_promiscuous, so when add_if failed, we
> should do dev_set_allmulti(dev, -1).
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Good catch.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2014-05-30 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 2:15 [Bridge] [PATCH net-next] bridge: fix the unbalanced promiscuous count when add_if failed Wang Weidong
2014-05-29 2:15 ` Wang Weidong
2014-05-29 3:51 ` [Bridge] " Amos Kong
2014-05-29 3:51 ` Amos Kong
2014-05-29 13:30 ` [Bridge] " Vlad Yasevich
2014-05-29 13:30 ` Vlad Yasevich
2014-05-30 14:34 ` Stephen Hemminger [this message]
2014-05-30 14:34 ` Stephen Hemminger
2014-06-02 5:05 ` [Bridge] " David Miller
2014-06-02 5:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530073446.14b87673@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
--cc=wangweidong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.