From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH v4] NVMe: basic conversion to blk-mq
Date: Fri, 30 May 2014 11:00:50 -0400 [thread overview]
Message-ID: <20140530150050.GD5499@linux.intel.com> (raw)
In-Reply-To: <1401400285-25003-2-git-send-email-m@bjorling.me>
On Thu, May 29, 2014@11:51:25PM +0200, Matias Bj?rling wrote:
> -static int nvme_map_bio(struct nvme_queue *nvmeq, struct nvme_iod *iod,
> - struct bio *bio, enum dma_data_direction dma_dir, int psegs)
> +static int nvme_map_rq(struct nvme_queue *nvmeq, struct nvme_iod *iod,
> + struct request *req, enum dma_data_direction dma_dir,
> + int psegs)
> {
> - struct bio_vec bvec, bvprv;
> - struct bvec_iter iter;
> - struct scatterlist *sg = NULL;
> - int length = 0, nsegs = 0, split_len = bio->bi_iter.bi_size;
> - int first = 1;
> -
> - if (nvmeq->dev->stripe_size)
> - split_len = nvmeq->dev->stripe_size -
> - ((bio->bi_iter.bi_sector << 9) &
> - (nvmeq->dev->stripe_size - 1));
You take out stripe_size here, but don't appear to put it back in
anywhere else.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: "Matias Bjørling" <m@bjorling.me>
Cc: keith.busch@intel.com, sbradshaw@micron.com, axboe@kernel.dk,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v4] NVMe: basic conversion to blk-mq
Date: Fri, 30 May 2014 11:00:50 -0400 [thread overview]
Message-ID: <20140530150050.GD5499@linux.intel.com> (raw)
In-Reply-To: <1401400285-25003-2-git-send-email-m@bjorling.me>
On Thu, May 29, 2014 at 11:51:25PM +0200, Matias Bjørling wrote:
> -static int nvme_map_bio(struct nvme_queue *nvmeq, struct nvme_iod *iod,
> - struct bio *bio, enum dma_data_direction dma_dir, int psegs)
> +static int nvme_map_rq(struct nvme_queue *nvmeq, struct nvme_iod *iod,
> + struct request *req, enum dma_data_direction dma_dir,
> + int psegs)
> {
> - struct bio_vec bvec, bvprv;
> - struct bvec_iter iter;
> - struct scatterlist *sg = NULL;
> - int length = 0, nsegs = 0, split_len = bio->bi_iter.bi_size;
> - int first = 1;
> -
> - if (nvmeq->dev->stripe_size)
> - split_len = nvmeq->dev->stripe_size -
> - ((bio->bi_iter.bi_sector << 9) &
> - (nvmeq->dev->stripe_size - 1));
You take out stripe_size here, but don't appear to put it back in
anywhere else.
next prev parent reply other threads:[~2014-05-30 15:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 21:51 [PATCH v4] basic conversion to blk-mq Matias Bjørling
2014-05-29 21:51 ` Matias Bjørling
2014-05-29 21:51 ` [PATCH v4] NVMe: " Matias Bjørling
2014-05-29 21:51 ` Matias Bjørling
2014-05-30 14:54 ` Matthew Wilcox
2014-05-30 14:54 ` Matthew Wilcox
2014-05-30 15:00 ` Matthew Wilcox [this message]
2014-05-30 15:00 ` Matthew Wilcox
2014-05-30 19:46 ` Jens Axboe
2014-05-30 19:46 ` Jens Axboe
2014-05-30 16:48 ` Keith Busch
2014-05-30 16:48 ` Keith Busch
2014-05-30 19:33 ` Matias Bjorling
2014-05-30 19:33 ` Matias Bjorling
2014-05-30 16:58 ` Matthew Wilcox
2014-05-30 16:58 ` Matthew Wilcox
2014-06-02 10:08 ` Christoph Hellwig
2014-06-02 10:08 ` Christoph Hellwig
2014-06-02 11:46 ` Matias Bjørling
2014-06-02 11:46 ` Matias Bjørling
2014-06-02 9:42 ` [PATCH v4] " Christoph Hellwig
2014-06-02 9:42 ` Christoph Hellwig
2014-06-02 10:31 ` Matias Bjørling
2014-06-02 10:31 ` Matias Bjørling
2014-06-02 10:11 ` Christoph Hellwig
2014-06-02 10:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530150050.GD5499@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.