From: m@bjorling.me (Matias Bjorling)
Subject: [PATCH v4] NVMe: basic conversion to blk-mq
Date: Fri, 30 May 2014 21:33:13 +0200 [thread overview]
Message-ID: <5388DCF9.9000204@bjorling.me> (raw)
In-Reply-To: <alpine.LRH.2.03.1405301027350.11244@AMR>
On 05/30/2014 06:48 PM, Keith Busch wrote:
> On Thu, 29 May 2014, Matias Bj?rling wrote:
>> This converts the current NVMe driver to utilize the blk-mq layer.
>
> I'm pretty darn sure this new nvme_remove can cause a process
> with an open reference to use queues after they're freed in the
> nvme_submit_sync_command path, maybe even the admin tags too.
>
You're right. I'll put a fix in v5.
>> @@ -2802,7 +2574,7 @@ static void nvme_remove(struct pci_dev *pdev)
>> nvme_dev_remove(dev);
>> nvme_dev_shutdown(dev);
>> nvme_free_queues(dev, 0);
>> - rcu_barrier();
>> + nvme_free_admin_tags(dev);
>> nvme_release_instance(dev);
>> nvme_release_prp_pools(dev);
>> kref_put(&dev->kref, nvme_free_dev);
WARNING: multiple messages have this Message-ID (diff)
From: Matias Bjorling <m@bjorling.me>
To: Keith Busch <keith.busch@intel.com>
Cc: willy@linux.intel.com, sbradshaw@micron.com, axboe@kernel.dk,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v4] NVMe: basic conversion to blk-mq
Date: Fri, 30 May 2014 21:33:13 +0200 [thread overview]
Message-ID: <5388DCF9.9000204@bjorling.me> (raw)
In-Reply-To: <alpine.LRH.2.03.1405301027350.11244@AMR>
On 05/30/2014 06:48 PM, Keith Busch wrote:
> On Thu, 29 May 2014, Matias Bjørling wrote:
>> This converts the current NVMe driver to utilize the blk-mq layer.
>
> I'm pretty darn sure this new nvme_remove can cause a process
> with an open reference to use queues after they're freed in the
> nvme_submit_sync_command path, maybe even the admin tags too.
>
You're right. I'll put a fix in v5.
>> @@ -2802,7 +2574,7 @@ static void nvme_remove(struct pci_dev *pdev)
>> nvme_dev_remove(dev);
>> nvme_dev_shutdown(dev);
>> nvme_free_queues(dev, 0);
>> - rcu_barrier();
>> + nvme_free_admin_tags(dev);
>> nvme_release_instance(dev);
>> nvme_release_prp_pools(dev);
>> kref_put(&dev->kref, nvme_free_dev);
next prev parent reply other threads:[~2014-05-30 19:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 21:51 [PATCH v4] basic conversion to blk-mq Matias Bjørling
2014-05-29 21:51 ` Matias Bjørling
2014-05-29 21:51 ` [PATCH v4] NVMe: " Matias Bjørling
2014-05-29 21:51 ` Matias Bjørling
2014-05-30 14:54 ` Matthew Wilcox
2014-05-30 14:54 ` Matthew Wilcox
2014-05-30 15:00 ` Matthew Wilcox
2014-05-30 15:00 ` Matthew Wilcox
2014-05-30 19:46 ` Jens Axboe
2014-05-30 19:46 ` Jens Axboe
2014-05-30 16:48 ` Keith Busch
2014-05-30 16:48 ` Keith Busch
2014-05-30 19:33 ` Matias Bjorling [this message]
2014-05-30 19:33 ` Matias Bjorling
2014-05-30 16:58 ` Matthew Wilcox
2014-05-30 16:58 ` Matthew Wilcox
2014-06-02 10:08 ` Christoph Hellwig
2014-06-02 10:08 ` Christoph Hellwig
2014-06-02 11:46 ` Matias Bjørling
2014-06-02 11:46 ` Matias Bjørling
2014-06-02 9:42 ` [PATCH v4] " Christoph Hellwig
2014-06-02 9:42 ` Christoph Hellwig
2014-06-02 10:31 ` Matias Bjørling
2014-06-02 10:31 ` Matias Bjørling
2014-06-02 10:11 ` Christoph Hellwig
2014-06-02 10:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5388DCF9.9000204@bjorling.me \
--to=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.