All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
Cc: Vaughan Cao <vaughan.cao-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] remove duplicate checking code
Date: Fri, 30 May 2014 20:21:43 +0200	[thread overview]
Message-ID: <20140530182143.GK17056@8bytes.org> (raw)
In-Reply-To: <1401371147.22923.4.camel@x220>

On Thu, May 29, 2014 at 03:45:47PM +0200, Paul Bolle wrote:
> On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote:
> > On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote:
> > > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device
> > > called before, it's fine to attach device at this point.
> > > 
> > > Signed-off-by: Vaughan Cao <vaughan.cao@oracle.com>
> > > ---
> > >  drivers/iommu/amd_iommu.c | 6 ------
> > >  1 file changed, 6 deletions(-)
> > 
> > Applied, thanks.
> 
> This one entered linux-next, as of next-20142527, in commit ecef115d4540
> ("iommu/amd: Remove duplicate checking code"). It triggers an obviously
> correct warning:
>     drivers/iommu/amd_iommu.c: In function ‘amd_iommu_init_passthrough’:
>     drivers/iommu/amd_iommu.c:3503:6: warning: unused variable ‘devid’ [-Wunused-variable]
>       u16 devid;
>           ^
>     drivers/iommu/amd_iommu.c:3502:20: warning: unused variable ‘iommu’ [-Wunused-variable]
>       struct amd_iommu *iommu;
>                         ^
> 
> Is the trivial fix for this queued somewhere?

Just queued one to my x86/amd branch. Thanks for the report.


	Joerg


_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Vaughan Cao <vaughan.cao@oracle.com>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove duplicate checking code
Date: Fri, 30 May 2014 20:21:43 +0200	[thread overview]
Message-ID: <20140530182143.GK17056@8bytes.org> (raw)
In-Reply-To: <1401371147.22923.4.camel@x220>

On Thu, May 29, 2014 at 03:45:47PM +0200, Paul Bolle wrote:
> On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote:
> > On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote:
> > > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device
> > > called before, it's fine to attach device at this point.
> > > 
> > > Signed-off-by: Vaughan Cao <vaughan.cao@oracle.com>
> > > ---
> > >  drivers/iommu/amd_iommu.c | 6 ------
> > >  1 file changed, 6 deletions(-)
> > 
> > Applied, thanks.
> 
> This one entered linux-next, as of next-20142527, in commit ecef115d4540
> ("iommu/amd: Remove duplicate checking code"). It triggers an obviously
> correct warning:
>     drivers/iommu/amd_iommu.c: In function ‘amd_iommu_init_passthrough’:
>     drivers/iommu/amd_iommu.c:3503:6: warning: unused variable ‘devid’ [-Wunused-variable]
>       u16 devid;
>           ^
>     drivers/iommu/amd_iommu.c:3502:20: warning: unused variable ‘iommu’ [-Wunused-variable]
>       struct amd_iommu *iommu;
>                         ^
> 
> Is the trivial fix for this queued somewhere?

Just queued one to my x86/amd branch. Thanks for the report.


	Joerg



  reply	other threads:[~2014-05-30 18:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16  7:39 [PATCH] remove duplicate checking code Vaughan Cao
     [not found] ` <1400225980-12797-1-git-send-email-vaughan.cao-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-05-26  9:39   ` Joerg Roedel
2014-05-26  9:39     ` Joerg Roedel
     [not found]     ` <20140526093959.GH17056-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-05-29 13:45       ` Paul Bolle
2014-05-29 13:45         ` Paul Bolle
2014-05-30 18:21         ` Joerg Roedel [this message]
2014-05-30 18:21           ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140530182143.GK17056@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org \
    --cc=vaughan.cao-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.