All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Christoph Lameter <cl@gentwo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Li Zefan <lizefan@huawei.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Mel Gorman <mgorman@suse.de>, Tejun Heo <tj@kernel.org>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] page_alloc: skip cpuset enforcement for lower zone allocations (v4)
Date: Fri, 30 May 2014 18:43:45 -0300	[thread overview]
Message-ID: <20140530214344.GA14720@amt.cnet> (raw)
In-Reply-To: <alpine.DEB.2.10.1405300841390.8240@gentwo.org>

On Fri, May 30, 2014 at 08:48:41AM -0500, Christoph Lameter wrote:
> On Thu, 29 May 2014, Andrew Morton wrote:
> 
> > >
> > > 	if (!nodemask && gfp_zone(gfp_mask) < policy_zone)
> > > 		nodemask = &node_states[N_ONLINE];
> >
> > OK, thanks, I made the patch go away for now.
> >
> 
> And another issue is that the policy_zone may be highmem on 32 bit
> platforms which will result in ZONE_NORMAL to be exempted.
> 
> policy zone can actually even be ZONE_DMA for some platforms. The
> check would not be useful at all on those.
> 
> Ignoring the containing cpuset only makes sense for GFP_DMA32 on
> 64 bit platforms and for GFP_DMA on platforms where there is an actual
> difference in the address spaces supported by GFP_DMA (such as x86).
> 
> Generally I think this is only useful for platforms that attempt to
> support legacy devices only able to DMA to a portion of the memory address
> space and that at the same time support NUMA for large address spaces.
> This is a contradiction on the one hand this is a high end system and on
> the other hand it attempts to support crippled DMA devices?

OK we will handle this in userspace.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Christoph Lameter <cl@gentwo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Li Zefan <lizefan@huawei.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	Mel Gorman <mgorman@suse.de>, Tejun Heo <tj@kernel.org>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] page_alloc: skip cpuset enforcement for lower zone allocations (v4)
Date: Fri, 30 May 2014 18:43:45 -0300	[thread overview]
Message-ID: <20140530214344.GA14720@amt.cnet> (raw)
In-Reply-To: <alpine.DEB.2.10.1405300841390.8240@gentwo.org>

On Fri, May 30, 2014 at 08:48:41AM -0500, Christoph Lameter wrote:
> On Thu, 29 May 2014, Andrew Morton wrote:
> 
> > >
> > > 	if (!nodemask && gfp_zone(gfp_mask) < policy_zone)
> > > 		nodemask = &node_states[N_ONLINE];
> >
> > OK, thanks, I made the patch go away for now.
> >
> 
> And another issue is that the policy_zone may be highmem on 32 bit
> platforms which will result in ZONE_NORMAL to be exempted.
> 
> policy zone can actually even be ZONE_DMA for some platforms. The
> check would not be useful at all on those.
> 
> Ignoring the containing cpuset only makes sense for GFP_DMA32 on
> 64 bit platforms and for GFP_DMA on platforms where there is an actual
> difference in the address spaces supported by GFP_DMA (such as x86).
> 
> Generally I think this is only useful for platforms that attempt to
> support legacy devices only able to DMA to a portion of the memory address
> space and that at the same time support NUMA for large address spaces.
> This is a contradiction on the one hand this is a high end system and on
> the other hand it attempts to support crippled DMA devices?

OK we will handle this in userspace.


  reply	other threads:[~2014-05-30 21:44 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 19:37 [PATCH] page_alloc: skip cpuset enforcement for lower zone allocations Marcelo Tosatti
2014-05-23 19:37 ` Marcelo Tosatti
2014-05-23 20:51 ` David Rientjes
2014-05-23 20:51   ` David Rientjes
     [not found]   ` <alpine.DEB.2.02.1405231334460.13205-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2014-05-23 23:33     ` Marcelo Tosatti
2014-05-23 23:33       ` Marcelo Tosatti
2014-05-23 23:33       ` Marcelo Tosatti
2014-05-26 18:53 ` [PATCH] page_alloc: skip cpuset enforcement for lower zone allocations (v2) Marcelo Tosatti
2014-05-26 18:53   ` Marcelo Tosatti
2014-05-28  7:02   ` Li Zefan
2014-05-28  7:02     ` Li Zefan
2014-05-28 22:43     ` [PATCH] page_alloc: skip cpuset enforcement for lower zone allocations (v3) Marcelo Tosatti
2014-05-28 22:43       ` Marcelo Tosatti
2014-05-28 23:45       ` Christoph Lameter
2014-05-28 23:45         ` Christoph Lameter
2014-05-29 18:46         ` Marcelo Tosatti
2014-05-29 18:46           ` Marcelo Tosatti
2014-05-29 18:43       ` [PATCH] page_alloc: skip cpuset enforcement for lower zone allocations (v4) Marcelo Tosatti
2014-05-29 18:43         ` Marcelo Tosatti
2014-05-29 22:40         ` Andrew Morton
2014-05-29 22:40           ` Andrew Morton
2014-05-29 23:01         ` David Rientjes
2014-05-29 23:01           ` David Rientjes
2014-05-29 23:12           ` Andrew Morton
2014-05-29 23:12             ` Andrew Morton
2014-05-30 13:48             ` Christoph Lameter
2014-05-30 13:48               ` Christoph Lameter
2014-05-30 21:43               ` Marcelo Tosatti [this message]
2014-05-30 21:43                 ` Marcelo Tosatti
2014-05-29 23:28           ` [PATCH] page_alloc: skip cpuset enforcement for lower zone allocations (v5) Marcelo Tosatti
2014-05-29 23:28             ` Marcelo Tosatti
2014-05-29 23:54             ` David Rientjes
2014-05-29 23:54               ` David Rientjes
2014-05-30 13:12               ` Marcelo Tosatti
2014-05-30 13:12                 ` Marcelo Tosatti
2014-05-30 13:50               ` Christoph Lameter
2014-05-30 13:50                 ` Christoph Lameter
2014-05-30 21:18                 ` Andi Kleen
2014-05-30 21:18                   ` Andi Kleen
2014-05-27 14:21 ` [PATCH] page_alloc: skip cpuset enforcement for lower zone allocations Christoph Lameter
2014-05-27 14:21   ` Christoph Lameter
2014-05-27 14:53   ` Marcelo Tosatti
2014-05-27 14:53     ` Marcelo Tosatti
2014-05-27 14:57     ` Marcelo Tosatti
2014-05-27 14:57       ` Marcelo Tosatti
2014-05-27 15:31     ` Christoph Lameter
2014-05-27 15:31       ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140530214344.GA14720@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=cl@gentwo.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=mgorman@suse.de \
    --cc=rientjes@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.