From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] regulator: of: Add support for parsing regulator_state for suspend state
Date: Mon, 9 Jun 2014 20:21:33 +0100 [thread overview]
Message-ID: <20140609192133.GD5099@sirena.org.uk> (raw)
In-Reply-To: <1402309780-8118-2-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On Mon, Jun 09, 2014 at 07:29:39PM +0900, Chanwoo Choi wrote:
> + ret = of_property_read_u32(suspend_np, "regulator-mode", &pval);
> + if (!ret)
> + suspend_state->mode = pval;
If we're going to do that we'd need to define what modes mean in the DT
binding - currently there's no support for modes at all because it's
complicated to come up with sensible and meaningful generic defintions.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: lgirdwood@gmail.com, grant.likely@linaro.org, robh+dt@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: of: Add support for parsing regulator_state for suspend state
Date: Mon, 9 Jun 2014 20:21:33 +0100 [thread overview]
Message-ID: <20140609192133.GD5099@sirena.org.uk> (raw)
In-Reply-To: <1402309780-8118-2-git-send-email-cw00.choi@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On Mon, Jun 09, 2014 at 07:29:39PM +0900, Chanwoo Choi wrote:
> + ret = of_property_read_u32(suspend_np, "regulator-mode", &pval);
> + if (!ret)
> + suspend_state->mode = pval;
If we're going to do that we'd need to define what modes mean in the DT
binding - currently there's no support for modes at all because it's
complicated to come up with sensible and meaningful generic defintions.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-09 19:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 10:29 [PATCH 0/2] regulator: of: Add support for pasing regulator suspend state Chanwoo Choi
2014-06-09 10:29 ` Chanwoo Choi
2014-06-09 10:29 ` [PATCH 1/2] regulator: of: Add support for parsing regulator_state for " Chanwoo Choi
[not found] ` <1402309780-8118-2-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-09 19:21 ` Mark Brown [this message]
2014-06-09 19:21 ` Mark Brown
[not found] ` <20140609192133.GD5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-09 23:59 ` Chanwoo Choi
2014-06-09 23:59 ` Chanwoo Choi
[not found] ` <53964A45.3010108-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-10 10:02 ` Mark Brown
2014-06-10 10:02 ` Mark Brown
[not found] ` <20140610100232.GD5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-10 10:25 ` Chanwoo Choi
2014-06-10 10:25 ` Chanwoo Choi
2014-06-09 10:29 ` [PATCH 2/2] dt-bindings: regulator: Add regulator suspend state for PM state Chanwoo Choi
[not found] ` <1402309780-8118-3-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-09 19:16 ` Mark Brown
2014-06-09 19:16 ` Mark Brown
2014-06-10 1:30 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609192133.GD5099@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.