Re: [PATCH 1/2] regulator: of: Add support for parsing regulator_state for suspend state

[Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]

Hi Mark,

On 06/10/2014 04:21 AM, Mark Brown wrote:
> On Mon, Jun 09, 2014 at 07:29:39PM +0900, Chanwoo Choi wrote:
> 
>> +		ret = of_property_read_u32(suspend_np, "regulator-mode", &pval);
>> +		if (!ret)
>> +			suspend_state->mode = pval;
> 
> If we're going to do that we'd need to define what modes mean in the DT
> binding - currently there's no support for modes at all because it's
> complicated to come up with sensible and meaningful generic defintions.
> 

The 'regulator-mode' of this patch means following defined constant variable
as following in include/linux/regulator/consumer.h:
#define REGULATOR_MODE_FAST		0x1
#define REGULATOR_MODE_NORMAL		0x2
#define REGULATOR_MODE_IDLE		0x4
#define REGULATOR_MODE_STANDBY		0x8

If regulator consumer would use this mode('regulator-mode),
specific regulator driver should implement rdev->desc->ops->set_suspend_mode function
to control regulator state according to 'regulator-mode' in suspend state.

Best Regards,
Chanwoo CHoi



--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html