re: OMAPDSS: panel sharp-ls037v7dw01 DT support

re: OMAPDSS: panel sharp-ls037v7dw01 DT support

[Dan Carpenter]

Hello Tony Lindgren,

This is a semi-automatic email about new static checker warnings.

The patch be88c16a22ed: "OMAPDSS: panel sharp-ls037v7dw01 DT support"
from May 16, 2014, leads to the following Smatch complaint:

drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c:113 sharp_ls_enable()
	 error: we previously assumed 'ddata->vcc' could be null (see line 105)

drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c
   104	
   105		if (ddata->vcc) {
                    ^^^^^^^^^^
Patch introduces a check.

   106			r = regulator_enable(ddata->vcc);
   107			if (r != 0)
   108				return r;
   109		}
   110	
   111		r = in->ops.dpi->enable(in);
   112		if (r) {
   113			regulator_disable(ddata->vcc);
                                          ^^^^^^^^^^
Patch introduces a new dereference and I was too lazy to find out if
an error in ->enable() implies a non-null "ddata->vcc" because I am a
bad person.

   114			return r;
   115		}

regards,
dan carpenter

re: OMAPDSS: panel sharp-ls037v7dw01 DT support

[Dan Carpenter]

Hello Tony Lindgren,

This is a semi-automatic email about new static checker warnings.

The patch be88c16a22ed: "OMAPDSS: panel sharp-ls037v7dw01 DT support" 
from May 16, 2014, leads to the following Smatch complaint:

drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c:113 sharp_ls_enable()
	 error: we previously assumed 'ddata->vcc' could be null (see line 105)

drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
   104	
   105		if (ddata->vcc) {
                    ^^^^^^^^^^
Check.

   106			r = regulator_enable(ddata->vcc);
   107			if (r != 0)
   108				return r;
   109		}
   110	
   111		r = in->ops.dpi->enable(in);
   112		if (r) {
   113			regulator_disable(ddata->vcc);
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unchecked dereference inside function.

   114			return r;
   115		}

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel