* [Qemu-devel] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
@ 2014-06-24 22:57 ` Eduardo Habkost
0 siblings, 0 replies; 8+ messages in thread
From: Eduardo Habkost @ 2014-06-24 22:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: Gerd Hoffmann, Michael S. Tsirkin
The property name is "prog_if", not "prof_if".
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Cc: BALATON Zoltan <balaton@eik.bme.hu>
---
include/hw/i386/pc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 486e98f..1331d5a 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
},\
{\
.driver = "pci-serial-2x",\
- .property = "prof_if",\
+ .property = "prog_if",\
.value = stringify(0),\
},\
{\
--
1.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
2014-06-24 22:57 ` [Qemu-devel] " Eduardo Habkost
@ 2014-06-25 5:58 ` Michael S. Tsirkin
-1 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2014-06-25 5:58 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-trivial, BALATON Zoltan, qemu-devel, Gerd Hoffmann
On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> The property name is "prog_if", not "prof_if".
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
Applied, thanks!
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 486e98f..1331d5a 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> },\
> {\
> .driver = "pci-serial-2x",\
> - .property = "prof_if",\
> + .property = "prog_if",\
> .value = stringify(0),\
> },\
> {\
> --
> 1.9.3
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
@ 2014-06-25 5:58 ` Michael S. Tsirkin
0 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2014-06-25 5:58 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-trivial, qemu-devel, Gerd Hoffmann
On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> The property name is "prog_if", not "prof_if".
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
Applied, thanks!
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 486e98f..1331d5a 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> },\
> {\
> .driver = "pci-serial-2x",\
> - .property = "prof_if",\
> + .property = "prog_if",\
> .value = stringify(0),\
> },\
> {\
> --
> 1.9.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
2014-06-24 22:57 ` [Qemu-devel] " Eduardo Habkost
@ 2014-06-25 6:00 ` Michael S. Tsirkin
-1 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2014-06-25 6:00 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-trivial, BALATON Zoltan, qemu-devel, Gerd Hoffmann
On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> The property name is "prog_if", not "prof_if".
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
Should be reported-by, by the way.
Cc: means "I have notified this person just in case".
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 486e98f..1331d5a 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> },\
> {\
> .driver = "pci-serial-2x",\
> - .property = "prof_if",\
> + .property = "prog_if",\
> .value = stringify(0),\
> },\
> {\
> --
> 1.9.3
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
@ 2014-06-25 6:00 ` Michael S. Tsirkin
0 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2014-06-25 6:00 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-trivial, qemu-devel, Gerd Hoffmann
On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> The property name is "prog_if", not "prof_if".
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
Should be reported-by, by the way.
Cc: means "I have notified this person just in case".
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 486e98f..1331d5a 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> },\
> {\
> .driver = "pci-serial-2x",\
> - .property = "prof_if",\
> + .property = "prog_if",\
> .value = stringify(0),\
> },\
> {\
> --
> 1.9.3
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
2014-06-25 6:00 ` [Qemu-devel] " Michael S. Tsirkin
@ 2014-06-25 6:01 ` Michael S. Tsirkin
-1 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2014-06-25 6:01 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-trivial, BALATON Zoltan, qemu-devel, Gerd Hoffmann
On Wed, Jun 25, 2014 at 09:00:59AM +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> > The property name is "prog_if", not "prof_if".
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > Cc: BALATON Zoltan <balaton@eik.bme.hu>
>
> Should be reported-by, by the way.
> Cc: means "I have notified this person just in case".
Fixed up on my branch no need to repost.
> > ---
> > include/hw/i386/pc.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> > index 486e98f..1331d5a 100644
> > --- a/include/hw/i386/pc.h
> > +++ b/include/hw/i386/pc.h
> > @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> > },\
> > {\
> > .driver = "pci-serial-2x",\
> > - .property = "prof_if",\
> > + .property = "prog_if",\
> > .value = stringify(0),\
> > },\
> > {\
> > --
> > 1.9.3
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
@ 2014-06-25 6:01 ` Michael S. Tsirkin
0 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2014-06-25 6:01 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-trivial, qemu-devel, Gerd Hoffmann
On Wed, Jun 25, 2014 at 09:00:59AM +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> > The property name is "prog_if", not "prof_if".
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > Cc: BALATON Zoltan <balaton@eik.bme.hu>
>
> Should be reported-by, by the way.
> Cc: means "I have notified this person just in case".
Fixed up on my branch no need to repost.
> > ---
> > include/hw/i386/pc.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> > index 486e98f..1331d5a 100644
> > --- a/include/hw/i386/pc.h
> > +++ b/include/hw/i386/pc.h
> > @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> > },\
> > {\
> > .driver = "pci-serial-2x",\
> > - .property = "prof_if",\
> > + .property = "prog_if",\
> > .value = stringify(0),\
> > },\
> > {\
> > --
> > 1.9.3
^ permalink raw reply [flat|nested] 8+ messages in thread