From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Varun Sethi <Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.
Date: Fri, 4 Jul 2014 12:44:30 +0200 [thread overview]
Message-ID: <20140704104430.GD13434@8bytes.org> (raw)
In-Reply-To: <1403618237-26248-2-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
On Tue, Jun 24, 2014 at 07:27:15PM +0530, Varun Sethi wrote:
> /* window size is 2^(WSE+1) bytes */
> - return __ffs(addrspace_size) - 1;
> + return fls64(addrspace_size) - 2;
This looks bogus, why do you replace ffs (find-first-bit) by fls
(find-last-bit)?
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: alex.williamson@redhat.com, iommu@lists.linux-foundation.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.
Date: Fri, 4 Jul 2014 12:44:30 +0200 [thread overview]
Message-ID: <20140704104430.GD13434@8bytes.org> (raw)
In-Reply-To: <1403618237-26248-2-git-send-email-Varun.Sethi@freescale.com>
On Tue, Jun 24, 2014 at 07:27:15PM +0530, Varun Sethi wrote:
> /* window size is 2^(WSE+1) bytes */
> - return __ffs(addrspace_size) - 1;
> + return fls64(addrspace_size) - 2;
This looks bogus, why do you replace ffs (find-first-bit) by fls
(find-last-bit)?
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, alex.williamson@redhat.com
Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.
Date: Fri, 4 Jul 2014 12:44:30 +0200 [thread overview]
Message-ID: <20140704104430.GD13434@8bytes.org> (raw)
In-Reply-To: <1403618237-26248-2-git-send-email-Varun.Sethi@freescale.com>
On Tue, Jun 24, 2014 at 07:27:15PM +0530, Varun Sethi wrote:
> /* window size is 2^(WSE+1) bytes */
> - return __ffs(addrspace_size) - 1;
> + return fls64(addrspace_size) - 2;
This looks bogus, why do you replace ffs (find-first-bit) by fls
(find-last-bit)?
Joerg
next prev parent reply other threads:[~2014-07-04 10:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 13:57 [PATCH 0/3] iommu/fsl: Fixes for the PAMU driver Varun Sethi
2014-06-24 13:57 ` Varun Sethi
[not found] ` <1403618237-26248-1-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-06-24 13:57 ` [PATCH 1/3] iommu/fsl: Fix PAMU window size check Varun Sethi
2014-06-24 13:57 ` Varun Sethi
[not found] ` <1403618237-26248-2-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-07-04 10:44 ` Joerg Roedel [this message]
2014-07-04 10:44 ` Joerg Roedel
2014-07-04 10:44 ` Joerg Roedel
[not found] ` <20140704104430.GD13434-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-07-04 12:47 ` Varun Sethi
2014-07-04 12:47 ` Varun Sethi
2014-07-04 12:47 ` Varun Sethi
2014-06-24 13:57 ` [PATCH 2/3] iommu/fsl: Fix the device domain attach condition Varun Sethi
2014-06-24 13:57 ` Varun Sethi
[not found] ` <1403618237-26248-3-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-07-04 10:54 ` Joerg Roedel
2014-07-04 10:54 ` Joerg Roedel
2014-07-04 10:54 ` Joerg Roedel
[not found] ` <20140704105430.GE13434-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-07-04 12:50 ` Varun Sethi
2014-07-04 12:50 ` Varun Sethi
2014-07-04 12:50 ` Varun Sethi
2014-06-24 13:57 ` [PATCH 3/3] iommu/fsl: Fix the error condition during iommu group Varun Sethi
2014-06-24 13:57 ` Varun Sethi
2014-07-07 8:32 ` [PATCH 0/3] iommu/fsl: Fixes for the PAMU driver Joerg Roedel
2014-07-07 8:32 ` Joerg Roedel
2014-07-07 8:32 ` Joerg Roedel
[not found] ` <20140707083216.GA1958-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-07-07 8:55 ` Varun Sethi
2014-07-07 8:55 ` Varun Sethi
2014-07-07 8:55 ` Varun Sethi
[not found] ` <1403618237-26248-2-git-send-email-Varun.Sethi__13822.953499812$1403630309$gmane$org@freescale.com>
2014-07-02 7:46 ` [PATCH 1/3] iommu/fsl: Fix PAMU window size check Emil Medve
2014-07-02 7:46 ` Emil Medve
[not found] ` <53B3B8B9.30400-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2014-07-02 8:58 ` Varun Sethi
2014-07-02 8:58 ` Varun Sethi
2014-07-02 8:58 ` Varun Sethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140704104430.GD13434@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.