From: Emil Medve <Emilian.Medve@Freescale.com>
To: Varun Sethi <Varun.Sethi@Freescale.com>,
iommu@lists.linux-foundation.org, joro@8bytes.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
alex.williamson@redhat.com
Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.
Date: Wed, 2 Jul 2014 02:46:01 -0500 [thread overview]
Message-ID: <53B3B8B9.30400@Freescale.com> (raw)
In-Reply-To: <1403618237-26248-2-git-send-email-Varun.Sethi__13822.953499812$1403630309$gmane$org@freescale.com>
On 06/24/2014 08:57 AM, Varun Sethi wrote:
> is_power_of_2 requires an unsigned long parameter which would
> lead to truncation of 64 bit values on 32 bit architectures.
>
> __ffs also expects an unsigned long parameter thus won't work
> for 64 bit values on 32 bit architectures.
>
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
> drivers/iommu/fsl_pamu.c | 8 ++++----
> drivers/iommu/fsl_pamu_domain.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
Tested-by: Emil Medve <Emilian.Medve@Freescale.com>
On a P4080 DS (i.e. 32-bit SoC)
Cheers,
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
WARNING: multiple messages have this Message-ID (diff)
From: Emil Medve <Emilian.Medve@Freescale.com>
To: Varun Sethi <Varun.Sethi@Freescale.com>,
<iommu@lists.linux-foundation.org>, <joro@8bytes.org>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<alex.williamson@redhat.com>
Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.
Date: Wed, 2 Jul 2014 02:46:01 -0500 [thread overview]
Message-ID: <53B3B8B9.30400@Freescale.com> (raw)
In-Reply-To: <1403618237-26248-2-git-send-email-Varun.Sethi__13822.953499812$1403630309$gmane$org@freescale.com>
On 06/24/2014 08:57 AM, Varun Sethi wrote:
> is_power_of_2 requires an unsigned long parameter which would
> lead to truncation of 64 bit values on 32 bit architectures.
>
> __ffs also expects an unsigned long parameter thus won't work
> for 64 bit values on 32 bit architectures.
>
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
> drivers/iommu/fsl_pamu.c | 8 ++++----
> drivers/iommu/fsl_pamu_domain.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
Tested-by: Emil Medve <Emilian.Medve@Freescale.com>
On a P4080 DS (i.e. 32-bit SoC)
Cheers,
next prev parent reply other threads:[~2014-07-02 7:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 13:57 [PATCH 0/3] iommu/fsl: Fixes for the PAMU driver Varun Sethi
2014-06-24 13:57 ` Varun Sethi
[not found] ` <1403618237-26248-1-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-06-24 13:57 ` [PATCH 1/3] iommu/fsl: Fix PAMU window size check Varun Sethi
2014-06-24 13:57 ` Varun Sethi
[not found] ` <1403618237-26248-2-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-07-04 10:44 ` Joerg Roedel
2014-07-04 10:44 ` Joerg Roedel
2014-07-04 10:44 ` Joerg Roedel
[not found] ` <20140704104430.GD13434-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-07-04 12:47 ` Varun Sethi
2014-07-04 12:47 ` Varun Sethi
2014-07-04 12:47 ` Varun Sethi
2014-06-24 13:57 ` [PATCH 2/3] iommu/fsl: Fix the device domain attach condition Varun Sethi
2014-06-24 13:57 ` Varun Sethi
[not found] ` <1403618237-26248-3-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-07-04 10:54 ` Joerg Roedel
2014-07-04 10:54 ` Joerg Roedel
2014-07-04 10:54 ` Joerg Roedel
[not found] ` <20140704105430.GE13434-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-07-04 12:50 ` Varun Sethi
2014-07-04 12:50 ` Varun Sethi
2014-07-04 12:50 ` Varun Sethi
2014-06-24 13:57 ` [PATCH 3/3] iommu/fsl: Fix the error condition during iommu group Varun Sethi
2014-06-24 13:57 ` Varun Sethi
2014-07-07 8:32 ` [PATCH 0/3] iommu/fsl: Fixes for the PAMU driver Joerg Roedel
2014-07-07 8:32 ` Joerg Roedel
2014-07-07 8:32 ` Joerg Roedel
[not found] ` <20140707083216.GA1958-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-07-07 8:55 ` Varun Sethi
2014-07-07 8:55 ` Varun Sethi
2014-07-07 8:55 ` Varun Sethi
[not found] ` <1403618237-26248-2-git-send-email-Varun.Sethi__13822.953499812$1403630309$gmane$org@freescale.com>
2014-07-02 7:46 ` Emil Medve [this message]
2014-07-02 7:46 ` [PATCH 1/3] iommu/fsl: Fix PAMU window size check Emil Medve
[not found] ` <53B3B8B9.30400-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2014-07-02 8:58 ` Varun Sethi
2014-07-02 8:58 ` Varun Sethi
2014-07-02 8:58 ` Varun Sethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3B8B9.30400@Freescale.com \
--to=emilian.medve@freescale.com \
--cc=Varun.Sethi@Freescale.com \
--cc=alex.williamson@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.