Re: [PATCH net-next repost v2 1/3] net: Simplify ptp class checks

Re: [PATCH net-next repost v2 1/3] net: Simplify ptp class checks

[Richard Cochran]

On Wed, Jul 02, 2014 at 04:41:42PM +0200, Stefan Sørensen wrote:
> Replace two switch statements enumerating all valid ptp classes with an if
> statement matching for not PTP_CLASS_NONE.

Originally, I had the explicit list to guard against the possibility
of a filter returning early without some valid PTP_CLASS. I agree with
this change, but we will have to remember to make sure the filter
always returns NONE when the packet isn't recognized.

Acked-by: Richard Cochran <richardcochran@gmail.com>

Re: [PATCH net-next repost v2 2/3] ptp: Classify ptp over ip over vlan packets

[Richard Cochran]

On Wed, Jul 02, 2014 at 04:41:43PM +0200, Stefan Sørensen wrote:
> This extends the ptp bpf to also match ptp over ip over vlan packets. The ptp
> classes are changed to orthogonal bitfields representing version, transport
> and vlan values to simplify matching.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>

I like the simplied matching routines, and I also checked the BPF_ASM
program. Thanks for this patch series.

Acked-by: Richard Cochran <richardcochran@gmail.com>

Re: [PATCH net-next repost v2 3/3] vlan: Pass SIOC[SG]HWTSTAMP ioctls to real device

[Richard Cochran]

On Wed, Jul 02, 2014 at 04:41:44PM +0200, Stefan Sørensen wrote:
> This allows applications to enable hardware timestamping without being aware
> of it being a vlan device and figuring out the real device.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>

Acked-by: Richard Cochran <richardcochran@gmail.com>