From: Catalin Marinas <catalin.marinas@arm.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Will Deacon <Will.Deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] ARM: Use include/asm-generic/io.h
Date: Fri, 11 Jul 2014 17:24:23 +0100 [thread overview]
Message-ID: <20140711162422.GF16321@arm.com> (raw)
In-Reply-To: <1405092672-18549-2-git-send-email-thierry.reding@gmail.com>
On Fri, Jul 11, 2014 at 04:31:11PM +0100, Thierry Reding wrote:
> diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
> index a78562f21aab..ef54f5c8a7ae 100644
> --- a/arch/arm/include/asm/io.h
> +++ b/arch/arm/include/asm/io.h
[...]
> -#define iowrite16be(v,p) ({ __iowmb(); __raw_writew((__force __u16)cpu_to_be16(v), p); })
> -#define iowrite32be(v,p) ({ __iowmb(); __raw_writel((__force __u32)cpu_to_be32(v), p); })
Aren't you losing the barrier semantics here? The generic iowrite*be()
functions call __raw_write*() directly which don't have a barrier
(write* accessors do).
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ARM: Use include/asm-generic/io.h
Date: Fri, 11 Jul 2014 17:24:23 +0100 [thread overview]
Message-ID: <20140711162422.GF16321@arm.com> (raw)
In-Reply-To: <1405092672-18549-2-git-send-email-thierry.reding@gmail.com>
On Fri, Jul 11, 2014 at 04:31:11PM +0100, Thierry Reding wrote:
> diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
> index a78562f21aab..ef54f5c8a7ae 100644
> --- a/arch/arm/include/asm/io.h
> +++ b/arch/arm/include/asm/io.h
[...]
> -#define iowrite16be(v,p) ({ __iowmb(); __raw_writew((__force __u16)cpu_to_be16(v), p); })
> -#define iowrite32be(v,p) ({ __iowmb(); __raw_writel((__force __u32)cpu_to_be32(v), p); })
Aren't you losing the barrier semantics here? The generic iowrite*be()
functions call __raw_write*() directly which don't have a barrier
(write* accessors do).
--
Catalin
next prev parent reply other threads:[~2014-07-11 16:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 15:31 [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-07-11 15:31 ` Thierry Reding
2014-07-11 15:31 ` [PATCH v2 2/3] ARM: Use include/asm-generic/io.h Thierry Reding
2014-07-11 15:31 ` Thierry Reding
2014-07-11 16:24 ` Catalin Marinas [this message]
2014-07-11 16:24 ` Catalin Marinas
2014-07-12 12:27 ` Arnd Bergmann
2014-07-12 12:27 ` Arnd Bergmann
2014-07-12 14:18 ` Catalin Marinas
2014-07-12 14:18 ` Catalin Marinas
2014-07-11 15:31 ` [PATCH v2 3/3] arm64: " Thierry Reding
2014-07-11 15:31 ` Thierry Reding
2014-07-11 16:18 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*() Catalin Marinas
2014-07-11 16:18 ` Catalin Marinas
2014-07-11 21:59 ` Stephen Boyd
2014-07-11 21:59 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read, write}s*() Stephen Boyd
2014-07-14 9:10 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-07-14 9:10 ` Thierry Reding
2014-07-14 17:23 ` Stephen Boyd
2014-07-14 17:23 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read, write}s*() Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711162422.GF16321@arm.com \
--to=catalin.marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.