From: Stephen Boyd <sboyd@codeaurora.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Ben Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*()
Date: Mon, 14 Jul 2014 10:23:31 -0700 [thread overview]
Message-ID: <53C41213.6020102@codeaurora.org> (raw)
In-Reply-To: <20140714091057.GP2081@ulmo>
On 07/14/14 02:10, Thierry Reding wrote:
> The reason behind this was that people have been told to migrate towards
> using io{read,write}{8,16,32}_rep() because {read,write}s{b,w,l}() are
> not as "portable". The only reason why the aren't portable is because no
> generic versions of them existed. That's what this series originally
> started out as.
>
> Also, it's somewhat backwards (and inconsistent) to go through the io*()
> functions when it's known up front that the device will always only be
> memory-mapped and never I/O mapped. So with these patches going forward,
> people should be using either {read,write}{,s}{b,w,l}() *or* their
> io{read,write}{8,16,32}{,_rep}() counterparts, not mixing them.
>
Thanks. Can we please have this explanation in the commit text?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] asm-generic/io.h: Implement generic {read, write}s*()
Date: Mon, 14 Jul 2014 10:23:31 -0700 [thread overview]
Message-ID: <53C41213.6020102@codeaurora.org> (raw)
In-Reply-To: <20140714091057.GP2081@ulmo>
On 07/14/14 02:10, Thierry Reding wrote:
> The reason behind this was that people have been told to migrate towards
> using io{read,write}{8,16,32}_rep() because {read,write}s{b,w,l}() are
> not as "portable". The only reason why the aren't portable is because no
> generic versions of them existed. That's what this series originally
> started out as.
>
> Also, it's somewhat backwards (and inconsistent) to go through the io*()
> functions when it's known up front that the device will always only be
> memory-mapped and never I/O mapped. So with these patches going forward,
> people should be using either {read,write}{,s}{b,w,l}() *or* their
> io{read,write}{8,16,32}{,_rep}() counterparts, not mixing them.
>
Thanks. Can we please have this explanation in the commit text?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-07-14 17:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 15:31 [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-07-11 15:31 ` Thierry Reding
2014-07-11 15:31 ` [PATCH v2 2/3] ARM: Use include/asm-generic/io.h Thierry Reding
2014-07-11 15:31 ` Thierry Reding
2014-07-11 16:24 ` Catalin Marinas
2014-07-11 16:24 ` Catalin Marinas
2014-07-12 12:27 ` Arnd Bergmann
2014-07-12 12:27 ` Arnd Bergmann
2014-07-12 14:18 ` Catalin Marinas
2014-07-12 14:18 ` Catalin Marinas
2014-07-11 15:31 ` [PATCH v2 3/3] arm64: " Thierry Reding
2014-07-11 15:31 ` Thierry Reding
2014-07-11 16:18 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*() Catalin Marinas
2014-07-11 16:18 ` Catalin Marinas
2014-07-11 21:59 ` Stephen Boyd
2014-07-11 21:59 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read, write}s*() Stephen Boyd
2014-07-14 9:10 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-07-14 9:10 ` Thierry Reding
2014-07-14 17:23 ` Stephen Boyd [this message]
2014-07-14 17:23 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read, write}s*() Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C41213.6020102@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.