All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3 of 6] uclibc: replace custom kconfig helpers with those provided by pkg-utils
Date: Mon, 14 Jul 2014 16:40:56 +0200	[thread overview]
Message-ID: <20140714144056.GL3684@free.fr> (raw)
In-Reply-To: <CAAXf6LUrfRoSRiyZt_wm7xwrj82UhL7eX6a=jmu33KRF=Z1Z9w@mail.gmail.com>

Thomas, All,

On 2014-07-14 16:39 +0200, Thomas De Schampheleire spake thusly:
> Hi Yann,
> 
> On Mon, Jul 14, 2014 at 4:36 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > Thomas, All,
> >
> > On 2014-07-14 13:50 +0200, Thomas De Schampheleire spake thusly:
> >> This patch removes the custom kconfig helpers UCLIBC_OPT_SET and
> >> UCLIBC_OPT_UNSET with the common KCONFIG_SET_OPT, KCONFIG_ENABLE_OPT and
> >> KCONFIG_DISABLE_OPT.
> >>
> >> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> >
> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > But see below:
> >
> >>       $(SED) '/CONFIG_ARM_.ABI/d' $(@D)/.config
> >>       $(SED) '/CONFIG_MIPS_[NO].._ABI/d' $(@D)/.config
> >>       $(SED) '/CONFIG_MIPS_ISA_.*/d' $(@D)/.config
> >>       $(SED) '/CONFIG_SH[234A]*/d' $(@D)/.config
> >>       $(SED) 's/^\(CONFIG_[^_]*[_]*SPARC[^=]*\)=.*/# \1 is not set/g' \
> >>                $(@D)/.config
> >
> > Ideally, we should have KCONFIG helpers for those, too.
> >
> 
> Yes, but it has to be a new helper I think, because of the pattern matching.

Absolutely, yes. And it can come in a later patch.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-07-14 14:40 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 11:50 [Buildroot] [PATCH 0 of 6] uclibc: fix handling of configuration file Thomas De Schampheleire
2014-07-14 11:50 ` [Buildroot] [PATCH 1 of 6] pkg-utils: kconfig helpers: add basic usage documentation Thomas De Schampheleire
2014-07-14 14:02   ` Yann E. MORIN
2014-07-14 16:39   ` Arnout Vandecappelle
2014-07-14 11:50 ` [Buildroot] [PATCH 2 of 6] pkg-utils: kconfig helpers: use single iso double quoting Thomas De Schampheleire
2014-07-14 14:26   ` Yann E. MORIN
2014-07-14 16:41   ` Arnout Vandecappelle
2014-07-14 11:50 ` [Buildroot] [PATCH 3 of 6] uclibc: replace custom kconfig helpers with those provided by pkg-utils Thomas De Schampheleire
2014-07-14 14:36   ` Yann E. MORIN
2014-07-14 14:39     ` Thomas De Schampheleire
2014-07-14 14:40       ` Yann E. MORIN [this message]
2014-07-14 11:50 ` [Buildroot] [PATCH 4 of 6] uclibc: rename SETUP_DOT_CONFIG to FIXUP_DOT_CONFIG Thomas De Schampheleire
2014-07-14 14:33   ` Thomas Petazzoni
2014-07-14 14:39     ` Yann E. MORIN
2014-07-14 14:43       ` Thomas De Schampheleire
2014-07-14 16:21         ` Yann E. MORIN
2014-07-14 16:44         ` Arnout Vandecappelle
2014-07-14 19:51           ` Thomas De Schampheleire
2014-07-15  6:09             ` Arnout Vandecappelle
2014-07-14 11:50 ` [Buildroot] [PATCH 5 of 6] uclibc: menuconfig: take into account initial settings from config file Thomas De Schampheleire
2014-07-14 16:55   ` Arnout Vandecappelle
2014-07-14 19:54     ` Thomas De Schampheleire
2014-07-15  6:10       ` Arnout Vandecappelle
2014-07-14 11:50 ` [Buildroot] [PATCH 6 of 6] uclibc: update-config: preserve freshly configured settings Thomas De Schampheleire
2014-07-14 17:05   ` Arnout Vandecappelle
2014-07-15 18:33     ` Thomas De Schampheleire
2014-07-16  5:43       ` Arnout Vandecappelle
2014-07-17 17:57         ` Thomas De Schampheleire
2014-07-17 23:28           ` Arnout Vandecappelle
2014-07-18  5:29             ` Thomas De Schampheleire
2014-07-14 16:34 ` [Buildroot] [PATCH 0 of 6] uclibc: fix handling of configuration file Arnout Vandecappelle
2014-07-15 17:36 ` Thomas Petazzoni
2014-07-15 18:38   ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714144056.GL3684@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.