All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4 of 6] uclibc: rename SETUP_DOT_CONFIG to FIXUP_DOT_CONFIG
Date: Mon, 14 Jul 2014 18:21:02 +0200	[thread overview]
Message-ID: <20140714162102.GM3684@free.fr> (raw)
In-Reply-To: <CAAXf6LWobeHbQB+d8MvtMF3x3=W1FPPdfSr-4yU_bi+ZKF3cGg@mail.gmail.com>

Thomas?, All,

On 2014-07-14 16:43 +0200, Thomas De Schampheleire spake thusly:
> On Mon, Jul 14, 2014 at 4:39 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > Thomas?, All,
> >
> > On 2014-07-14 16:33 +0200, Thomas Petazzoni spake thusly:
> >> On Mon, 14 Jul 2014 13:50:28 +0200, Thomas De Schampheleire wrote:
> >>
> >> > -define UCLIBC_SETUP_DOT_CONFIG
> >> > +define UCLIBC_FIXUP_DOT_CONFIG
> >> >     $(INSTALL) -m 0644 $(UCLIBC_CONFIG_FILE) $(@D)/.config
> >>
> >> This this variable is actually copying the configuration file, I
> >> believe the current name of the variable is more correct than the one
> >> you propose to use, no?
> >
> > Thomas did the change, because in patch 5/6 it no longer does the copy,
> > it only does the fixup.
> >
> > This should probably have been explained in the commit log that the
> > change was needed by a future patch.
> 
> Ok, I see. I split off the change to a separate patch for clarity, but
> indeed at this moment it is not yet fully accurate. I can fold this
> patch with the 5th patch, or otherwise update the commit msg as Yann
> proposed, what do you prefer?

Well, I think a separate patch is better, since it is easier to review.
Just add a blurb in the commit log.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-07-14 16:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 11:50 [Buildroot] [PATCH 0 of 6] uclibc: fix handling of configuration file Thomas De Schampheleire
2014-07-14 11:50 ` [Buildroot] [PATCH 1 of 6] pkg-utils: kconfig helpers: add basic usage documentation Thomas De Schampheleire
2014-07-14 14:02   ` Yann E. MORIN
2014-07-14 16:39   ` Arnout Vandecappelle
2014-07-14 11:50 ` [Buildroot] [PATCH 2 of 6] pkg-utils: kconfig helpers: use single iso double quoting Thomas De Schampheleire
2014-07-14 14:26   ` Yann E. MORIN
2014-07-14 16:41   ` Arnout Vandecappelle
2014-07-14 11:50 ` [Buildroot] [PATCH 3 of 6] uclibc: replace custom kconfig helpers with those provided by pkg-utils Thomas De Schampheleire
2014-07-14 14:36   ` Yann E. MORIN
2014-07-14 14:39     ` Thomas De Schampheleire
2014-07-14 14:40       ` Yann E. MORIN
2014-07-14 11:50 ` [Buildroot] [PATCH 4 of 6] uclibc: rename SETUP_DOT_CONFIG to FIXUP_DOT_CONFIG Thomas De Schampheleire
2014-07-14 14:33   ` Thomas Petazzoni
2014-07-14 14:39     ` Yann E. MORIN
2014-07-14 14:43       ` Thomas De Schampheleire
2014-07-14 16:21         ` Yann E. MORIN [this message]
2014-07-14 16:44         ` Arnout Vandecappelle
2014-07-14 19:51           ` Thomas De Schampheleire
2014-07-15  6:09             ` Arnout Vandecappelle
2014-07-14 11:50 ` [Buildroot] [PATCH 5 of 6] uclibc: menuconfig: take into account initial settings from config file Thomas De Schampheleire
2014-07-14 16:55   ` Arnout Vandecappelle
2014-07-14 19:54     ` Thomas De Schampheleire
2014-07-15  6:10       ` Arnout Vandecappelle
2014-07-14 11:50 ` [Buildroot] [PATCH 6 of 6] uclibc: update-config: preserve freshly configured settings Thomas De Schampheleire
2014-07-14 17:05   ` Arnout Vandecappelle
2014-07-15 18:33     ` Thomas De Schampheleire
2014-07-16  5:43       ` Arnout Vandecappelle
2014-07-17 17:57         ` Thomas De Schampheleire
2014-07-17 23:28           ` Arnout Vandecappelle
2014-07-18  5:29             ` Thomas De Schampheleire
2014-07-14 16:34 ` [Buildroot] [PATCH 0 of 6] uclibc: fix handling of configuration file Arnout Vandecappelle
2014-07-15 17:36 ` Thomas Petazzoni
2014-07-15 18:38   ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714162102.GM3684@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.