[Buildroot] [PATCH 1/3] Add $$(PKG)_AUTORECONF_ENV argument to autotools package autoreconf command to allow environment variables to be used.

[Buildroot] [PATCH 1/3] Add $$(PKG)_AUTORECONF_ENV argument to autotools package autoreconf command to allow environment variables to be used.

[Rick Taylor]

Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
---
 package/pkg-autotools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index 557413d..255c42d 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -228,7 +228,7 @@ endef
 #
 define AUTORECONF_HOOK
 	@$$(call MESSAGE,"Autoreconfiguring")
-	$$(Q)cd $$($$(PKG)_SRCDIR) && $$(AUTORECONF) $$($$(PKG)_AUTORECONF_OPT)
+	$$(Q)cd $$($$(PKG)_SRCDIR) && $$($$(PKG)_AUTORECONF_ENV) $$(AUTORECONF) $$($$(PKG)_AUTORECONF_OPT)
 	$$(Q)if test "$$($$(PKG)_LIBTOOL_PATCH)" = "YES"; then \
 		for i in `find $$($$(PKG)_SRCDIR) -name ltmain.sh`; do \
 			ltmain_version=`sed -n '/^[ 	]*VERSION=/{s/^[ 	]*VERSION=//;p;q;}' $$$$i | \
-- 
1.9.1

[Buildroot] [PATCH 2/3] Update documentation of AUTORECONF_ENV

[Rick Taylor]

Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
---
 docs/manual/adding-packages-autotools.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/manual/adding-packages-autotools.txt b/docs/manual/adding-packages-autotools.txt
index 3f40503..a1a4b90 100644
--- a/docs/manual/adding-packages-autotools.txt
+++ b/docs/manual/adding-packages-autotools.txt
@@ -121,6 +121,11 @@ cases, typical packages will therefore only use a few of them.
   automake, libtool, etc.). Valid values are +YES+ and
   +NO+. By default, the value is +NO+
 
+* +LIBFOO_AUTORECONF_ENV+, to specify additional environment
+  variables to pass the 'autoreconf' program if
+  +LIBFOO_AUTORECONF=YES+. These are passed before
+  the 'autoreconf' command. By default, empty.
+  
 * +LIBFOO_AUTORECONF_OPT+ to specify additional options
   passed to the 'autoreconf' program if
   +LIBFOO_AUTORECONF=YES+. By default, empty.
-- 
1.9.1

[Buildroot] [PATCH 2/3] Update documentation of AUTORECONF_ENV

[Thomas Petazzoni]

Dear Rick Taylor,

On Fri, 18 Jul 2014 09:42:42 +0100, Rick Taylor wrote:
> Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
> ---
>  docs/manual/adding-packages-autotools.txt | 5 +++++
>  1 file changed, 5 insertions(+)

Commit title should be:

	docs/manual: update documentation for <pkg>_AUTORECONF_ENV

or something similar, at least carrying the "docs/manual:" prefix.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/3] Update documentation of AUTORECONF_ENV

[Thomas De Schampheleire]

Hi Rick,

On Fri, Jul 18, 2014 at 10:42 AM, Rick Taylor <tropicalstormuk@gmail.com> wrote:
> Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
> ---
>  docs/manual/adding-packages-autotools.txt | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/docs/manual/adding-packages-autotools.txt b/docs/manual/adding-packages-autotools.txt
> index 3f40503..a1a4b90 100644
> --- a/docs/manual/adding-packages-autotools.txt
> +++ b/docs/manual/adding-packages-autotools.txt
> @@ -121,6 +121,11 @@ cases, typical packages will therefore only use a few of them.
>    automake, libtool, etc.). Valid values are +YES+ and
>    +NO+. By default, the value is +NO+
>
> +* +LIBFOO_AUTORECONF_ENV+, to specify additional environment
> +  variables to pass the 'autoreconf' program if

Did you see my comment on the previous version of this patch? I think
there is a 'to' missing here:

to pass _to_ the autoreconf program


Best regards,
Thomas

[Buildroot] [PATCH 2/3] Update documentation of AUTORECONF_ENV

[Rick Taylor]

Hi All,

I have rebased all my autoconf patches down to 1 patch file.  Hopefully I
have got the git commit message correct.

Many thanks for your patience!

Rick


On Fri, Jul 18, 2014 at 9:54 AM, Thomas De Schampheleire <
patrickdepinguin@gmail.com> wrote:

> Hi Rick,
>
> On Fri, Jul 18, 2014 at 10:42 AM, Rick Taylor <tropicalstormuk@gmail.com>
> wrote:
> > Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
> > ---
> >  docs/manual/adding-packages-autotools.txt | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/docs/manual/adding-packages-autotools.txt
> b/docs/manual/adding-packages-autotools.txt
> > index 3f40503..a1a4b90 100644
> > --- a/docs/manual/adding-packages-autotools.txt
> > +++ b/docs/manual/adding-packages-autotools.txt
> > @@ -121,6 +121,11 @@ cases, typical packages will therefore only use a
> few of them.
> >    automake, libtool, etc.). Valid values are +YES+ and
> >    +NO+. By default, the value is +NO+
> >
> > +* +LIBFOO_AUTORECONF_ENV+, to specify additional environment
> > +  variables to pass the 'autoreconf' program if
>
> Did you see my comment on the previous version of this patch? I think
> there is a 'to' missing here:
>
> to pass _to_ the autoreconf program
>
>
> Best regards,
> Thomas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140718/bf863747/attachment.html>

[Buildroot] [PATCH 3/3] Update documentation to clarify usage

[Rick Taylor]

Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
---
 docs/manual/adding-packages-autotools.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/manual/adding-packages-autotools.txt b/docs/manual/adding-packages-autotools.txt
index a1a4b90..dd76ed3 100644
--- a/docs/manual/adding-packages-autotools.txt
+++ b/docs/manual/adding-packages-autotools.txt
@@ -123,7 +123,7 @@ cases, typical packages will therefore only use a few of them.
 
 * +LIBFOO_AUTORECONF_ENV+, to specify additional environment
   variables to pass the 'autoreconf' program if
-  +LIBFOO_AUTORECONF=YES+. These are passed before
+  +LIBFOO_AUTORECONF=YES+. These are passed in the environment of
   the 'autoreconf' command. By default, empty.
   
 * +LIBFOO_AUTORECONF_OPT+ to specify additional options
-- 
1.9.1

[Buildroot] [PATCH 3/3] Update documentation to clarify usage

[Thomas Petazzoni]

Dear Rick Taylor,

On Fri, 18 Jul 2014 09:42:43 +0100, Rick Taylor wrote:
> Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
> ---
>  docs/manual/adding-packages-autotools.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This should be squashed in the previous commit.

See "git rebase -i" (interactive rebasing) to achieve that.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/3] Add $$(PKG)_AUTORECONF_ENV argument to autotools package autoreconf command to allow environment variables to be used.

[Thomas Petazzoni]

Dear Rick Taylor,

On Fri, 18 Jul 2014 09:42:41 +0100, Rick Taylor wrote:
> Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
> ---
>  package/pkg-autotools.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks. However, the commit log is not properly formatted. With git,
the commit log should have one line of less than ~80 characters that
summarizes the commit, then one empty new line, and then more details.
Also, in Buildroot, we like when the commit title has a prefix that
identifies the area of the change. I.e, in your case, something like:

===
pkg-autotools: add support for <pkg>_AUTORECONF_ENV

This commit improves the autotools-package infrastructure to support a
<pkg>_AUTORECONF_ENV variable, which allows to pass addition variables
in the environment of the autoreconf execution. This is useful in the
situation where blabla blibli ...

Signed-off-by: ...
===

Could you update your commit log with this format?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com