From: ezequiel@vanguardiasur.com.ar (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/9] usb: musb: several bugfixes for the musb driver
Date: Fri, 18 Jul 2014 13:16:36 -0300 [thread overview]
Message-ID: <20140718161636.GA18460@arch.cereza> (raw)
In-Reply-To: <1405675890-8802-1-git-send-email-LW@KARO-electronics.de>
Hi Lothar,
On 18 Jul 11:31 AM, Lothar Wa?mann wrote:
> The first three patches do some source code cleanup in the files that
> are modified in the subsequent patches.
>
I've applied patches 4 and 9 on a recent -next, after fixing a conflict
due to patch 3 ("usb: musb_am335x: source cleanup"):
> Patch 4 carries the proper fix reported in commit:
> 7adb5c876e9c ("usb: musb: Fix panic upon musb_am335x module removal")
>
> Patch 9 reinstates module unloading support for the musb_am335x driver
> which was disabled due to a false failure analysis
>
For these two patches, Tested-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Tested on a beaglebone with a mass storage USB device, module load/unload
works without issues. The module_get/put in the phy is now preventing the
musb_am335x driver unload, which seems to be the real cause of the issue
I reported. Thanks for providing a proper fix!
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
George Cherian <george.cherian@ti.com>,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver
Date: Fri, 18 Jul 2014 13:16:36 -0300 [thread overview]
Message-ID: <20140718161636.GA18460@arch.cereza> (raw)
In-Reply-To: <1405675890-8802-1-git-send-email-LW@KARO-electronics.de>
Hi Lothar,
On 18 Jul 11:31 AM, Lothar Waßmann wrote:
> The first three patches do some source code cleanup in the files that
> are modified in the subsequent patches.
>
I've applied patches 4 and 9 on a recent -next, after fixing a conflict
due to patch 3 ("usb: musb_am335x: source cleanup"):
> Patch 4 carries the proper fix reported in commit:
> 7adb5c876e9c ("usb: musb: Fix panic upon musb_am335x module removal")
>
> Patch 9 reinstates module unloading support for the musb_am335x driver
> which was disabled due to a false failure analysis
>
For these two patches, Tested-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Tested on a beaglebone with a mass storage USB device, module load/unload
works without issues. The module_get/put in the phy is now preventing the
musb_am335x driver unload, which seems to be the real cause of the issue
I reported. Thanks for providing a proper fix!
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2014-07-18 16:16 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:31 [PATCH 0/9] usb: musb: several bugfixes for the musb driver Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 1/9] usb: musb: core: cleanup - remove some useless 'break's from switch statements Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 2/9] usb: phy: am335x: group the #includes by subdirs Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 3/9] usb: musb_am335x: source cleanup Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 4/9] usb: phy: am335x-control: prevent module from being unloaded when in use Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 5/9] usb: musb: print error message with dev_err() instead of dev_dbg() Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 6/9] usb: musb: core: properly setup the HW before registering it to the USB core Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 7/9] usb: phy: am335x: setup the gen_phy function pointers _before_ adding the phy Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown() Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 9/9] usb: musb: musb_am335x: reinstate module loading/unloading support Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 14:04 ` Felipe Balbi
2014-07-18 14:04 ` Felipe Balbi
2014-07-18 14:04 ` Felipe Balbi
2014-07-22 7:49 ` Lothar Waßmann
2014-07-22 7:49 ` Lothar Waßmann
2014-07-22 7:49 ` Lothar Waßmann
2014-07-22 14:47 ` Felipe Balbi
2014-07-22 14:47 ` Felipe Balbi
2014-07-22 14:47 ` Felipe Balbi
2014-07-18 13:57 ` [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown() Felipe Balbi
2014-07-18 13:57 ` Felipe Balbi
2014-07-21 8:03 ` Lothar Waßmann
2014-07-21 8:03 ` Lothar Waßmann
2014-07-21 15:10 ` Felipe Balbi
2014-07-21 15:10 ` Felipe Balbi
2014-07-22 8:06 ` Lothar Waßmann
2014-07-22 8:06 ` Lothar Waßmann
2014-07-22 14:47 ` Felipe Balbi
2014-07-22 14:47 ` Felipe Balbi
2014-07-18 13:54 ` [PATCH 7/9] usb: phy: am335x: setup the gen_phy function pointers _before_ adding the phy Felipe Balbi
2014-07-18 13:54 ` Felipe Balbi
2014-07-18 13:52 ` [PATCH 6/9] usb: musb: core: properly setup the HW before registering it to the USB core Felipe Balbi
2014-07-18 13:52 ` Felipe Balbi
2014-07-18 13:50 ` [PATCH 5/9] usb: musb: print error message with dev_err() instead of dev_dbg() Felipe Balbi
2014-07-18 13:50 ` Felipe Balbi
2014-07-18 13:50 ` [PATCH 4/9] usb: phy: am335x-control: prevent module from being unloaded when in use Felipe Balbi
2014-07-18 13:50 ` Felipe Balbi
2014-07-18 13:45 ` [PATCH 3/9] usb: musb_am335x: source cleanup Felipe Balbi
2014-07-18 13:45 ` Felipe Balbi
2014-07-18 13:45 ` [PATCH 2/9] usb: phy: am335x: group the #includes by subdirs Felipe Balbi
2014-07-18 13:45 ` Felipe Balbi
2014-07-18 13:44 ` [PATCH 1/9] usb: musb: core: cleanup - remove some useless 'break's from switch statements Felipe Balbi
2014-07-18 13:44 ` Felipe Balbi
2014-07-18 16:16 ` Ezequiel Garcia [this message]
2014-07-18 16:16 ` [PATCH 0/9] usb: musb: several bugfixes for the musb driver Ezequiel Garcia
2014-07-18 16:50 ` Felipe Balbi
2014-07-18 16:50 ` Felipe Balbi
2014-07-21 7:34 ` Lothar Waßmann
2014-07-21 7:34 ` Lothar Waßmann
2014-07-21 15:11 ` Felipe Balbi
2014-07-21 15:11 ` Felipe Balbi
2014-07-21 15:53 ` Ezequiel Garcia
2014-07-21 15:53 ` Ezequiel Garcia
2014-07-21 15:58 ` Felipe Balbi
2014-07-21 15:58 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718161636.GA18460@arch.cereza \
--to=ezequiel@vanguardiasur.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.