From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()
Date: Mon, 21 Jul 2014 10:10:43 -0500 [thread overview]
Message-ID: <20140721151043.GF6852@saruman.home> (raw)
In-Reply-To: <20140721100307.21172b65@ipc1.ka-ro>
Hi,,
On Mon, Jul 21, 2014 at 10:03:07AM +0200, Lothar Wa?mann wrote:
> Hi,
>
> > On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Wa?mann wrote:
> > > This patch makes it possible to use the musb driver with HW that
> > > requires external regulators or clocks.
> >
> > can you provide an example of such HW ? Are you not using the internal
> > PHYs ?
> >
> The Ka-Ro electronics TX48 module uses the mmc0_clk pin as VBUSEN
> rathern than usb0_drvvbus. This patch makes it possible to use an
> external regulator to handle the VBUS switch through the 'vcc-supply'
> property of the underlying generic_phy device.
OK, I get it now. But why would not use usb0_drvvbus ? You could still
route usb0_drvvbus to the regulator enable pin and the regulator would
be enabled for you once correct values are written to the IP's mailbox.
I suppose this has something to do with layout constraints ?
cheers
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140721/e1f8ee68/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: <balbi@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
George Cherian <george.cherian@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()
Date: Mon, 21 Jul 2014 10:10:43 -0500 [thread overview]
Message-ID: <20140721151043.GF6852@saruman.home> (raw)
In-Reply-To: <20140721100307.21172b65@ipc1.ka-ro>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
Hi,,
On Mon, Jul 21, 2014 at 10:03:07AM +0200, Lothar Waßmann wrote:
> Hi,
>
> > On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote:
> > > This patch makes it possible to use the musb driver with HW that
> > > requires external regulators or clocks.
> >
> > can you provide an example of such HW ? Are you not using the internal
> > PHYs ?
> >
> The Ka-Ro electronics TX48 module uses the mmc0_clk pin as VBUSEN
> rathern than usb0_drvvbus. This patch makes it possible to use an
> external regulator to handle the VBUS switch through the 'vcc-supply'
> property of the underlying generic_phy device.
OK, I get it now. But why would not use usb0_drvvbus ? You could still
route usb0_drvvbus to the regulator enable pin and the regulator would
be enabled for you once correct values are written to the IP's mailbox.
I suppose this has something to do with layout constraints ?
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-21 15:10 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:31 [PATCH 0/9] usb: musb: several bugfixes for the musb driver Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 1/9] usb: musb: core: cleanup - remove some useless 'break's from switch statements Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 2/9] usb: phy: am335x: group the #includes by subdirs Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 3/9] usb: musb_am335x: source cleanup Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 4/9] usb: phy: am335x-control: prevent module from being unloaded when in use Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 5/9] usb: musb: print error message with dev_err() instead of dev_dbg() Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 6/9] usb: musb: core: properly setup the HW before registering it to the USB core Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 7/9] usb: phy: am335x: setup the gen_phy function pointers _before_ adding the phy Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown() Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 9:31 ` [PATCH 9/9] usb: musb: musb_am335x: reinstate module loading/unloading support Lothar Waßmann
2014-07-18 9:31 ` Lothar Waßmann
2014-07-18 14:04 ` Felipe Balbi
2014-07-18 14:04 ` Felipe Balbi
2014-07-18 14:04 ` Felipe Balbi
2014-07-22 7:49 ` Lothar Waßmann
2014-07-22 7:49 ` Lothar Waßmann
2014-07-22 7:49 ` Lothar Waßmann
2014-07-22 14:47 ` Felipe Balbi
2014-07-22 14:47 ` Felipe Balbi
2014-07-22 14:47 ` Felipe Balbi
2014-07-18 13:57 ` [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown() Felipe Balbi
2014-07-18 13:57 ` Felipe Balbi
2014-07-21 8:03 ` Lothar Waßmann
2014-07-21 8:03 ` Lothar Waßmann
2014-07-21 15:10 ` Felipe Balbi [this message]
2014-07-21 15:10 ` Felipe Balbi
2014-07-22 8:06 ` Lothar Waßmann
2014-07-22 8:06 ` Lothar Waßmann
2014-07-22 14:47 ` Felipe Balbi
2014-07-22 14:47 ` Felipe Balbi
2014-07-18 13:54 ` [PATCH 7/9] usb: phy: am335x: setup the gen_phy function pointers _before_ adding the phy Felipe Balbi
2014-07-18 13:54 ` Felipe Balbi
2014-07-18 13:52 ` [PATCH 6/9] usb: musb: core: properly setup the HW before registering it to the USB core Felipe Balbi
2014-07-18 13:52 ` Felipe Balbi
2014-07-18 13:50 ` [PATCH 5/9] usb: musb: print error message with dev_err() instead of dev_dbg() Felipe Balbi
2014-07-18 13:50 ` Felipe Balbi
2014-07-18 13:50 ` [PATCH 4/9] usb: phy: am335x-control: prevent module from being unloaded when in use Felipe Balbi
2014-07-18 13:50 ` Felipe Balbi
2014-07-18 13:45 ` [PATCH 3/9] usb: musb_am335x: source cleanup Felipe Balbi
2014-07-18 13:45 ` Felipe Balbi
2014-07-18 13:45 ` [PATCH 2/9] usb: phy: am335x: group the #includes by subdirs Felipe Balbi
2014-07-18 13:45 ` Felipe Balbi
2014-07-18 13:44 ` [PATCH 1/9] usb: musb: core: cleanup - remove some useless 'break's from switch statements Felipe Balbi
2014-07-18 13:44 ` Felipe Balbi
2014-07-18 16:16 ` [PATCH 0/9] usb: musb: several bugfixes for the musb driver Ezequiel Garcia
2014-07-18 16:16 ` Ezequiel Garcia
2014-07-18 16:50 ` Felipe Balbi
2014-07-18 16:50 ` Felipe Balbi
2014-07-21 7:34 ` Lothar Waßmann
2014-07-21 7:34 ` Lothar Waßmann
2014-07-21 15:11 ` Felipe Balbi
2014-07-21 15:11 ` Felipe Balbi
2014-07-21 15:53 ` Ezequiel Garcia
2014-07-21 15:53 ` Ezequiel Garcia
2014-07-21 15:58 ` Felipe Balbi
2014-07-21 15:58 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721151043.GF6852@saruman.home \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.