From: Dimitri Sivanich <sivanich@sgi.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid
Date: Mon, 21 Jul 2014 20:12:09 +0000 [thread overview]
Message-ID: <20140721201209.GA19927@sgi.com> (raw)
In-Reply-To: <1405605307-13657-1-git-send-email-andrey.krieger.utkin@gmail.com>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Thu, Jul 17, 2014 at 04:55:07PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if
> unsigned variable 'gid' is less than zero.
>
> if (req.gid >= gru_max_gids || req.gid < 0)
> return -EINVAL;
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id€461
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
> ---
> drivers/misc/sgi-gru/grukdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
> index a3700a5..e0e0e7e 100644
> --- a/drivers/misc/sgi-gru/grukdump.c
> +++ b/drivers/misc/sgi-gru/grukdump.c
> @@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
> return -EFAULT;
>
> /* Currently, only dump by gid is implemented */
> - if (req.gid >= gru_max_gids || req.gid < 0)
> + if (req.gid >= gru_max_gids)
> return -EINVAL;
>
> gru = GID_TO_GRU(req.gid);
> --
> 1.8.5.5
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dimitri Sivanich <sivanich@sgi.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid
Date: Mon, 21 Jul 2014 15:12:09 -0500 [thread overview]
Message-ID: <20140721201209.GA19927@sgi.com> (raw)
In-Reply-To: <1405605307-13657-1-git-send-email-andrey.krieger.utkin@gmail.com>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Thu, Jul 17, 2014 at 04:55:07PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if
> unsigned variable 'gid' is less than zero.
>
> if (req.gid >= gru_max_gids || req.gid < 0)
> return -EINVAL;
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80461
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
> ---
> drivers/misc/sgi-gru/grukdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
> index a3700a5..e0e0e7e 100644
> --- a/drivers/misc/sgi-gru/grukdump.c
> +++ b/drivers/misc/sgi-gru/grukdump.c
> @@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
> return -EFAULT;
>
> /* Currently, only dump by gid is implemented */
> - if (req.gid >= gru_max_gids || req.gid < 0)
> + if (req.gid >= gru_max_gids)
> return -EINVAL;
>
> gru = GID_TO_GRU(req.gid);
> --
> 1.8.5.5
next prev parent reply other threads:[~2014-07-21 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 13:55 [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid Andrey Utkin
2014-07-17 13:55 ` Andrey Utkin
2014-07-21 20:12 ` Dimitri Sivanich [this message]
2014-07-21 20:12 ` Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721201209.GA19927@sgi.com \
--to=sivanich@sgi.com \
--cc=andrey.krieger.utkin@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.