All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid
@ 2014-07-17 13:55 ` Andrey Utkin
  0 siblings, 0 replies; 4+ messages in thread
From: Andrey Utkin @ 2014-07-17 13:55 UTC (permalink / raw)
  To: linux-kernel, kernel-janitors; +Cc: sivanich, Andrey Utkin

[linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if
unsigned variable 'gid' is less than zero.

    if (req.gid >= gru_max_gids || req.gid < 0)
        return -EINVAL;

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id€461
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
---
 drivers/misc/sgi-gru/grukdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
index a3700a5..e0e0e7e 100644
--- a/drivers/misc/sgi-gru/grukdump.c
+++ b/drivers/misc/sgi-gru/grukdump.c
@@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
 		return -EFAULT;
 
 	/* Currently, only dump by gid is implemented */
-	if (req.gid >= gru_max_gids || req.gid < 0)
+	if (req.gid >= gru_max_gids)
 		return -EINVAL;
 
 	gru = GID_TO_GRU(req.gid);
-- 
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid
@ 2014-07-17 13:55 ` Andrey Utkin
  0 siblings, 0 replies; 4+ messages in thread
From: Andrey Utkin @ 2014-07-17 13:55 UTC (permalink / raw)
  To: linux-kernel, kernel-janitors; +Cc: sivanich, Andrey Utkin

[linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if
unsigned variable 'gid' is less than zero.

    if (req.gid >= gru_max_gids || req.gid < 0)
        return -EINVAL;

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80461
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
---
 drivers/misc/sgi-gru/grukdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
index a3700a5..e0e0e7e 100644
--- a/drivers/misc/sgi-gru/grukdump.c
+++ b/drivers/misc/sgi-gru/grukdump.c
@@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
 		return -EFAULT;
 
 	/* Currently, only dump by gid is implemented */
-	if (req.gid >= gru_max_gids || req.gid < 0)
+	if (req.gid >= gru_max_gids)
 		return -EINVAL;
 
 	gru = GID_TO_GRU(req.gid);
-- 
1.8.5.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid
  2014-07-17 13:55 ` Andrey Utkin
@ 2014-07-21 20:12   ` Dimitri Sivanich
  -1 siblings, 0 replies; 4+ messages in thread
From: Dimitri Sivanich @ 2014-07-21 20:12 UTC (permalink / raw)
  To: Andrey Utkin; +Cc: linux-kernel, kernel-janitors

Acked-by: Dimitri Sivanich <sivanich@sgi.com>

On Thu, Jul 17, 2014 at 04:55:07PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if
> unsigned variable 'gid' is less than zero.
> 
>     if (req.gid >= gru_max_gids || req.gid < 0)
>         return -EINVAL;
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id€461
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
> ---
>  drivers/misc/sgi-gru/grukdump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
> index a3700a5..e0e0e7e 100644
> --- a/drivers/misc/sgi-gru/grukdump.c
> +++ b/drivers/misc/sgi-gru/grukdump.c
> @@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
>  		return -EFAULT;
>  
>  	/* Currently, only dump by gid is implemented */
> -	if (req.gid >= gru_max_gids || req.gid < 0)
> +	if (req.gid >= gru_max_gids)
>  		return -EINVAL;
>  
>  	gru = GID_TO_GRU(req.gid);
> -- 
> 1.8.5.5
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid
@ 2014-07-21 20:12   ` Dimitri Sivanich
  0 siblings, 0 replies; 4+ messages in thread
From: Dimitri Sivanich @ 2014-07-21 20:12 UTC (permalink / raw)
  To: Andrey Utkin; +Cc: linux-kernel, kernel-janitors

Acked-by: Dimitri Sivanich <sivanich@sgi.com>

On Thu, Jul 17, 2014 at 04:55:07PM +0300, Andrey Utkin wrote:
> [linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if
> unsigned variable 'gid' is less than zero.
> 
>     if (req.gid >= gru_max_gids || req.gid < 0)
>         return -EINVAL;
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80461
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
> ---
>  drivers/misc/sgi-gru/grukdump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c
> index a3700a5..e0e0e7e 100644
> --- a/drivers/misc/sgi-gru/grukdump.c
> +++ b/drivers/misc/sgi-gru/grukdump.c
> @@ -196,7 +196,7 @@ int gru_dump_chiplet_request(unsigned long arg)
>  		return -EFAULT;
>  
>  	/* Currently, only dump by gid is implemented */
> -	if (req.gid >= gru_max_gids || req.gid < 0)
> +	if (req.gid >= gru_max_gids)
>  		return -EINVAL;
>  
>  	gru = GID_TO_GRU(req.gid);
> -- 
> 1.8.5.5

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-21 20:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-17 13:55 [PATCH 3/4] drivers/misc/sgi-gru/grukdump.c: drop negativity check for unsgined req.gid Andrey Utkin
2014-07-17 13:55 ` Andrey Utkin
2014-07-21 20:12 ` Dimitri Sivanich
2014-07-21 20:12   ` Dimitri Sivanich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.