From: Sebastian Herbszt <herbszt@gmx.de>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Sebastian Herbszt <herbszt@gmx.de>,
Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH] multipath: revert fstack-protector-strong gcc option
Date: Tue, 22 Jul 2014 11:58:05 +0200 [thread overview]
Message-ID: <20140722115805.00004b68@localhost> (raw)
In-Reply-To: <1405984252-26424-1-git-send-email-bmarzins@redhat.com>
Benjamin Marzinski wrote:
> In my "enable gcc format-security check" (9b7741c) commit, I changed
> fstack-protector to fstack-protector-strong. This new option only exists
> in gcc 4.9, which is relatively new. This patch reverts to the
> fstack-protector option for now, until gcc 4.9 has been around for longer.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> Makefile.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.inc b/Makefile.inc
> index 1486721..20ae23e 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -46,7 +46,7 @@ GZIP = gzip -9 -c
> INSTALL_PROGRAM = install
>
> ifndef RPM_OPT_FLAGS
> - RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
> + RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
> endif
>
> OPTFLAGS = $(RPM_OPT_FLAGS) -Wunused -Wstrict-prototypes
Tested-by: Sebastian Herbszt <herbszt@gmx.de>
next parent reply other threads:[~2014-07-22 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405984252-26424-1-git-send-email-bmarzins@redhat.com>
2014-07-22 9:58 ` Sebastian Herbszt [this message]
2014-07-21 23:12 [PATCH] multipath: revert fstack-protector-strong gcc option Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722115805.00004b68@localhost \
--to=herbszt@gmx.de \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@gmail.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.