All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] multipath: revert fstack-protector-strong gcc option
@ 2014-07-21 23:12 Benjamin Marzinski
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Marzinski @ 2014-07-21 23:12 UTC (permalink / raw)
  To: device-mapper development

In my "enable gcc format-security check" (9b7741c) commit, I changed
fstack-protector to fstack-protector-strong. This new option only exists
in gcc 4.9, which is relatively new.  This patch reverts to the
fstack-protector option for now, until gcc 4.9 has been around for longer.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index 1486721..20ae23e 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -46,7 +46,7 @@ GZIP        = gzip -9 -c
 INSTALL_PROGRAM = install
 
 ifndef RPM_OPT_FLAGS
-	RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
+	RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
 endif
 
 OPTFLAGS     = $(RPM_OPT_FLAGS) -Wunused -Wstrict-prototypes
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] multipath: revert fstack-protector-strong gcc option
       [not found] <1405984252-26424-1-git-send-email-bmarzins@redhat.com>
@ 2014-07-22  9:58 ` Sebastian Herbszt
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Herbszt @ 2014-07-22  9:58 UTC (permalink / raw)
  To: Benjamin Marzinski
  Cc: device-mapper development, Sebastian Herbszt, Christophe Varoqui

Benjamin Marzinski wrote:
> In my "enable gcc format-security check" (9b7741c) commit, I changed
> fstack-protector to fstack-protector-strong. This new option only exists
> in gcc 4.9, which is relatively new.  This patch reverts to the
> fstack-protector option for now, until gcc 4.9 has been around for longer.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  Makefile.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.inc b/Makefile.inc
> index 1486721..20ae23e 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -46,7 +46,7 @@ GZIP        = gzip -9 -c
>  INSTALL_PROGRAM = install
>  
>  ifndef RPM_OPT_FLAGS
> -	RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
> +	RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
>  endif
>  
>  OPTFLAGS     = $(RPM_OPT_FLAGS) -Wunused -Wstrict-prototypes

Tested-by: Sebastian Herbszt <herbszt@gmx.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-22  9:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1405984252-26424-1-git-send-email-bmarzins@redhat.com>
2014-07-22  9:58 ` [PATCH] multipath: revert fstack-protector-strong gcc option Sebastian Herbszt
2014-07-21 23:12 Benjamin Marzinski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.