All of lore.kernel.org
 help / color / mirror / Atom feed
From: k.khlebnikov@samsung.com (Konstantin Khlebnikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: LPAE: load upper bits of early TTBR0/TTBR1
Date: Tue, 22 Jul 2014 19:36:23 +0400	[thread overview]
Message-ID: <20140722153623.25088.37742.stgit@buzz> (raw)

This patch fixes booting when idmap pgd lays above 4gb. Commit
4756dcbfd37 mostly had fixed this, but it'd failed to load upper bits.

Also this fixes adding TTBR1_OFFSET to TTRR1: if lower part overflows
carry flag must be added to the upper part.

Signed-off-by: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
Cc: Cyril Chemparathy <cyril@ti.com>
Cc: Vitaly Andrianov <vitalya@ti.com>
---
 arch/arm/mm/proc-v7-3level.S |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mm/proc-v7-3level.S b/arch/arm/mm/proc-v7-3level.S
index 22e3ad6..f0481dd 100644
--- a/arch/arm/mm/proc-v7-3level.S
+++ b/arch/arm/mm/proc-v7-3level.S
@@ -140,12 +140,11 @@ ENDPROC(cpu_v7_set_pte_ext)
 	mov	\tmp, \ttbr1, lsr #(32 - ARCH_PGD_SHIFT)	@ upper bits
 	mov	\ttbr1, \ttbr1, lsl #ARCH_PGD_SHIFT		@ lower bits
 	addls	\ttbr1, \ttbr1, #TTBR1_OFFSET
-	mcrr	p15, 1, \ttbr1, \zero, c2			@ load TTBR1
+	adcls	\tmp, \tmp, #0
+	mcrr	p15, 1, \ttbr1, \tmp, c2			@ load TTBR1
 	mov	\tmp, \ttbr0, lsr #(32 - ARCH_PGD_SHIFT)	@ upper bits
 	mov	\ttbr0, \ttbr0, lsl #ARCH_PGD_SHIFT		@ lower bits
-	mcrr	p15, 0, \ttbr0, \zero, c2			@ load TTBR0
-	mcrr	p15, 1, \ttbr1, \zero, c2			@ load TTBR1
-	mcrr	p15, 0, \ttbr0, \zero, c2			@ load TTBR0
+	mcrr	p15, 0, \ttbr0, \tmp, c2			@ load TTBR0
 	.endm
 
 	/*

WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
To: Russell King <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org
Cc: Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, Vitaly Andrianov <vitalya@ti.com>,
	Cyril Chemparathy <cyril@ti.com>
Subject: [PATCH 1/2] ARM: LPAE: load upper bits of early TTBR0/TTBR1
Date: Tue, 22 Jul 2014 19:36:23 +0400	[thread overview]
Message-ID: <20140722153623.25088.37742.stgit@buzz> (raw)

This patch fixes booting when idmap pgd lays above 4gb. Commit
4756dcbfd37 mostly had fixed this, but it'd failed to load upper bits.

Also this fixes adding TTBR1_OFFSET to TTRR1: if lower part overflows
carry flag must be added to the upper part.

Signed-off-by: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
Cc: Cyril Chemparathy <cyril@ti.com>
Cc: Vitaly Andrianov <vitalya@ti.com>
---
 arch/arm/mm/proc-v7-3level.S |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mm/proc-v7-3level.S b/arch/arm/mm/proc-v7-3level.S
index 22e3ad6..f0481dd 100644
--- a/arch/arm/mm/proc-v7-3level.S
+++ b/arch/arm/mm/proc-v7-3level.S
@@ -140,12 +140,11 @@ ENDPROC(cpu_v7_set_pte_ext)
 	mov	\tmp, \ttbr1, lsr #(32 - ARCH_PGD_SHIFT)	@ upper bits
 	mov	\ttbr1, \ttbr1, lsl #ARCH_PGD_SHIFT		@ lower bits
 	addls	\ttbr1, \ttbr1, #TTBR1_OFFSET
-	mcrr	p15, 1, \ttbr1, \zero, c2			@ load TTBR1
+	adcls	\tmp, \tmp, #0
+	mcrr	p15, 1, \ttbr1, \tmp, c2			@ load TTBR1
 	mov	\tmp, \ttbr0, lsr #(32 - ARCH_PGD_SHIFT)	@ upper bits
 	mov	\ttbr0, \ttbr0, lsl #ARCH_PGD_SHIFT		@ lower bits
-	mcrr	p15, 0, \ttbr0, \zero, c2			@ load TTBR0
-	mcrr	p15, 1, \ttbr1, \zero, c2			@ load TTBR1
-	mcrr	p15, 0, \ttbr0, \zero, c2			@ load TTBR0
+	mcrr	p15, 0, \ttbr0, \tmp, c2			@ load TTBR0
 	.endm
 
 	/*


             reply	other threads:[~2014-07-22 15:36 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 15:36 Konstantin Khlebnikov [this message]
2014-07-22 15:36 ` [PATCH 1/2] ARM: LPAE: load upper bits of early TTBR0/TTBR1 Konstantin Khlebnikov
2014-07-22 15:36 ` [PATCH 2/2] ARM: LPAE: reduce damage caused by idmap to virtual memory layout Konstantin Khlebnikov
2014-07-22 15:36   ` Konstantin Khlebnikov
2014-07-28 18:14   ` Will Deacon
2014-07-28 18:14     ` Will Deacon
2014-07-28 18:25     ` Konstantin Khlebnikov
2014-07-28 18:25       ` Konstantin Khlebnikov
2014-07-28 18:41       ` Will Deacon
2014-07-28 18:41         ` Will Deacon
2014-07-28 18:57         ` Konstantin Khlebnikov
2014-07-28 18:57           ` Konstantin Khlebnikov
2014-07-28 19:06           ` Will Deacon
2014-07-28 19:06             ` Will Deacon
2014-07-28 19:13           ` Russell King - ARM Linux
2014-07-28 19:13             ` Russell King - ARM Linux
2014-07-28 19:29             ` Konstantin Khlebnikov
2014-07-28 19:29               ` Konstantin Khlebnikov
2014-07-28 19:34               ` Konstantin Khlebnikov
2014-07-28 19:34                 ` Konstantin Khlebnikov
2014-07-28 19:42               ` Russell King - ARM Linux
2014-07-28 19:42                 ` Russell King - ARM Linux
2014-07-28 19:57                 ` Konstantin Khlebnikov
2014-07-28 19:57                   ` Konstantin Khlebnikov
2014-07-29 10:57                   ` Russell King - ARM Linux
2014-07-29 10:57                     ` Russell King - ARM Linux
2014-07-29 12:37                     ` Konstantin Khlebnikov
2014-07-29 12:37                       ` Konstantin Khlebnikov
2014-07-28 18:12 ` [PATCH 1/2] ARM: LPAE: load upper bits of early TTBR0/TTBR1 Will Deacon
2014-07-28 18:12   ` Will Deacon
2014-07-28 18:40   ` Konstantin Khlebnikov
2014-07-28 18:40     ` Konstantin Khlebnikov
2014-07-28 18:47     ` Will Deacon
2014-07-28 18:47       ` Will Deacon
2014-07-29 11:15       ` Will Deacon
2014-07-29 11:15         ` Will Deacon
2014-07-29 12:29       ` Konstantin Khlebnikov
2014-07-29 12:29         ` Konstantin Khlebnikov
2014-08-27 15:26         ` Jassi Brar
2014-08-27 15:26           ` Jassi Brar
2014-08-27 15:31           ` Konstantin Khlebnikov
2014-08-27 15:31             ` Konstantin Khlebnikov
2014-08-27 15:33             ` Konstantin Khlebnikov
2014-08-27 15:33               ` Konstantin Khlebnikov
2014-08-27 15:45             ` Jassi Brar
2014-08-27 15:45               ` Jassi Brar
2014-08-28 11:03               ` Will Deacon
2014-08-28 11:03                 ` Will Deacon
2014-08-28 11:50                 ` Konstantin Khlebnikov
2014-08-28 11:50                   ` Konstantin Khlebnikov
2014-08-05 15:42 ` Konstantin Khlebnikov
2014-08-05 15:42   ` Konstantin Khlebnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140722153623.25088.37742.stgit@buzz \
    --to=k.khlebnikov@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.