All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: "Mugunthan V N" <mugunthanvnm@ti.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	kernel@pengutronix.de
Subject: Re: [PATCH v3 5/7] net: cpsw: Add am33xx MACID readout
Date: Tue, 19 Aug 2014 10:50:02 +0200	[thread overview]
Message-ID: <20140819085002.GE12930@pengutronix.de> (raw)
In-Reply-To: <CABxcv=npv6bRq=VF8RT5trNxUzDj3bAm-PkvDEhcLVJ+uf8hCg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

Hi,

On Tue, Aug 19, 2014 at 12:50:59AM +0200, Javier Martinez Canillas wrote:
> Hello Mugunthan,
> 
> On Mon, Aug 18, 2014 at 9:58 PM, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> >>
> >> Thus, for this patchset, as is:
> >>
> >> Tested-by: Steven Rostedt <rostedt@goodmis.org>
> >
> > This will fail for DRA7xx not in AM33xx
> >
> 
> cpsw_am33xx_cm_get_macid() checks for
> of_machine_is_compatible("ti,am33xx") and returns 0 if the machine is
> not an am33xx. cpsw_probe_dt() only propagates the return value if is
> not 0 so this patch does not change the semantics for other SoCs
> besides am33xx.

Yes, this patch is only about the am33xx. I don't have the DRA7xx
hardware so I am not able to test on that hardware. Mugunthan, perhaps
you can supply some followup patches for DRA7xx.

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/7] net: cpsw: Add am33xx MACID readout
Date: Tue, 19 Aug 2014 10:50:02 +0200	[thread overview]
Message-ID: <20140819085002.GE12930@pengutronix.de> (raw)
In-Reply-To: <CABxcv=npv6bRq=VF8RT5trNxUzDj3bAm-PkvDEhcLVJ+uf8hCg@mail.gmail.com>

Hi,

On Tue, Aug 19, 2014 at 12:50:59AM +0200, Javier Martinez Canillas wrote:
> Hello Mugunthan,
> 
> On Mon, Aug 18, 2014 at 9:58 PM, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> >>
> >> Thus, for this patchset, as is:
> >>
> >> Tested-by: Steven Rostedt <rostedt@goodmis.org>
> >
> > This will fail for DRA7xx not in AM33xx
> >
> 
> cpsw_am33xx_cm_get_macid() checks for
> of_machine_is_compatible("ti,am33xx") and returns 0 if the machine is
> not an am33xx. cpsw_probe_dt() only propagates the return value if is
> not 0 so this patch does not change the semantics for other SoCs
> besides am33xx.

Yes, this patch is only about the am33xx. I don't have the DRA7xx
hardware so I am not able to test on that hardware. Mugunthan, perhaps
you can supply some followup patches for DRA7xx.

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140819/ce9402ff/attachment-0001.sig>

  reply	other threads:[~2014-08-19  8:50 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-16 15:18 [PATCH v3 0/7] net: cpsw: Support for am335x chip MACIDs Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 1/7] DT doc: net: cpsw mac-address is optional Markus Pargmann
2014-08-16 15:18   ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 2/7] net: cpsw: Add missing return value Markus Pargmann
2014-08-16 15:18   ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 3/7] net: cpsw: header, Add missing include Markus Pargmann
2014-08-16 15:18   ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 4/7] net: cpsw: Replace pr_err by dev_err Markus Pargmann
2014-08-16 15:18   ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 5/7] net: cpsw: Add am33xx MACID readout Markus Pargmann
2014-08-16 15:18   ` Markus Pargmann
2014-08-16 16:46   ` Wolfram Sang
2014-08-16 16:46     ` Wolfram Sang
2014-08-18  6:58     ` Markus Pargmann
2014-08-18  6:58       ` Markus Pargmann
2014-08-16 16:53   ` Wolfram Sang
2014-08-16 16:53     ` Wolfram Sang
2014-08-18  7:03     ` Markus Pargmann
2014-08-18  7:03       ` Markus Pargmann
2014-08-18 18:24   ` Mugunthan V N
2014-08-18 18:24     ` Mugunthan V N
2014-08-18 19:41     ` Steven Rostedt
2014-08-18 19:41       ` Steven Rostedt
2014-08-18 19:58       ` Mugunthan V N
2014-08-18 19:58         ` Mugunthan V N
2014-08-18 20:57         ` Steven Rostedt
2014-08-18 20:57           ` Steven Rostedt
2014-08-18 22:50         ` Javier Martinez Canillas
2014-08-18 22:50           ` Javier Martinez Canillas
2014-08-19  8:50           ` Markus Pargmann [this message]
2014-08-19  8:50             ` Markus Pargmann
2014-08-19 16:37             ` Mugunthan V N
2014-08-19 16:37               ` Mugunthan V N
2014-08-16 15:18 ` [PATCH v3 6/7] am33xx: define syscon control module device node Markus Pargmann
2014-08-16 15:18   ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 7/7] arm: dts: am33xx, Add syscon phandle to cpsw node Markus Pargmann
2014-08-16 15:18   ` Markus Pargmann
     [not found] ` <1408202315-20006-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-08-16 16:55   ` [PATCH v3 0/7] net: cpsw: Support for am335x chip MACIDs Wolfram Sang
2014-08-16 16:55     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140819085002.GE12930@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=bcousson@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@dowhile0.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mugunthanvnm@ti.com \
    --cc=rostedt@goodmis.org \
    --cc=tony@atomide.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.