From: Mugunthan V N <mugunthanvnm@ti.com>
To: Markus Pargmann <mpa@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Steven Rostedt" <rostedt@goodmis.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 5/7] net: cpsw: Add am33xx MACID readout
Date: Mon, 18 Aug 2014 23:54:26 +0530 [thread overview]
Message-ID: <53F244DA.3070803@ti.com> (raw)
In-Reply-To: <1408202315-20006-6-git-send-email-mpa@pengutronix.de>
On Saturday 16 August 2014 08:48 PM, Markus Pargmann wrote:
> + mac_addr[5] = (macid_lo >> 8) & 0xff;
> + mac_addr[4] = macid_lo & 0xff;
> + mac_addr[3] = (macid_hi >> 24) & 0xff;
> + mac_addr[2] = (macid_hi >> 16) & 0xff;
> + mac_addr[1] = (macid_hi >> 8) & 0xff;
> + mac_addr[0] = macid_hi & 0xff;
> +
This will fail incase of DRA74x and DRA72x platforms, please check for
u-boot src for parsing logic as TRM is not out yet. Below is the actual
code for DRA7 platforms for MAC address parsing
mac_addr[0] = (mac_hi & 0xFF0000) >> 16;
mac_addr[1] = (mac_hi & 0xFF00) >> 8;
mac_addr[2] = mac_hi & 0xFF;
mac_addr[3] = (mac_lo & 0xFF0000) >> 16;
mac_addr[4] = (mac_lo & 0xFF00) >> 8;
mac_addr[5] = mac_lo & 0xFF;
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: mugunthanvnm@ti.com (Mugunthan V N)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/7] net: cpsw: Add am33xx MACID readout
Date: Mon, 18 Aug 2014 23:54:26 +0530 [thread overview]
Message-ID: <53F244DA.3070803@ti.com> (raw)
In-Reply-To: <1408202315-20006-6-git-send-email-mpa@pengutronix.de>
On Saturday 16 August 2014 08:48 PM, Markus Pargmann wrote:
> + mac_addr[5] = (macid_lo >> 8) & 0xff;
> + mac_addr[4] = macid_lo & 0xff;
> + mac_addr[3] = (macid_hi >> 24) & 0xff;
> + mac_addr[2] = (macid_hi >> 16) & 0xff;
> + mac_addr[1] = (macid_hi >> 8) & 0xff;
> + mac_addr[0] = macid_hi & 0xff;
> +
This will fail incase of DRA74x and DRA72x platforms, please check for
u-boot src for parsing logic as TRM is not out yet. Below is the actual
code for DRA7 platforms for MAC address parsing
mac_addr[0] = (mac_hi & 0xFF0000) >> 16;
mac_addr[1] = (mac_hi & 0xFF00) >> 8;
mac_addr[2] = mac_hi & 0xFF;
mac_addr[3] = (mac_lo & 0xFF0000) >> 16;
mac_addr[4] = (mac_lo & 0xFF00) >> 8;
mac_addr[5] = mac_lo & 0xFF;
Regards
Mugunthan V N
next prev parent reply other threads:[~2014-08-18 18:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 15:18 [PATCH v3 0/7] net: cpsw: Support for am335x chip MACIDs Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 1/7] DT doc: net: cpsw mac-address is optional Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 2/7] net: cpsw: Add missing return value Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 3/7] net: cpsw: header, Add missing include Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 4/7] net: cpsw: Replace pr_err by dev_err Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 5/7] net: cpsw: Add am33xx MACID readout Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
2014-08-16 16:46 ` Wolfram Sang
2014-08-16 16:46 ` Wolfram Sang
2014-08-18 6:58 ` Markus Pargmann
2014-08-18 6:58 ` Markus Pargmann
2014-08-16 16:53 ` Wolfram Sang
2014-08-16 16:53 ` Wolfram Sang
2014-08-18 7:03 ` Markus Pargmann
2014-08-18 7:03 ` Markus Pargmann
2014-08-18 18:24 ` Mugunthan V N [this message]
2014-08-18 18:24 ` Mugunthan V N
2014-08-18 19:41 ` Steven Rostedt
2014-08-18 19:41 ` Steven Rostedt
2014-08-18 19:58 ` Mugunthan V N
2014-08-18 19:58 ` Mugunthan V N
2014-08-18 20:57 ` Steven Rostedt
2014-08-18 20:57 ` Steven Rostedt
2014-08-18 22:50 ` Javier Martinez Canillas
2014-08-18 22:50 ` Javier Martinez Canillas
2014-08-19 8:50 ` Markus Pargmann
2014-08-19 8:50 ` Markus Pargmann
2014-08-19 16:37 ` Mugunthan V N
2014-08-19 16:37 ` Mugunthan V N
2014-08-16 15:18 ` [PATCH v3 6/7] am33xx: define syscon control module device node Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 7/7] arm: dts: am33xx, Add syscon phandle to cpsw node Markus Pargmann
2014-08-16 15:18 ` Markus Pargmann
[not found] ` <1408202315-20006-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-08-16 16:55 ` [PATCH v3 0/7] net: cpsw: Support for am335x chip MACIDs Wolfram Sang
2014-08-16 16:55 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F244DA.3070803@ti.com \
--to=mugunthanvnm@ti.com \
--cc=bcousson@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=rostedt@goodmis.org \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.