Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Sergey Senozhatsky <sergey.senozhatsky at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

On (08/13/14 21:28), Nanley Chery wrote:
> Starting in kernel 2.6.29, the highest power savings level increased to "2".
> However, in kernel 3.5, the sched power savings feature was removed altogether.

hello,
thanks for reporting,


so, it's been removed 2 years ago (3.5 release date was 21 Jul 2012).

do we need to support it at all?

	-ss

> Signed-off-by: Nanley Chery <nanleychery(a)gmail.com>
> ---
>  src/tuning/tuning.cpp | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/tuning/tuning.cpp b/src/tuning/tuning.cpp
> index 6367a20..ea1905b 100644
> --- a/src/tuning/tuning.cpp
> +++ b/src/tuning/tuning.cpp
> @@ -28,6 +28,7 @@
>  #include <stdio.h>
>  #include <string.h>
>  #include <ncurses.h>
> +#include <linux/version.h>
>  
>  
>  #include "tuning.h"
> @@ -58,7 +59,9 @@ static void init_tuning(void)
>  {
>  	add_sysfs_tunable(_("Enable Audio codec power management"), "/sys/module/snd_hda_intel/parameters/power_save", "1");
>  	add_sysfs_tunable(_("NMI watchdog should be turned off"), "/proc/sys/kernel/nmi_watchdog", "0");
> -	add_sysfs_tunable(_("Power Aware CPU scheduler"), "/sys/devices/system/cpu/sched_mc_power_savings", "1");
> +#if LINUX_VERSION_CODE <= KERNEL_VERSION(3,4,0)
> +	add_sysfs_tunable(_("Power Aware CPU scheduler"), "/sys/devices/system/cpu/sched_mc_power_savings", "2");
> +#endif
>  	add_sysfs_tunable(_("VM writeback timeout"), "/proc/sys/vm/dirty_writeback_centisecs", "1500");
>  	add_sata_tunables();
>  	add_usb_tunables();
> -- 
> 2.0.4
> 
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>