Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

On (08/13/14 21:28), Nanley Chery wrote:
> Starting in kernel 2.6.29, the highest power savings level increased to "2".
> However, in kernel 3.5, the sched power savings feature was removed altogether.

hello,
thanks for reporting,


so, it's been removed 2 years ago (3.5 release date was 21 Jul 2012).

do we need to support it at all?

	-ss

> Signed-off-by: Nanley Chery <nanleychery(a)gmail.com>
> ---
>  src/tuning/tuning.cpp | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/tuning/tuning.cpp b/src/tuning/tuning.cpp
> index 6367a20..ea1905b 100644
> --- a/src/tuning/tuning.cpp
> +++ b/src/tuning/tuning.cpp
> @@ -28,6 +28,7 @@
>  #include <stdio.h>
>  #include <string.h>
>  #include <ncurses.h>
> +#include <linux/version.h>
>  
>  
>  #include "tuning.h"
> @@ -58,7 +59,9 @@ static void init_tuning(void)
>  {
>  	add_sysfs_tunable(_("Enable Audio codec power management"), "/sys/module/snd_hda_intel/parameters/power_save", "1");
>  	add_sysfs_tunable(_("NMI watchdog should be turned off"), "/proc/sys/kernel/nmi_watchdog", "0");
> -	add_sysfs_tunable(_("Power Aware CPU scheduler"), "/sys/devices/system/cpu/sched_mc_power_savings", "1");
> +#if LINUX_VERSION_CODE <= KERNEL_VERSION(3,4,0)
> +	add_sysfs_tunable(_("Power Aware CPU scheduler"), "/sys/devices/system/cpu/sched_mc_power_savings", "2");
> +#endif
>  	add_sysfs_tunable(_("VM writeback timeout"), "/proc/sys/vm/dirty_writeback_centisecs", "1500");
>  	add_sata_tunables();
>  	add_usb_tunables();
> -- 
> 2.0.4
> 
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
> 

Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Nanley Chery]

[-- Attachment #1: Type: text/plain, Size: 3303 bytes --]

On Tue, Sep 30, 2014 at 6:46 PM, Alexandra Yates <
alexandra.yates(a)linux.intel.com> wrote:

>
> > Hi Alexandra,
> >
> > Since we're going to require a later kernel, I think we should also
> remove
> > the line that adds the (currently broken) sysfs_tunable for this feature
> > as
> > well.
> >
> > Cheers,
> > Nanley
> >
> > On Mon, Sep 29, 2014 at 1:43 PM, Alexandra Yates <
> > alexandra.yates(a)linux.intel.com> wrote:
> >
> >>
> >> > On Fri, Aug 22, 2014 at 9:10 PM, Alexandra Yates <
> >> > alexandra.yates(a)linux.intel.com> wrote:
> >> >
> >> >>
> >> >> > On Tue, Aug 19, 2014 at 7:49 AM, Sergey Senozhatsky <
> >> >> > sergey.senozhatsky(a)gmail.com> wrote:
> >> >> >
> >> >> >> On (08/13/14 21:28), Nanley Chery wrote:
> >> >> >> > Starting in kernel 2.6.29, the highest power savings level
> >> >> increased
> >> >> >> to
> >> >> >> "2".
> >> >> >> > However, in kernel 3.5, the sched power savings feature was
> >> removed
> >> >> >> altogether.
> >> >> >>
> >> >> >> hello,
> >> >> >> thanks for reporting,
> >> >> >>
> >> >> >>
> >> >> >> so, it's been removed 2 years ago (3.5 release date was 21 Jul
> >> 2012).
> >> >> >>
> >> >> >> do we need to support it at all?
> >> >> >
> >> >> >
> >> >> > Hello,
> >> >> >
> >> >> > Good question. Our README file indicates linux-kernel >= 2.6.38 to
> >> be
> >> >> a
> >> >> > build requirement. Does this mean we support power management
> >> features
> >> >> > starting from that kernel? Or does it mean that this is only a
> >> build
> >> >> > requirement and we target the latest kernels? It is not clear from
> >> the
> >> >> > current documentation.
> >> >> >
> >> >> > On a much smaller scope, supporting this feature is essentially
> >> free
> >> >> > (maintenance-wise) and would keep some of our end users on older
> >> >> kernels
> >> >> > happy. Btw, I submitted a simpler version 2 of this patch that does
> >> >> not
> >> >> > check for the kernel version.
> >> >> >
> >> >> > Thanks,
> >> >> > Nanley
> >> >> > _______________________________________________
> >> >> > PowerTop mailing list
> >> >> > PowerTop(a)lists.01.org
> >> >> > https://lists.01.org/mailman/listinfo/powertop
> >> >> >
> >> >>
> >> >> From PowerTOP 2.0 and up the requirement is to run at least Linux
> >> kernel
> >> >> 2.6.38. If it is not in the supported kernel then PowerTOP does not
> >> need
> >> >> it.
> >> >>
> >> >> Thank you,
> >> >> Alexandra.
> >> >>
> >> >
> >> > Since we're supporting kernels starting from 2.6.38 (which has this
> >> power
> >> > management feature itself), please consider this patch which produces
> >> the
> >> > correct behavior.
> >> >
> >> > Thanks,
> >> > Nanley
> >> >
> >>
> >> Hi Nanley,
> >>
> >> Thank you for your patch.  However, since this feature was faced out the
> >> kernel over two years ago it doesn't make sense to add it now to
> >> PowerTOP.
> >> I will update the release notes to use a later kernel.  Please excuse
> >> the
> >> confusion.
> >>
> >> Thank you,
> >> Alexandra.
> >>
> >>
> >
>
> This makes sense Nanley.  Since you have been working on this already,  Do
> you want to send a patch with this change?
>
> Sure, I just sent a patch with the change.

Cheers,
Nanley

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 5194 bytes --]

Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 2949 bytes --]


> Hi Alexandra,
>
> Since we're going to require a later kernel, I think we should also remove
> the line that adds the (currently broken) sysfs_tunable for this feature
> as
> well.
>
> Cheers,
> Nanley
>
> On Mon, Sep 29, 2014 at 1:43 PM, Alexandra Yates <
> alexandra.yates(a)linux.intel.com> wrote:
>
>>
>> > On Fri, Aug 22, 2014 at 9:10 PM, Alexandra Yates <
>> > alexandra.yates(a)linux.intel.com> wrote:
>> >
>> >>
>> >> > On Tue, Aug 19, 2014 at 7:49 AM, Sergey Senozhatsky <
>> >> > sergey.senozhatsky(a)gmail.com> wrote:
>> >> >
>> >> >> On (08/13/14 21:28), Nanley Chery wrote:
>> >> >> > Starting in kernel 2.6.29, the highest power savings level
>> >> increased
>> >> >> to
>> >> >> "2".
>> >> >> > However, in kernel 3.5, the sched power savings feature was
>> removed
>> >> >> altogether.
>> >> >>
>> >> >> hello,
>> >> >> thanks for reporting,
>> >> >>
>> >> >>
>> >> >> so, it's been removed 2 years ago (3.5 release date was 21 Jul
>> 2012).
>> >> >>
>> >> >> do we need to support it at all?
>> >> >
>> >> >
>> >> > Hello,
>> >> >
>> >> > Good question. Our README file indicates linux-kernel >= 2.6.38 to
>> be
>> >> a
>> >> > build requirement. Does this mean we support power management
>> features
>> >> > starting from that kernel? Or does it mean that this is only a
>> build
>> >> > requirement and we target the latest kernels? It is not clear from
>> the
>> >> > current documentation.
>> >> >
>> >> > On a much smaller scope, supporting this feature is essentially
>> free
>> >> > (maintenance-wise) and would keep some of our end users on older
>> >> kernels
>> >> > happy. Btw, I submitted a simpler version 2 of this patch that does
>> >> not
>> >> > check for the kernel version.
>> >> >
>> >> > Thanks,
>> >> > Nanley
>> >> > _______________________________________________
>> >> > PowerTop mailing list
>> >> > PowerTop(a)lists.01.org
>> >> > https://lists.01.org/mailman/listinfo/powertop
>> >> >
>> >>
>> >> From PowerTOP 2.0 and up the requirement is to run at least Linux
>> kernel
>> >> 2.6.38. If it is not in the supported kernel then PowerTOP does not
>> need
>> >> it.
>> >>
>> >> Thank you,
>> >> Alexandra.
>> >>
>> >
>> > Since we're supporting kernels starting from 2.6.38 (which has this
>> power
>> > management feature itself), please consider this patch which produces
>> the
>> > correct behavior.
>> >
>> > Thanks,
>> > Nanley
>> >
>>
>> Hi Nanley,
>>
>> Thank you for your patch.  However, since this feature was faced out the
>> kernel over two years ago it doesn't make sense to add it now to
>> PowerTOP.
>> I will update the release notes to use a later kernel.  Please excuse
>> the
>> confusion.
>>
>> Thank you,
>> Alexandra.
>>
>>
>

This makes sense Nanley.  Since you have been working on this already,  Do
you want to send a patch with this change?

Thank you,
Alexandra.

Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Nanley Chery]

[-- Attachment #1: Type: text/plain, Size: 2645 bytes --]

Hi Alexandra,

Since we're going to require a later kernel, I think we should also remove
the line that adds the (currently broken) sysfs_tunable for this feature as
well.

Cheers,
Nanley

On Mon, Sep 29, 2014 at 1:43 PM, Alexandra Yates <
alexandra.yates(a)linux.intel.com> wrote:

>
> > On Fri, Aug 22, 2014 at 9:10 PM, Alexandra Yates <
> > alexandra.yates(a)linux.intel.com> wrote:
> >
> >>
> >> > On Tue, Aug 19, 2014 at 7:49 AM, Sergey Senozhatsky <
> >> > sergey.senozhatsky(a)gmail.com> wrote:
> >> >
> >> >> On (08/13/14 21:28), Nanley Chery wrote:
> >> >> > Starting in kernel 2.6.29, the highest power savings level
> >> increased
> >> >> to
> >> >> "2".
> >> >> > However, in kernel 3.5, the sched power savings feature was removed
> >> >> altogether.
> >> >>
> >> >> hello,
> >> >> thanks for reporting,
> >> >>
> >> >>
> >> >> so, it's been removed 2 years ago (3.5 release date was 21 Jul 2012).
> >> >>
> >> >> do we need to support it at all?
> >> >
> >> >
> >> > Hello,
> >> >
> >> > Good question. Our README file indicates linux-kernel >= 2.6.38 to be
> >> a
> >> > build requirement. Does this mean we support power management features
> >> > starting from that kernel? Or does it mean that this is only a build
> >> > requirement and we target the latest kernels? It is not clear from the
> >> > current documentation.
> >> >
> >> > On a much smaller scope, supporting this feature is essentially free
> >> > (maintenance-wise) and would keep some of our end users on older
> >> kernels
> >> > happy. Btw, I submitted a simpler version 2 of this patch that does
> >> not
> >> > check for the kernel version.
> >> >
> >> > Thanks,
> >> > Nanley
> >> > _______________________________________________
> >> > PowerTop mailing list
> >> > PowerTop(a)lists.01.org
> >> > https://lists.01.org/mailman/listinfo/powertop
> >> >
> >>
> >> From PowerTOP 2.0 and up the requirement is to run at least Linux kernel
> >> 2.6.38. If it is not in the supported kernel then PowerTOP does not need
> >> it.
> >>
> >> Thank you,
> >> Alexandra.
> >>
> >
> > Since we're supporting kernels starting from 2.6.38 (which has this power
> > management feature itself), please consider this patch which produces the
> > correct behavior.
> >
> > Thanks,
> > Nanley
> >
>
> Hi Nanley,
>
> Thank you for your patch.  However, since this feature was faced out the
> kernel over two years ago it doesn't make sense to add it now to PowerTOP.
> I will update the release notes to use a later kernel.  Please excuse the
> confusion.
>
> Thank you,
> Alexandra.
>
>

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 4125 bytes --]

Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 2202 bytes --]


> On Fri, Aug 22, 2014 at 9:10 PM, Alexandra Yates <
> alexandra.yates(a)linux.intel.com> wrote:
>
>>
>> > On Tue, Aug 19, 2014 at 7:49 AM, Sergey Senozhatsky <
>> > sergey.senozhatsky(a)gmail.com> wrote:
>> >
>> >> On (08/13/14 21:28), Nanley Chery wrote:
>> >> > Starting in kernel 2.6.29, the highest power savings level
>> increased
>> >> to
>> >> "2".
>> >> > However, in kernel 3.5, the sched power savings feature was removed
>> >> altogether.
>> >>
>> >> hello,
>> >> thanks for reporting,
>> >>
>> >>
>> >> so, it's been removed 2 years ago (3.5 release date was 21 Jul 2012).
>> >>
>> >> do we need to support it at all?
>> >
>> >
>> > Hello,
>> >
>> > Good question. Our README file indicates linux-kernel >= 2.6.38 to be
>> a
>> > build requirement. Does this mean we support power management features
>> > starting from that kernel? Or does it mean that this is only a build
>> > requirement and we target the latest kernels? It is not clear from the
>> > current documentation.
>> >
>> > On a much smaller scope, supporting this feature is essentially free
>> > (maintenance-wise) and would keep some of our end users on older
>> kernels
>> > happy. Btw, I submitted a simpler version 2 of this patch that does
>> not
>> > check for the kernel version.
>> >
>> > Thanks,
>> > Nanley
>> > _______________________________________________
>> > PowerTop mailing list
>> > PowerTop(a)lists.01.org
>> > https://lists.01.org/mailman/listinfo/powertop
>> >
>>
>> From PowerTOP 2.0 and up the requirement is to run at least Linux kernel
>> 2.6.38. If it is not in the supported kernel then PowerTOP does not need
>> it.
>>
>> Thank you,
>> Alexandra.
>>
>
> Since we're supporting kernels starting from 2.6.38 (which has this power
> management feature itself), please consider this patch which produces the
> correct behavior.
>
> Thanks,
> Nanley
>

Hi Nanley,

Thank you for your patch.  However, since this feature was faced out the
kernel over two years ago it doesn't make sense to add it now to PowerTOP.
I will update the release notes to use a later kernel.  Please excuse the
confusion.

Thank you,
Alexandra.

Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Nanley Chery]

[-- Attachment #1: Type: text/plain, Size: 1835 bytes --]

On Fri, Aug 22, 2014 at 9:10 PM, Alexandra Yates <
alexandra.yates(a)linux.intel.com> wrote:

>
> > On Tue, Aug 19, 2014 at 7:49 AM, Sergey Senozhatsky <
> > sergey.senozhatsky(a)gmail.com> wrote:
> >
> >> On (08/13/14 21:28), Nanley Chery wrote:
> >> > Starting in kernel 2.6.29, the highest power savings level increased
> >> to
> >> "2".
> >> > However, in kernel 3.5, the sched power savings feature was removed
> >> altogether.
> >>
> >> hello,
> >> thanks for reporting,
> >>
> >>
> >> so, it's been removed 2 years ago (3.5 release date was 21 Jul 2012).
> >>
> >> do we need to support it at all?
> >
> >
> > Hello,
> >
> > Good question. Our README file indicates linux-kernel >= 2.6.38 to be a
> > build requirement. Does this mean we support power management features
> > starting from that kernel? Or does it mean that this is only a build
> > requirement and we target the latest kernels? It is not clear from the
> > current documentation.
> >
> > On a much smaller scope, supporting this feature is essentially free
> > (maintenance-wise) and would keep some of our end users on older kernels
> > happy. Btw, I submitted a simpler version 2 of this patch that does not
> > check for the kernel version.
> >
> > Thanks,
> > Nanley
> > _______________________________________________
> > PowerTop mailing list
> > PowerTop(a)lists.01.org
> > https://lists.01.org/mailman/listinfo/powertop
> >
>
> From PowerTOP 2.0 and up the requirement is to run at least Linux kernel
> 2.6.38. If it is not in the supported kernel then PowerTOP does not need
> it.
>
> Thank you,
> Alexandra.
>

Since we're supporting kernels starting from 2.6.38 (which has this power
management feature itself), please consider this patch which produces the
correct behavior.

Thanks,
Nanley

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 2700 bytes --]

Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]


> On Tue, Aug 19, 2014 at 7:49 AM, Sergey Senozhatsky <
> sergey.senozhatsky(a)gmail.com> wrote:
>
>> On (08/13/14 21:28), Nanley Chery wrote:
>> > Starting in kernel 2.6.29, the highest power savings level increased
>> to
>> "2".
>> > However, in kernel 3.5, the sched power savings feature was removed
>> altogether.
>>
>> hello,
>> thanks for reporting,
>>
>>
>> so, it's been removed 2 years ago (3.5 release date was 21 Jul 2012).
>>
>> do we need to support it at all?
>
>
> Hello,
>
> Good question. Our README file indicates linux-kernel >= 2.6.38 to be a
> build requirement. Does this mean we support power management features
> starting from that kernel? Or does it mean that this is only a build
> requirement and we target the latest kernels? It is not clear from the
> current documentation.
>
> On a much smaller scope, supporting this feature is essentially free
> (maintenance-wise) and would keep some of our end users on older kernels
> happy. Btw, I submitted a simpler version 2 of this patch that does not
> check for the kernel version.
>
> Thanks,
> Nanley
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>

>From PowerTOP 2.0 and up the requirement is to run at least Linux kernel
2.6.38. If it is not in the supported kernel then PowerTOP does not need
it.

Thank you,
Alexandra.

Re: [Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Nanley Chery]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

On Tue, Aug 19, 2014 at 7:49 AM, Sergey Senozhatsky <
sergey.senozhatsky(a)gmail.com> wrote:

> On (08/13/14 21:28), Nanley Chery wrote:
> > Starting in kernel 2.6.29, the highest power savings level increased to
> "2".
> > However, in kernel 3.5, the sched power savings feature was removed
> altogether.
>
> hello,
> thanks for reporting,
>
>
> so, it's been removed 2 years ago (3.5 release date was 21 Jul 2012).
>
> do we need to support it at all?


Hello,

Good question. Our README file indicates linux-kernel >= 2.6.38 to be a
build requirement. Does this mean we support power management features
starting from that kernel? Or does it mean that this is only a build
requirement and we target the latest kernels? It is not clear from the
current documentation.

On a much smaller scope, supporting this feature is essentially free
(maintenance-wise) and would keep some of our end users on older kernels
happy. Btw, I submitted a simpler version 2 of this patch that does not
check for the kernel version.

Thanks,
Nanley

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1625 bytes --]

[Powertop] [PATCH 1/1] tunable: update sched_mc_power_savings target value

[Nanley Chery]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

Starting in kernel 2.6.29, the highest power savings level increased to "2".
However, in kernel 3.5, the sched power savings feature was removed altogether.

Signed-off-by: Nanley Chery <nanleychery(a)gmail.com>
---
 src/tuning/tuning.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/tuning/tuning.cpp b/src/tuning/tuning.cpp
index 6367a20..ea1905b 100644
--- a/src/tuning/tuning.cpp
+++ b/src/tuning/tuning.cpp
@@ -28,6 +28,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <ncurses.h>
+#include <linux/version.h>
 
 
 #include "tuning.h"
@@ -58,7 +59,9 @@ static void init_tuning(void)
 {
 	add_sysfs_tunable(_("Enable Audio codec power management"), "/sys/module/snd_hda_intel/parameters/power_save", "1");
 	add_sysfs_tunable(_("NMI watchdog should be turned off"), "/proc/sys/kernel/nmi_watchdog", "0");
-	add_sysfs_tunable(_("Power Aware CPU scheduler"), "/sys/devices/system/cpu/sched_mc_power_savings", "1");
+#if LINUX_VERSION_CODE <= KERNEL_VERSION(3,4,0)
+	add_sysfs_tunable(_("Power Aware CPU scheduler"), "/sys/devices/system/cpu/sched_mc_power_savings", "2");
+#endif
 	add_sysfs_tunable(_("VM writeback timeout"), "/proc/sys/vm/dirty_writeback_centisecs", "1500");
 	add_sata_tunables();
 	add_usb_tunables();
-- 
2.0.4