* [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder
@ 2014-08-19 7:01 YangHaibo
2014-08-19 10:07 ` Martin Jansa
2014-08-19 12:53 ` Paul Eggleton
0 siblings, 2 replies; 6+ messages in thread
From: YangHaibo @ 2014-08-19 7:01 UTC (permalink / raw)
To: openembedded-devel; +Cc: YangHaibo
---
meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb | 0
.../recipes-support/fcgi/{ => files}/Fix_EOF_not_declared_issue.patch | 0
.../fcgi/{ => files}/add_foreign_to_AM_INIT_AUTOMAKE.patch | 0
3 files changed, 0 insertions(+), 0 deletions(-)
rename meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb (100%)
rename meta-webserver/recipes-support/fcgi/{ => files}/Fix_EOF_not_declared_issue.patch (100%)
rename meta-webserver/recipes-support/fcgi/{ => files}/add_foreign_to_AM_INIT_AUTOMAKE.patch (100%)
diff --git a/meta-webserver/recipes-support/fcgi_2.4.0.bb b/meta-webserver/recipes-support/fcgi/fcgi_2.4.0.bb
similarity index 100%
rename from meta-webserver/recipes-support/fcgi_2.4.0.bb
rename to meta-webserver/recipes-support/fcgi/fcgi_2.4.0.bb
diff --git a/meta-webserver/recipes-support/fcgi/Fix_EOF_not_declared_issue.patch b/meta-webserver/recipes-support/fcgi/files/Fix_EOF_not_declared_issue.patch
similarity index 100%
rename from meta-webserver/recipes-support/fcgi/Fix_EOF_not_declared_issue.patch
rename to meta-webserver/recipes-support/fcgi/files/Fix_EOF_not_declared_issue.patch
diff --git a/meta-webserver/recipes-support/fcgi/add_foreign_to_AM_INIT_AUTOMAKE.patch b/meta-webserver/recipes-support/fcgi/files/add_foreign_to_AM_INIT_AUTOMAKE.patch
similarity index 100%
rename from meta-webserver/recipes-support/fcgi/add_foreign_to_AM_INIT_AUTOMAKE.patch
rename to meta-webserver/recipes-support/fcgi/files/add_foreign_to_AM_INIT_AUTOMAKE.patch
--
1.9.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder
2014-08-19 7:01 [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder YangHaibo
@ 2014-08-19 10:07 ` Martin Jansa
2014-08-19 13:40 ` Martin Jansa
2014-08-19 12:53 ` Paul Eggleton
1 sibling, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2014-08-19 10:07 UTC (permalink / raw)
To: openembedded-devel; +Cc: YangHaibo
[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]
On Tue, Aug 19, 2014 at 03:01:49PM +0800, YangHaibo wrote:
> ---
> meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb | 0
> .../recipes-support/fcgi/{ => files}/Fix_EOF_not_declared_issue.patch | 0
> .../fcgi/{ => files}/add_foreign_to_AM_INIT_AUTOMAKE.patch | 0
> 3 files changed, 0 insertions(+), 0 deletions(-)
> rename meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb (100%)
> rename meta-webserver/recipes-support/fcgi/{ => files}/Fix_EOF_not_declared_issue.patch (100%)
> rename meta-webserver/recipes-support/fcgi/{ => files}/add_foreign_to_AM_INIT_AUTOMAKE.patch (100%)
>
> diff --git a/meta-webserver/recipes-support/fcgi_2.4.0.bb b/meta-webserver/recipes-support/fcgi/fcgi_2.4.0.bb
> similarity index 100%
> rename from meta-webserver/recipes-support/fcgi_2.4.0.bb
> rename to meta-webserver/recipes-support/fcgi/fcgi_2.4.0.bb
> diff --git a/meta-webserver/recipes-support/fcgi/Fix_EOF_not_declared_issue.patch b/meta-webserver/recipes-support/fcgi/files/Fix_EOF_not_declared_issue.patch
> similarity index 100%
> rename from meta-webserver/recipes-support/fcgi/Fix_EOF_not_declared_issue.patch
> rename to meta-webserver/recipes-support/fcgi/files/Fix_EOF_not_declared_issue.patch
> diff --git a/meta-webserver/recipes-support/fcgi/add_foreign_to_AM_INIT_AUTOMAKE.patch b/meta-webserver/recipes-support/fcgi/files/add_foreign_to_AM_INIT_AUTOMAKE.patch
> similarity index 100%
> rename from meta-webserver/recipes-support/fcgi/add_foreign_to_AM_INIT_AUTOMAKE.patch
> rename to meta-webserver/recipes-support/fcgi/files/add_foreign_to_AM_INIT_AUTOMAKE.patch
Please use fcgi (BPN) instead of "files" for slightly faster lookup.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder
2014-08-19 7:01 [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder YangHaibo
2014-08-19 10:07 ` Martin Jansa
@ 2014-08-19 12:53 ` Paul Eggleton
2014-08-19 13:47 ` Martin Jansa
1 sibling, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2014-08-19 12:53 UTC (permalink / raw)
To: YangHaibo; +Cc: openembedded-devel
On Tuesday 19 August 2014 15:01:49 YangHaibo wrote:
> ---
> meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb |
FYI, I moved this recipe to recipes-support deliberately. We shouldn't need to
put it in a recipes-fcgi directory unless you expect to be adding a number of
other recipes that would fall into the same category - is that the case?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder
2014-08-19 10:07 ` Martin Jansa
@ 2014-08-19 13:40 ` Martin Jansa
0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2014-08-19 13:40 UTC (permalink / raw)
To: openembedded-devel; +Cc: YangHaibo
[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]
On Tue, Aug 19, 2014 at 12:07:31PM +0200, Martin Jansa wrote:
> On Tue, Aug 19, 2014 at 03:01:49PM +0800, YangHaibo wrote:
> > ---
> > meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb | 0
> > .../recipes-support/fcgi/{ => files}/Fix_EOF_not_declared_issue.patch | 0
> > .../fcgi/{ => files}/add_foreign_to_AM_INIT_AUTOMAKE.patch | 0
> > 3 files changed, 0 insertions(+), 0 deletions(-)
> > rename meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb (100%)
> > rename meta-webserver/recipes-support/fcgi/{ => files}/Fix_EOF_not_declared_issue.patch (100%)
> > rename meta-webserver/recipes-support/fcgi/{ => files}/add_foreign_to_AM_INIT_AUTOMAKE.patch (100%)
> >
> > diff --git a/meta-webserver/recipes-support/fcgi_2.4.0.bb b/meta-webserver/recipes-support/fcgi/fcgi_2.4.0.bb
> > similarity index 100%
> > rename from meta-webserver/recipes-support/fcgi_2.4.0.bb
> > rename to meta-webserver/recipes-support/fcgi/fcgi_2.4.0.bb
> > diff --git a/meta-webserver/recipes-support/fcgi/Fix_EOF_not_declared_issue.patch b/meta-webserver/recipes-support/fcgi/files/Fix_EOF_not_declared_issue.patch
> > similarity index 100%
> > rename from meta-webserver/recipes-support/fcgi/Fix_EOF_not_declared_issue.patch
> > rename to meta-webserver/recipes-support/fcgi/files/Fix_EOF_not_declared_issue.patch
> > diff --git a/meta-webserver/recipes-support/fcgi/add_foreign_to_AM_INIT_AUTOMAKE.patch b/meta-webserver/recipes-support/fcgi/files/add_foreign_to_AM_INIT_AUTOMAKE.patch
> > similarity index 100%
> > rename from meta-webserver/recipes-support/fcgi/add_foreign_to_AM_INIT_AUTOMAKE.patch
> > rename to meta-webserver/recipes-support/fcgi/files/add_foreign_to_AM_INIT_AUTOMAKE.patch
>
> Please use fcgi (BPN) instead of "files" for slightly faster lookup.
I've moved them when cherry-picking to master-next, but it's also
missing your SOB line, I've added it too, but please ack it here.
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder
2014-08-19 12:53 ` Paul Eggleton
@ 2014-08-19 13:47 ` Martin Jansa
2014-08-19 14:29 ` Paul Eggleton
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2014-08-19 13:47 UTC (permalink / raw)
To: openembedded-devel; +Cc: YangHaibo
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Tue, Aug 19, 2014 at 01:53:28PM +0100, Paul Eggleton wrote:
> On Tuesday 19 August 2014 15:01:49 YangHaibo wrote:
> > ---
> > meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb |
>
> FYI, I moved this recipe to recipes-support deliberately. We shouldn't need to
> put it in a recipes-fcgi directory unless you expect to be adding a number of
> other recipes that would fall into the same category - is that the case?
It seems that you've removed one directory level, when moving it, so it wasn't included
in BBFILES mask
BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"
So this patch is needed and queued in master-next.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder
2014-08-19 13:47 ` Martin Jansa
@ 2014-08-19 14:29 ` Paul Eggleton
0 siblings, 0 replies; 6+ messages in thread
From: Paul Eggleton @ 2014-08-19 14:29 UTC (permalink / raw)
To: Martin Jansa; +Cc: YangHaibo, openembedded-devel
On Tuesday 19 August 2014 15:47:52 Martin Jansa wrote:
> On Tue, Aug 19, 2014 at 01:53:28PM +0100, Paul Eggleton wrote:
> > On Tuesday 19 August 2014 15:01:49 YangHaibo wrote:
> > > ---
> > >
> > > meta-webserver/recipes-support/{ => fcgi}/fcgi_2.4.0.bb
> > > |
> >
> > FYI, I moved this recipe to recipes-support deliberately. We shouldn't
> > need to put it in a recipes-fcgi directory unless you expect to be adding
> > a number of other recipes that would fall into the same category - is
> > that the case?
> It seems that you've removed one directory level, when moving it, so it
> wasn't included in BBFILES mask
>
> BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"
>
> So this patch is needed and queued in master-next.
Oh, whoops - sorry about that. Finger trouble obviously ;)
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-19 14:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-19 7:01 [meta-oe][meta-webserver][PATCH] move fcgi-2.4.0 recipe and patch to correct folder YangHaibo
2014-08-19 10:07 ` Martin Jansa
2014-08-19 13:40 ` Martin Jansa
2014-08-19 12:53 ` Paul Eggleton
2014-08-19 13:47 ` Martin Jansa
2014-08-19 14:29 ` Paul Eggleton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.