From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: atull@opensource.altera.com, jdelvare@suse.de,
lm-sensors@lm-sensors.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, delicious.quinoa@gmail.com,
dinguyen@opensource.altera.com, yvanderv@opensource.altera.com
Subject: Re: [lm-sensors] [PATCH 2/2] pmbus: ltc2978: add regulator gating
Date: Fri, 22 Aug 2014 02:30:38 +0000 [thread overview]
Message-ID: <20140822023038.GA17819@roeck-us.net> (raw)
In-Reply-To: <20140822012622.GS24407@sirena.org.uk>
On Thu, Aug 21, 2014 at 08:26:22PM -0500, Mark Brown wrote:
> On Thu, Aug 21, 2014 at 06:18:10PM -0700, Guenter Roeck wrote:
> > On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote:
> > > On Thu, Aug 21, 2014 at 05:21:26PM -0500, atull@opensource.altera.com wrote:
>
> > > This all looks very much like pmbus could use regmap and then the regmap
> > > helpers. I'd not insist on it though. What I would however suggest is
>
> > Not unless regmap got extended recently to support quick, byte, and word
> > smbus accesses at the same time.
>
> Depending on how you decide which it quite possibly does - if it's based
> on the register number that'd work.
Mostly per register, but also per chip (for manufacturing specific registers
the register size is determined by the chip type). Also, there are block
registers. Plus, the scope of each register (ie if it is paged or not)
is chip specific. The same register may be paged on one chip, and unpaged
on another. I'll have another look to see if that all can be mapped into the
regmap model. If yes, it might actually be quite helpful and might simplify
the pmbus code quite a bit.
Either case, even if regmap now supports all the PMBus oddities, converting
the pmbus drivers to use regmap should be a separate patch set and not be
tied together.
Tnanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: atull@opensource.altera.com, jdelvare@suse.de,
lm-sensors@lm-sensors.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, delicious.quinoa@gmail.com,
dinguyen@opensource.altera.com, yvanderv@opensource.altera.com
Subject: Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating
Date: Thu, 21 Aug 2014 19:30:38 -0700 [thread overview]
Message-ID: <20140822023038.GA17819@roeck-us.net> (raw)
In-Reply-To: <20140822012622.GS24407@sirena.org.uk>
On Thu, Aug 21, 2014 at 08:26:22PM -0500, Mark Brown wrote:
> On Thu, Aug 21, 2014 at 06:18:10PM -0700, Guenter Roeck wrote:
> > On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote:
> > > On Thu, Aug 21, 2014 at 05:21:26PM -0500, atull@opensource.altera.com wrote:
>
> > > This all looks very much like pmbus could use regmap and then the regmap
> > > helpers. I'd not insist on it though. What I would however suggest is
>
> > Not unless regmap got extended recently to support quick, byte, and word
> > smbus accesses at the same time.
>
> Depending on how you decide which it quite possibly does - if it's based
> on the register number that'd work.
Mostly per register, but also per chip (for manufacturing specific registers
the register size is determined by the chip type). Also, there are block
registers. Plus, the scope of each register (ie if it is paged or not)
is chip specific. The same register may be paged on one chip, and unpaged
on another. I'll have another look to see if that all can be mapped into the
regmap model. If yes, it might actually be quite helpful and might simplify
the pmbus code quite a bit.
Either case, even if regmap now supports all the PMBus oddities, converting
the pmbus drivers to use regmap should be a separate patch set and not be
tied together.
Tnanks,
Guenter
next prev parent reply other threads:[~2014-08-22 2:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 22:21 [lm-sensors] [PATCH 0/2] add regulator support for pmbus and ltc2978 atull
2014-08-21 22:21 ` atull
2014-08-21 22:21 ` [lm-sensors] [PATCH 1/2] pmbus: add regulator support atull
2014-08-21 22:21 ` atull
2014-08-21 22:21 ` [lm-sensors] [PATCH 2/2] pmbus: ltc2978: add regulator gating atull
2014-08-21 22:21 ` atull
2014-08-22 0:36 ` [lm-sensors] " Mark Brown
2014-08-22 0:36 ` Mark Brown
2014-08-22 1:18 ` [lm-sensors] " Guenter Roeck
2014-08-22 1:18 ` Guenter Roeck
2014-08-22 1:26 ` [lm-sensors] " Mark Brown
2014-08-22 1:26 ` Mark Brown
2014-08-22 2:30 ` Guenter Roeck [this message]
2014-08-22 2:30 ` Guenter Roeck
2014-08-22 15:30 ` [lm-sensors] " atull
2014-08-22 15:30 ` atull
2014-08-22 21:14 ` [lm-sensors] [PATCH 0/2] add regulator support for pmbus and ltc2978 atull
2014-08-22 21:14 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822023038.GA17819@roeck-us.net \
--to=linux@roeck-us.net \
--cc=atull@opensource.altera.com \
--cc=broonie@kernel.org \
--cc=delicious.quinoa@gmail.com \
--cc=dinguyen@opensource.altera.com \
--cc=jdelvare@suse.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.