From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Peter Feiner <pfeiner@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Pavel Emelyanov <xemul@parallels.com>,
Jamie Liu <jamieliu@google.com>, Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared
Date: Sun, 24 Aug 2014 23:22:51 +0400 [thread overview]
Message-ID: <20140824192251.GL25918@moon> (raw)
In-Reply-To: <20140824075924.GA27392@node.dhcp.inet.fi>
On Sun, Aug 24, 2014 at 10:59:24AM +0300, Kirill A. Shutemov wrote:
...
> > diff --git a/mm/mmap.c b/mm/mmap.c
> > index c1f2ea4..1b61fbc 100644
> > --- a/mm/mmap.c
> > +++ b/mm/mmap.c
> > @@ -1470,6 +1470,10 @@ int vma_wants_writenotify(struct vm_area_struct *vma)
> > if (vma->vm_ops && vma->vm_ops->page_mkwrite)
> > return 1;
> >
> > + /* Do we need to track softdirty? */
> > + if (!(vm_flags & VM_SOFTDIRTY))
>
> This will give false-positive if CONFIG_MEM_SOFT_DIRTY is disabled, since
> VM_SOFTDIRTY is 0 in this case:
>
> if (IS_ENABLED(CONFIG_MEM_SOFT_DIRTY) && !(vm_flags & VM_SOFTDIRTY))
>
> Otherwise looks good to me.
>
> Suggested-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Really sorry for delay. Thanks a huge, guys!
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Peter Feiner <pfeiner@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Pavel Emelyanov <xemul@parallels.com>,
Jamie Liu <jamieliu@google.com>, Hugh Dickins <hughd@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared
Date: Sun, 24 Aug 2014 23:22:51 +0400 [thread overview]
Message-ID: <20140824192251.GL25918@moon> (raw)
In-Reply-To: <20140824075924.GA27392@node.dhcp.inet.fi>
On Sun, Aug 24, 2014 at 10:59:24AM +0300, Kirill A. Shutemov wrote:
...
> > diff --git a/mm/mmap.c b/mm/mmap.c
> > index c1f2ea4..1b61fbc 100644
> > --- a/mm/mmap.c
> > +++ b/mm/mmap.c
> > @@ -1470,6 +1470,10 @@ int vma_wants_writenotify(struct vm_area_struct *vma)
> > if (vma->vm_ops && vma->vm_ops->page_mkwrite)
> > return 1;
> >
> > + /* Do we need to track softdirty? */
> > + if (!(vm_flags & VM_SOFTDIRTY))
>
> This will give false-positive if CONFIG_MEM_SOFT_DIRTY is disabled, since
> VM_SOFTDIRTY is 0 in this case:
>
> if (IS_ENABLED(CONFIG_MEM_SOFT_DIRTY) && !(vm_flags & VM_SOFTDIRTY))
>
> Otherwise looks good to me.
>
> Suggested-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Really sorry for delay. Thanks a huge, guys!
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
next prev parent reply other threads:[~2014-08-24 19:22 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 21:46 [PATCH] mm: softdirty: write protect PTEs created for read faults after VM_SOFTDIRTY cleared Peter Feiner
2014-08-20 21:46 ` Peter Feiner
2014-08-20 23:45 ` Kirill A. Shutemov
2014-08-20 23:45 ` Kirill A. Shutemov
2014-08-21 19:37 ` Peter Feiner
2014-08-21 19:37 ` Peter Feiner
2014-08-21 20:51 ` Cyrill Gorcunov
2014-08-21 20:51 ` Cyrill Gorcunov
2014-08-21 21:39 ` Kirill A. Shutemov
2014-08-21 21:39 ` Kirill A. Shutemov
2014-08-21 21:46 ` Peter Feiner
2014-08-21 21:46 ` Peter Feiner
2014-08-21 21:51 ` Kirill A. Shutemov
2014-08-21 21:51 ` Kirill A. Shutemov
2014-08-21 22:50 ` Peter Feiner
2014-08-21 22:50 ` Peter Feiner
2014-08-22 6:33 ` Cyrill Gorcunov
2014-08-22 6:33 ` Cyrill Gorcunov
2014-08-23 22:11 ` [PATCH v2 0/3] softdirty fix and write notification cleanup Peter Feiner
2014-08-23 22:11 ` Peter Feiner
2014-08-23 22:11 ` [PATCH v2 1/3] mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared Peter Feiner
2014-08-23 22:11 ` Peter Feiner
2014-08-23 23:00 ` Kirill A. Shutemov
2014-08-23 23:00 ` Kirill A. Shutemov
2014-08-23 23:15 ` Peter Feiner
2014-08-23 23:15 ` Peter Feiner
2014-08-23 23:50 ` Kirill A. Shutemov
2014-08-23 23:50 ` Kirill A. Shutemov
2014-08-24 0:55 ` Peter Feiner
2014-08-24 0:55 ` Peter Feiner
2014-08-23 22:12 ` [PATCH v2 2/3] mm: mprotect: preserve special page protection bits Peter Feiner
2014-08-23 22:12 ` Peter Feiner
2014-08-23 22:12 ` [PATCH v2 3/3] mm: mmap: cleanup code that preserves special vm_page_prot bits Peter Feiner
2014-08-23 22:12 ` Peter Feiner
2014-08-24 1:43 ` [PATCH v3] mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared Peter Feiner
2014-08-24 1:43 ` Peter Feiner
2014-08-24 7:59 ` Kirill A. Shutemov
2014-08-24 7:59 ` Kirill A. Shutemov
2014-08-24 19:22 ` Cyrill Gorcunov [this message]
2014-08-24 19:22 ` Cyrill Gorcunov
2014-08-24 14:41 ` [PATCH v4] " Peter Feiner
2014-08-24 14:41 ` Peter Feiner
2014-08-25 3:34 ` [PATCH v5] " Peter Feiner
2014-08-25 3:34 ` Peter Feiner
2014-08-26 4:45 ` Hugh Dickins
2014-08-26 4:45 ` Hugh Dickins
2014-08-26 6:49 ` Cyrill Gorcunov
2014-08-26 6:49 ` Cyrill Gorcunov
2014-08-26 14:04 ` Kirill A. Shutemov
2014-08-26 14:04 ` Kirill A. Shutemov
2014-08-26 14:19 ` Cyrill Gorcunov
2014-08-26 14:19 ` Cyrill Gorcunov
2014-08-26 14:56 ` Kirill A. Shutemov
2014-08-26 14:56 ` Kirill A. Shutemov
2014-08-26 15:18 ` Cyrill Gorcunov
2014-08-26 15:18 ` Cyrill Gorcunov
2014-08-26 15:43 ` Kirill A. Shutemov
2014-08-26 15:43 ` Kirill A. Shutemov
2014-08-26 15:53 ` Cyrill Gorcunov
2014-08-26 15:53 ` Cyrill Gorcunov
2014-08-27 23:12 ` Hugh Dickins
2014-08-27 23:12 ` Hugh Dickins
2014-08-28 6:31 ` Cyrill Gorcunov
2014-08-28 6:31 ` Cyrill Gorcunov
2014-08-27 21:55 ` Hugh Dickins
2014-08-27 21:55 ` Hugh Dickins
2014-09-04 16:43 ` Peter Feiner
2014-09-04 16:43 ` Peter Feiner
2014-09-07 21:31 ` Peter Feiner
2014-09-07 21:31 ` Peter Feiner
2014-09-07 23:01 ` [PATCH v6] " Peter Feiner
2014-09-07 23:01 ` Peter Feiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140824192251.GL25918@moon \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jamieliu@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pfeiner@google.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.