All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: "Mike Turquette" <mturquette@linaro.org>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Emilio Lopez" <emilio@elopez.com.ar>,
	"Chris Ball" <chris@printf.net>,
	"David Lanzendörfer" <david.lanzendoerfer@o2s.ch>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	devicetree <devicetree@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 07/14] clk: sunxi: Introduce mbus compatible
Date: Mon, 25 Aug 2014 17:18:47 +0200	[thread overview]
Message-ID: <20140825151847.GD15297@lukather> (raw)
In-Reply-To: <CAGb2v64xzwySFcnhAAmPFvUOWGechLZpoxfmb0OmEGOZbV+58Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]

On Mon, Aug 25, 2014 at 10:17:37PM +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> On Thu, Jul 17, 2014 at 5:08 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Even though the mbus clock is a regular module clock, given its nature, it
> > needs to be enabled all the time.
> >
> > Introduce a new compatible, to differentiate it from the other module clocks.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  Documentation/devicetree/bindings/clock/sunxi.txt | 1 +
> >  drivers/clk/sunxi/clk-sunxi.c                     | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt
> > index d3a5c3c6d677..112d8525b6e0 100644
> > --- a/Documentation/devicetree/bindings/clock/sunxi.txt
> > +++ b/Documentation/devicetree/bindings/clock/sunxi.txt
> > @@ -46,6 +46,7 @@ Required properties:
> >         "allwinner,sun6i-a31-apb2-div-clk" - for the APB2 gates on A31
> >         "allwinner,sun6i-a31-apb2-gates-clk" - for the APB2 gates on A31
> >         "allwinner,sun8i-a23-apb2-gates-clk" - for the APB2 gates on A23
> > +       "allwinner,sun4i-a10-mbus-clk" - for the MBUS clock on A10
> 
> This should probably be sun5i-a13-mbus-clk?
> AFAIK the A10 doesn't have MBUS.

Ah, right, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/14] clk: sunxi: Introduce mbus compatible
Date: Mon, 25 Aug 2014 17:18:47 +0200	[thread overview]
Message-ID: <20140825151847.GD15297@lukather> (raw)
In-Reply-To: <CAGb2v64xzwySFcnhAAmPFvUOWGechLZpoxfmb0OmEGOZbV+58Q@mail.gmail.com>

On Mon, Aug 25, 2014 at 10:17:37PM +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> On Thu, Jul 17, 2014 at 5:08 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Even though the mbus clock is a regular module clock, given its nature, it
> > needs to be enabled all the time.
> >
> > Introduce a new compatible, to differentiate it from the other module clocks.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  Documentation/devicetree/bindings/clock/sunxi.txt | 1 +
> >  drivers/clk/sunxi/clk-sunxi.c                     | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt
> > index d3a5c3c6d677..112d8525b6e0 100644
> > --- a/Documentation/devicetree/bindings/clock/sunxi.txt
> > +++ b/Documentation/devicetree/bindings/clock/sunxi.txt
> > @@ -46,6 +46,7 @@ Required properties:
> >         "allwinner,sun6i-a31-apb2-div-clk" - for the APB2 gates on A31
> >         "allwinner,sun6i-a31-apb2-gates-clk" - for the APB2 gates on A31
> >         "allwinner,sun8i-a23-apb2-gates-clk" - for the APB2 gates on A23
> > +       "allwinner,sun4i-a10-mbus-clk" - for the MBUS clock on A10
> 
> This should probably be sun5i-a13-mbus-clk?
> AFAIK the A10 doesn't have MBUS.

Ah, right, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140825/f24c7562/attachment.sig>

  reply	other threads:[~2014-08-25 15:20 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17  9:08 [PATCH 00/14] clk: sunxi: Improve MMC clocks support Maxime Ripard
2014-07-17  9:08 ` Maxime Ripard
2014-07-17  9:08 ` [PATCH 01/14] clk: Introduce new frequency boundaries properties Maxime Ripard
2014-07-17  9:08   ` Maxime Ripard
2014-07-17  9:08 ` [PATCH 02/14] clk: sunxi: factors: Implement clock min and max frequencies Maxime Ripard
2014-07-17  9:08   ` Maxime Ripard
2014-07-17 16:09   ` Emilio López
2014-07-17 16:09     ` Emilio López
     [not found] ` <1405588134-2396-1-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-07-17  9:08   ` [PATCH 03/14] ARM: sunxi: sun5i: Enforce max frequency on PLL6 Maxime Ripard
2014-07-17  9:08     ` Maxime Ripard
2014-07-17 16:19     ` Emilio López
2014-07-17 16:19       ` Emilio López
2014-07-17  9:08   ` [PATCH 06/14] clk: sunxi: factors: Invert the probing logic Maxime Ripard
2014-07-17  9:08     ` Maxime Ripard
2014-07-17  9:08   ` [PATCH 07/14] clk: sunxi: Introduce mbus compatible Maxime Ripard
2014-07-17  9:08     ` Maxime Ripard
2014-08-25 14:17     ` Chen-Yu Tsai
2014-08-25 14:17       ` Chen-Yu Tsai
2014-08-25 15:18       ` Maxime Ripard [this message]
2014-08-25 15:18         ` Maxime Ripard
2014-07-17  9:08   ` [PATCH 10/14] clk: sunxi: Move mbus to mod0 file Maxime Ripard
2014-07-17  9:08     ` Maxime Ripard
2014-07-17  9:08   ` [PATCH 11/14] ARM: sunxi: dt: Add sample and output mmc clocks Maxime Ripard
2014-07-17  9:08     ` Maxime Ripard
2014-07-17  9:08   ` [PATCH 14/14] clk: sunxi: Remove custom phase function Maxime Ripard
2014-07-17  9:08     ` Maxime Ripard
2014-07-17  9:08 ` [PATCH 04/14] clk: introduce clk_set_phase function & callback Maxime Ripard
2014-07-17  9:08   ` Maxime Ripard
2014-07-17  9:08 ` [PATCH 05/14] clk: Add a function to retrieve phase Maxime Ripard
2014-07-17  9:08   ` Maxime Ripard
2014-07-17  9:08 ` [PATCH 08/14] ARM: sunxi: dt: Switch to the new mbus compatible Maxime Ripard
2014-07-17  9:08   ` Maxime Ripard
2014-07-17  9:08 ` [PATCH 09/14] clk: sunxi: Move mod0 clock to a file of its own Maxime Ripard
2014-07-17  9:08   ` Maxime Ripard
2014-07-17  9:08 ` [PATCH 12/14] clk: sunxi: mod0: Introduce MMC proper phase handling Maxime Ripard
2014-07-17  9:08   ` Maxime Ripard
2014-07-17  9:08 ` [PATCH 13/14] mmc: sunxi: Convert MMC driver to the standard clock phase API Maxime Ripard
2014-07-17  9:08   ` Maxime Ripard
2014-08-13  8:44   ` Ulf Hansson
2014-08-13  8:44     ` Ulf Hansson
2014-07-19 10:47 ` [PATCH 00/14] clk: sunxi: Improve MMC clocks support Hans de Goede
2014-07-19 10:47   ` Hans de Goede
2014-07-24 11:20   ` Maxime Ripard
2014-07-24 11:20     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825151847.GD15297@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=chris@printf.net \
    --cc=david.lanzendoerfer@o2s.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=emilio@elopez.com.ar \
    --cc=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.