All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
To: Ouyang Changchun
	<changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: [RFC 03/10] virtio: allow starting with link down
Date: Mon, 25 Aug 2014 19:07:49 -0700	[thread overview]
Message-ID: <20140826020841.926122925@networkplumber.org> (raw)
In-Reply-To: 20140826020746.062748014@networkplumber.org

[-- Attachment #1: virtio-link-down-ok.patch --]
[-- Type: text/plain, Size: 953 bytes --]

Starting driver with link down should be ok, it is with every
other driver. So just allow it.

Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>

---
 lib/librte_pmd_virtio/virtio_ethdev.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/lib/librte_pmd_virtio/virtio_ethdev.c	2014-08-25 19:00:05.498525861 -0700
+++ b/lib/librte_pmd_virtio/virtio_ethdev.c	2014-08-25 19:00:05.494525839 -0700
@@ -969,14 +969,12 @@ virtio_dev_start(struct rte_eth_dev *dev
 		vtpci_read_dev_config(hw,
 				offsetof(struct virtio_net_config, status),
 				&status, sizeof(status));
-		if ((status & VIRTIO_NET_S_LINK_UP) == 0) {
+		if ((status & VIRTIO_NET_S_LINK_UP) == 0)
 			PMD_INIT_LOG(ERR, "Port: %d Link is DOWN",
 				     dev->data->port_id);
-			return -EIO;
-		} else {
+		else
 			PMD_INIT_LOG(DEBUG, "Port: %d Link is UP",
 				     dev->data->port_id);
-		}
 	}
 	vtpci_reinit_complete(hw);
 

  parent reply	other threads:[~2014-08-26  2:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  2:07 [RFC 00/10] virtio patches Stephen Hemminger
2014-08-26  2:07 ` [RFC 01/10] virtio: rearrange resource initialization Stephen Hemminger
     [not found]   ` <20140826020837.898427212-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-08-26  7:14     ` Ouyang, Changchun
2014-08-26  2:07 ` [RFC 02/10] virtio: use weak barriers Stephen Hemminger
2014-08-26  2:07 ` Stephen Hemminger [this message]
2014-08-26  2:07 ` [RFC 04/10] virtio: add support for Link State interrupt Stephen Hemminger
2014-08-26  2:07 ` [RFC 05/10] ether: add soft vlan encap/decap functions Stephen Hemminger
2014-08-26  2:07 ` [RFC 06/10] virtio: use software vlan stripping Stephen Hemminger
     [not found]   ` <20140826020848.386074683-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-08-26  8:37     ` Ouyang, Changchun
     [not found]       ` <F52918179C57134FAEC9EA62FA2F96251183B285-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-26 16:24         ` Stephen Hemminger
2014-08-27  5:42           ` Ouyang, Changchun
     [not found]             ` <F52918179C57134FAEC9EA62FA2F96251183B79C-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-27 18:04               ` Stephen Hemminger
2014-08-26  2:07 ` [RFC 07/10] virtio: remove unnecessary adapter structure Stephen Hemminger
     [not found]   ` <20140826020851.474452281-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-08-26  6:43     ` Ouyang, Changchun
2014-08-26  2:07 ` [RFC 08/10] virtio: remove redundant vq_alignment Stephen Hemminger
     [not found]   ` <20140826020853.851222673-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-08-26  8:41     ` Ouyang, Changchun
2014-08-26  2:07 ` [RFC 09/10] virtio: fix how states are handled during initialization Stephen Hemminger
2014-08-26  2:07 ` [RFC 10/10] virtio: add support for promiscious and multicast Stephen Hemminger
     [not found]   ` <20140826020858.448904783-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-08-26  6:55     ` Ouyang, Changchun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140826020841.926122925@networkplumber.org \
    --to=stephen-otpzqlsittunbdjkjebofr2eb7je58tq@public.gmane.org \
    --cc=changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.