All of lore.kernel.org
 help / color / mirror / Atom feed
* re: drm: sti: add HDMI driver
@ 2014-08-29  8:15 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-08-29  8:15 UTC (permalink / raw)
  To: benjamin.gaignard; +Cc: dri-devel

Hello Benjamin Gaignard,

The patch 5402626c83a2: "drm: sti: add HDMI driver" from Jul 30,
2014, leads to the following static checker warning:

	drivers/gpu/drm/sti/sti_hdmi.c:301 hdmi_avi_infoframe_config()
	error: buffer overflow 'frame' 13 <= 13

drivers/gpu/drm/sti/sti_hdmi.c
   298          hdmi_write(hdmi, val, HDMI_SW_DI_N_PKT_WORD2(HDMI_IFRAME_SLOT_AVI));
   299  
   300          val = frame[0xC];
   301          val |= frame[0xD] << 8;

frame[] only has 0xD elements so we are one element past the end here.

   302          hdmi_write(hdmi, val, HDMI_SW_DI_N_PKT_WORD3(HDMI_IFRAME_SLOT_AVI));
   303  

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-08-29  8:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-29  8:15 drm: sti: add HDMI driver Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.