All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	Dave Chinner <david@fromorbit.com>,
	Nikolai Grigoriev <ngrigoriev@gmail.com>,
	linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mm@kvack.org,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: ext4 vs btrfs performance on SSD array
Date: Fri, 5 Sep 2014 09:08:08 -0700	[thread overview]
Message-ID: <20140905160808.GA7967@infradead.org> (raw)
In-Reply-To: <20140903100158.34916d34@notabene.brown>

On Wed, Sep 03, 2014 at 10:01:58AM +1000, NeilBrown wrote:
> Do we still need maximums at all?

I don't think we do.  At least on any system I work with I have to
increase them to get good performance without any adverse effect on
throttling.

> So can we just remove the limit on max_sectors and the RAID5 stripe cache
> size?  I'm certainly keen to remove the later and just use a mempool if the
> limit isn't needed.
> I have seen reports that a very large raid5 stripe cache size can cause
> a reduction in performance.  I don't know why but I suspect it is a bug that
> should be found and fixed.
> 
> Do we need max_sectors ??

I'll send a patch to remove it and watch for the fireworks..

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	Dave Chinner <david@fromorbit.com>,
	Nikolai Grigoriev <ngrigoriev@gmail.com>,
	linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-mm@kvack.org,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: ext4 vs btrfs performance on SSD array
Date: Fri, 5 Sep 2014 09:08:08 -0700	[thread overview]
Message-ID: <20140905160808.GA7967@infradead.org> (raw)
In-Reply-To: <20140903100158.34916d34@notabene.brown>

On Wed, Sep 03, 2014 at 10:01:58AM +1000, NeilBrown wrote:
> Do we still need maximums at all?

I don't think we do.  At least on any system I work with I have to
increase them to get good performance without any adverse effect on
throttling.

> So can we just remove the limit on max_sectors and the RAID5 stripe cache
> size?  I'm certainly keen to remove the later and just use a mempool if the
> limit isn't needed.
> I have seen reports that a very large raid5 stripe cache size can cause
> a reduction in performance.  I don't know why but I suspect it is a bug that
> should be found and fixed.
> 
> Do we need max_sectors ??

I'll send a patch to remove it and watch for the fireworks..

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-09-05 16:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 23:39 ext4 vs btrfs performance on SSD array Nikolai Grigoriev
2014-08-27  7:10 ` Duncan
2014-08-27 21:59   ` Nikolai Grigoriev
2014-09-02  0:08 ` Dave Chinner
2014-09-02  1:22   ` Christoph Hellwig
2014-09-02  1:22     ` Christoph Hellwig
2014-09-02 10:39     ` Zack Coffey
2014-09-02 11:31     ` Theodore Ts'o
2014-09-02 11:31       ` Theodore Ts'o
2014-09-02 14:20       ` Jan Kara
2014-09-02 14:20         ` Jan Kara
2014-09-02 14:55         ` Theodore Ts'o
2014-09-02 14:55           ` Theodore Ts'o
2014-09-02 12:55     ` Zack Coffey
2014-09-02 12:55       ` Zack Coffey
2014-09-02 13:40       ` Austin S Hemmelgarn
2014-09-03  0:01     ` NeilBrown
2014-09-05 16:08       ` Christoph Hellwig [this message]
2014-09-05 16:08         ` Christoph Hellwig
2014-09-05 16:40         ` Jeff Moyer
2014-09-05 16:40           ` Jeff Moyer
2014-09-05 16:50           ` Jens Axboe
2014-09-05 16:50             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140905160808.GA7967@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=david@fromorbit.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=ngrigoriev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.