From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>, Christoph Hellwig <hch@infradead.org>
Cc: NeilBrown <neilb@suse.de>, Dave Chinner <david@fromorbit.com>,
Nikolai Grigoriev <ngrigoriev@gmail.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-mm@kvack.org
Subject: Re: ext4 vs btrfs performance on SSD array
Date: Fri, 05 Sep 2014 10:50:06 -0600 [thread overview]
Message-ID: <5409E9BE.2040002@kernel.dk> (raw)
In-Reply-To: <x497g1ivx4e.fsf@segfault.boston.devel.redhat.com>
On 09/05/2014 10:40 AM, Jeff Moyer wrote:
> Christoph Hellwig <hch@infradead.org> writes:
>
>> On Wed, Sep 03, 2014 at 10:01:58AM +1000, NeilBrown wrote:
>>> Do we still need maximums at all?
>>
>> I don't think we do. At least on any system I work with I have to
>> increase them to get good performance without any adverse effect on
>> throttling.
>>
>>> So can we just remove the limit on max_sectors and the RAID5 stripe cache
>>> size? I'm certainly keen to remove the later and just use a mempool if the
>>> limit isn't needed.
>>> I have seen reports that a very large raid5 stripe cache size can cause
>>> a reduction in performance. I don't know why but I suspect it is a bug that
>>> should be found and fixed.
>>>
>>> Do we need max_sectors ??
>
> I'm assuming we're talking about max_sectors_kb in
> /sys/block/sdX/queue/.
>
>> I'll send a patch to remove it and watch for the fireworks..
>
> :) I've seen SSDs that actually degrade in performance if I/O sizes
> exceed their internal page size (using artificial benchmarks; I never
> confirmed that with actual workloads). Bumping the default might not be
> bad, but getting rid of the tunable would be a step backwards, in my
> opinion.
>
> Are you going to bump up BIO_MAX_PAGES while you're at it?
The reason it's 256 right (or since forever, actually) is that this is
one single 4kb page. If you go higher, that would require a higher order
allocation. Not impossible, but it's definitely a potential issue. It's
a lot saner to string bios at that point, with separate 0 order allocs.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>, Christoph Hellwig <hch@infradead.org>
Cc: NeilBrown <neilb@suse.de>, Dave Chinner <david@fromorbit.com>,
Nikolai Grigoriev <ngrigoriev@gmail.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-mm@kvack.org
Subject: Re: ext4 vs btrfs performance on SSD array
Date: Fri, 05 Sep 2014 10:50:06 -0600 [thread overview]
Message-ID: <5409E9BE.2040002@kernel.dk> (raw)
In-Reply-To: <x497g1ivx4e.fsf@segfault.boston.devel.redhat.com>
On 09/05/2014 10:40 AM, Jeff Moyer wrote:
> Christoph Hellwig <hch@infradead.org> writes:
>
>> On Wed, Sep 03, 2014 at 10:01:58AM +1000, NeilBrown wrote:
>>> Do we still need maximums at all?
>>
>> I don't think we do. At least on any system I work with I have to
>> increase them to get good performance without any adverse effect on
>> throttling.
>>
>>> So can we just remove the limit on max_sectors and the RAID5 stripe cache
>>> size? I'm certainly keen to remove the later and just use a mempool if the
>>> limit isn't needed.
>>> I have seen reports that a very large raid5 stripe cache size can cause
>>> a reduction in performance. I don't know why but I suspect it is a bug that
>>> should be found and fixed.
>>>
>>> Do we need max_sectors ??
>
> I'm assuming we're talking about max_sectors_kb in
> /sys/block/sdX/queue/.
>
>> I'll send a patch to remove it and watch for the fireworks..
>
> :) I've seen SSDs that actually degrade in performance if I/O sizes
> exceed their internal page size (using artificial benchmarks; I never
> confirmed that with actual workloads). Bumping the default might not be
> bad, but getting rid of the tunable would be a step backwards, in my
> opinion.
>
> Are you going to bump up BIO_MAX_PAGES while you're at it?
The reason it's 256 right (or since forever, actually) is that this is
one single 4kb page. If you go higher, that would require a higher order
allocation. Not impossible, but it's definitely a potential issue. It's
a lot saner to string bios at that point, with separate 0 order allocs.
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-05 16:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 23:39 ext4 vs btrfs performance on SSD array Nikolai Grigoriev
2014-08-27 7:10 ` Duncan
2014-08-27 21:59 ` Nikolai Grigoriev
2014-09-02 0:08 ` Dave Chinner
2014-09-02 1:22 ` Christoph Hellwig
2014-09-02 1:22 ` Christoph Hellwig
2014-09-02 10:39 ` Zack Coffey
2014-09-02 11:31 ` Theodore Ts'o
2014-09-02 11:31 ` Theodore Ts'o
2014-09-02 14:20 ` Jan Kara
2014-09-02 14:20 ` Jan Kara
2014-09-02 14:55 ` Theodore Ts'o
2014-09-02 14:55 ` Theodore Ts'o
2014-09-02 12:55 ` Zack Coffey
2014-09-02 12:55 ` Zack Coffey
2014-09-02 13:40 ` Austin S Hemmelgarn
2014-09-03 0:01 ` NeilBrown
2014-09-05 16:08 ` Christoph Hellwig
2014-09-05 16:08 ` Christoph Hellwig
2014-09-05 16:40 ` Jeff Moyer
2014-09-05 16:40 ` Jeff Moyer
2014-09-05 16:50 ` Jens Axboe [this message]
2014-09-05 16:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5409E9BE.2040002@kernel.dk \
--to=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jmoyer@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=ngrigoriev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.