From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Jason Cooper <jason@lakedaemon.net>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()
Date: Fri, 5 Sep 2014 20:20:44 +0200 [thread overview]
Message-ID: <20140905202044.4c166a43@free-electrons.com> (raw)
In-Reply-To: <20140905174122.GD8080@google.com>
Dear Bjorn Helgaas,
On Fri, 5 Sep 2014 11:41:22 -0600, Bjorn Helgaas wrote:
> This fix looks right to me. I added a stable tag as follows. Thomas
> and/or Jason, and you ack this?
Hum, I think I would actually prefer something like:
if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_IO)
rtype = IORESOURCE_IO;
else if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_MEM32)
rtype = IORESOURCE_MEM;
+ else
+ continue;
So that we're explicit with the fact that we only care about I/O and
MEM32 resource types.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()
Date: Fri, 5 Sep 2014 20:20:44 +0200 [thread overview]
Message-ID: <20140905202044.4c166a43@free-electrons.com> (raw)
In-Reply-To: <20140905174122.GD8080@google.com>
Dear Bjorn Helgaas,
On Fri, 5 Sep 2014 11:41:22 -0600, Bjorn Helgaas wrote:
> This fix looks right to me. I added a stable tag as follows. Thomas
> and/or Jason, and you ack this?
Hum, I think I would actually prefer something like:
if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_IO)
rtype = IORESOURCE_IO;
else if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_MEM32)
rtype = IORESOURCE_MEM;
+ else
+ continue;
So that we're explicit with the fact that we only care about I/O and
MEM32 resource types.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-05 18:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 15:34 [PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr() Geert Uytterhoeven
2014-08-08 15:34 ` Geert Uytterhoeven
2014-09-05 17:41 ` Bjorn Helgaas
2014-09-05 17:41 ` Bjorn Helgaas
2014-09-05 17:51 ` Arnd Bergmann
2014-09-05 17:51 ` Arnd Bergmann
2014-09-05 18:20 ` Thomas Petazzoni [this message]
2014-09-05 18:20 ` Thomas Petazzoni
2014-09-05 18:34 ` Arnd Bergmann
2014-09-05 18:34 ` Arnd Bergmann
2014-09-05 19:00 ` Bjorn Helgaas
2014-09-05 19:00 ` Bjorn Helgaas
2014-09-16 23:17 ` Bjorn Helgaas
2014-09-16 23:17 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2014-09-17 15:58 Thomas Petazzoni
2014-09-17 15:58 ` Thomas Petazzoni
2014-09-22 20:43 ` Bjorn Helgaas
2014-09-22 20:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905202044.4c166a43@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.