From: Bjorn Helgaas <bhelgaas@google.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm <linux-arm-kernel@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()
Date: Tue, 16 Sep 2014 17:17:16 -0600 [thread overview]
Message-ID: <20140916231716.GG5050@google.com> (raw)
In-Reply-To: <CAErSpo4sEQN6T9knuh4U2x9BCUODJheaAf3S8+W4U4oC-C7mMA@mail.gmail.com>
On Fri, Sep 05, 2014 at 01:00:29PM -0600, Bjorn Helgaas wrote:
> On Fri, Sep 5, 2014 at 12:34 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Friday 05 September 2014 20:20:44 Thomas Petazzoni wrote:
> >> Hum, I think I would actually prefer something like:
> >>
> >> if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_IO)
> >> rtype = IORESOURCE_IO;
> >> else if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_MEM32)
> >> rtype = IORESOURCE_MEM;
> >> + else
> >> + continue;
> >>
> >> So that we're explicit with the fact that we only care about I/O and
> >> MEM32 resource types.
> >
> > Agreed, that looks better than my patch as well.
>
> I like it better, too, but we still need the "range += rangesz" part,
> so I don't think it will work. I suppose that could be moved to the
> update expression of the "for" loop. Or, since we don't use "i" in
> the loop at all, maybe we could do something like this:
>
> for (; range < rend; range += rangesz)
Any more input on this? I don't think I've seen anything actually acked by
Thomas or Jason.
WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()
Date: Tue, 16 Sep 2014 17:17:16 -0600 [thread overview]
Message-ID: <20140916231716.GG5050@google.com> (raw)
In-Reply-To: <CAErSpo4sEQN6T9knuh4U2x9BCUODJheaAf3S8+W4U4oC-C7mMA@mail.gmail.com>
On Fri, Sep 05, 2014 at 01:00:29PM -0600, Bjorn Helgaas wrote:
> On Fri, Sep 5, 2014 at 12:34 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Friday 05 September 2014 20:20:44 Thomas Petazzoni wrote:
> >> Hum, I think I would actually prefer something like:
> >>
> >> if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_IO)
> >> rtype = IORESOURCE_IO;
> >> else if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_MEM32)
> >> rtype = IORESOURCE_MEM;
> >> + else
> >> + continue;
> >>
> >> So that we're explicit with the fact that we only care about I/O and
> >> MEM32 resource types.
> >
> > Agreed, that looks better than my patch as well.
>
> I like it better, too, but we still need the "range += rangesz" part,
> so I don't think it will work. I suppose that could be moved to the
> update expression of the "for" loop. Or, since we don't use "i" in
> the loop at all, maybe we could do something like this:
>
> for (; range < rend; range += rangesz)
Any more input on this? I don't think I've seen anything actually acked by
Thomas or Jason.
next prev parent reply other threads:[~2014-09-16 23:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 15:34 [PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr() Geert Uytterhoeven
2014-08-08 15:34 ` Geert Uytterhoeven
2014-09-05 17:41 ` Bjorn Helgaas
2014-09-05 17:41 ` Bjorn Helgaas
2014-09-05 17:51 ` Arnd Bergmann
2014-09-05 17:51 ` Arnd Bergmann
2014-09-05 18:20 ` Thomas Petazzoni
2014-09-05 18:20 ` Thomas Petazzoni
2014-09-05 18:34 ` Arnd Bergmann
2014-09-05 18:34 ` Arnd Bergmann
2014-09-05 19:00 ` Bjorn Helgaas
2014-09-05 19:00 ` Bjorn Helgaas
2014-09-16 23:17 ` Bjorn Helgaas [this message]
2014-09-16 23:17 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2014-09-17 15:58 Thomas Petazzoni
2014-09-17 15:58 ` Thomas Petazzoni
2014-09-22 20:43 ` Bjorn Helgaas
2014-09-22 20:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916231716.GG5050@google.com \
--to=bhelgaas@google.com \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.