All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] at91: drivers for 3.18 #2
Date: Tue, 9 Sep 2014 11:15:20 +0200	[thread overview]
Message-ID: <20140909091520.GJ3804@lukather> (raw)
In-Reply-To: <26517543.McM8Q5P0vn@wuerfel>

On Mon, Sep 08, 2014 at 11:52:35AM +0200, Arnd Bergmann wrote:
> On Monday 08 September 2014 11:26:42 Maxime Ripard wrote:
> > On Fri, Sep 05, 2014 at 11:25:11PM +0200, Arnd Bergmann wrote:
> > > On Friday 05 September 2014, Nicolas Ferre wrote:
> > > > Arnd, Olof, Kevin,
> > > > 
> > > > This pull-request is focused on the work that Maxime did for migrating our timer
> > > > (PIT) to the clocksource sub-system. A big cleanup happened which allows us to
> > > > be even closer to the point when we have only the bare minimum in our formerly
> > > > crowded mach-at91 directory.
> > > > 
> > > > This pull-request goes on top of the "drivers" one already sent to you on Sept.
> > > > 01st.
> > > 
> > > Hmm, I'm not too happy to see more uses of early_platform_*, I was hoping
> > > we could kill that off in the long run. This is only used for the legacy
> > > board files, not for DT, right?
> > 
> > Yes, the DT uses the usual CLOCKSOURCE_OF_DECLARE mechanism.
> > 
> > I wasn't aware that early_platform drivers were in the killzone, but
> > I'm definitely aware that global custom exported functions are, hence
> > why I went this way.
> 
> I don't think it has been discussed much on the mailing list or IRC.
> The early platform devices have not been used much outside of arch/sh
> and arch/arm/mach-shmobile, and those only use it for clocksource and
> serial.

That's what I found, yes.

> Now we have a new method for both of these, at least with DT, so
> my impression is that we won't need the early_platform support in
> the future.

I agree with that. I only see the early platform stuff as a temporary
measure for board files, before they're removed.

> One of the problems with the current interface is that it requires
> statically declaring platform_device structures, which is something
> that has been on Greg's list of device model antipatterns for a long
> time.

I didn't find any difference with how you declare platform_devices
compared to the old-usual way in board files, or was it something on
the list too ? :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140909/d719a72e/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Olof Johansson <olof@lixom.net>,
	arm@kernel.org, Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: [GIT PULL] at91: drivers for 3.18 #2
Date: Tue, 9 Sep 2014 11:15:20 +0200	[thread overview]
Message-ID: <20140909091520.GJ3804@lukather> (raw)
In-Reply-To: <26517543.McM8Q5P0vn@wuerfel>

[-- Attachment #1: Type: text/plain, Size: 2212 bytes --]

On Mon, Sep 08, 2014 at 11:52:35AM +0200, Arnd Bergmann wrote:
> On Monday 08 September 2014 11:26:42 Maxime Ripard wrote:
> > On Fri, Sep 05, 2014 at 11:25:11PM +0200, Arnd Bergmann wrote:
> > > On Friday 05 September 2014, Nicolas Ferre wrote:
> > > > Arnd, Olof, Kevin,
> > > > 
> > > > This pull-request is focused on the work that Maxime did for migrating our timer
> > > > (PIT) to the clocksource sub-system. A big cleanup happened which allows us to
> > > > be even closer to the point when we have only the bare minimum in our formerly
> > > > crowded mach-at91 directory.
> > > > 
> > > > This pull-request goes on top of the "drivers" one already sent to you on Sept.
> > > > 01st.
> > > 
> > > Hmm, I'm not too happy to see more uses of early_platform_*, I was hoping
> > > we could kill that off in the long run. This is only used for the legacy
> > > board files, not for DT, right?
> > 
> > Yes, the DT uses the usual CLOCKSOURCE_OF_DECLARE mechanism.
> > 
> > I wasn't aware that early_platform drivers were in the killzone, but
> > I'm definitely aware that global custom exported functions are, hence
> > why I went this way.
> 
> I don't think it has been discussed much on the mailing list or IRC.
> The early platform devices have not been used much outside of arch/sh
> and arch/arm/mach-shmobile, and those only use it for clocksource and
> serial.

That's what I found, yes.

> Now we have a new method for both of these, at least with DT, so
> my impression is that we won't need the early_platform support in
> the future.

I agree with that. I only see the early platform stuff as a temporary
measure for board files, before they're removed.

> One of the problems with the current interface is that it requires
> statically declaring platform_device structures, which is something
> that has been on Greg's list of device model antipatterns for a long
> time.

I didn't find any difference with how you declare platform_devices
compared to the old-usual way in board files, or was it something on
the list too ? :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-09-09  9:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 16:36 [GIT PULL] at91: drivers for 3.18 #2 Nicolas Ferre
2014-09-05 16:36 ` Nicolas Ferre
2014-09-05 21:25 ` Arnd Bergmann
2014-09-05 21:25   ` Arnd Bergmann
2014-09-05 21:39   ` Arnd Bergmann
2014-09-05 21:39     ` Arnd Bergmann
2014-09-08  9:26   ` Maxime Ripard
2014-09-08  9:26     ` Maxime Ripard
2014-09-08  9:52     ` Arnd Bergmann
2014-09-08  9:52       ` Arnd Bergmann
2014-09-09  9:15       ` Maxime Ripard [this message]
2014-09-09  9:15         ` Maxime Ripard
2014-09-09  9:27         ` Arnd Bergmann
2014-09-09  9:27           ` Arnd Bergmann
2014-09-15 16:12 ` [GIT PULL] at91: drivers for 3.18 #2 (bis) Nicolas Ferre
2014-09-15 16:12   ` Nicolas Ferre
2014-09-24  4:59   ` Olof Johansson
2014-09-24  4:59     ` Olof Johansson
2014-09-24 10:50     ` Nicolas Ferre
2014-09-24 10:50       ` Nicolas Ferre
2014-09-24 17:34       ` Olof Johansson
2014-09-24 17:34         ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140909091520.GJ3804@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.