From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/8] net: pxa168_eth: get and set the mac address on the Ethernet controller
Date: Tue, 9 Sep 2014 18:36:22 +0200 [thread overview]
Message-ID: <20140909163622.GA28752@kwain> (raw)
In-Reply-To: <20140909162958.GS30828@titan.lakedaemon.net>
Jason,
On Tue, Sep 09, 2014 at 12:29:58PM -0400, Jason Cooper wrote:
> On Tue, Sep 09, 2014 at 04:44:05PM +0200, Antoine Tenart wrote:
> > When changing the MAC address, in addition to updating the dev_addr in
> > the net_device structure, this patch also update the MAC address
> > registers (high and low) of the Ethernet controller with the new MAC.
> > The address stored in these registers is used for IEEE 802.3x Ethernet
> > flow control, which is already enabled.
> >
> > This patch also tries reading the MAC address stored in these registers
> > when probing the driver, to use the MAC address set by the bootloader
> > and avoid using a random one.
>
> Hmm, the wording here seems odd. I think the preference should be:
>
> 1) bootloader-supplied addr via DT
> 2) addr read from device
> 3) randomly generated one.
I agree. I'll update that.
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
Antoine Tenart <antoine.tenart@free-electrons.com>,
linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, jszhang@marvell.com,
linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v2 5/8] net: pxa168_eth: get and set the mac address on the Ethernet controller
Date: Tue, 9 Sep 2014 18:36:22 +0200 [thread overview]
Message-ID: <20140909163622.GA28752@kwain> (raw)
In-Reply-To: <20140909162958.GS30828@titan.lakedaemon.net>
Jason,
On Tue, Sep 09, 2014 at 12:29:58PM -0400, Jason Cooper wrote:
> On Tue, Sep 09, 2014 at 04:44:05PM +0200, Antoine Tenart wrote:
> > When changing the MAC address, in addition to updating the dev_addr in
> > the net_device structure, this patch also update the MAC address
> > registers (high and low) of the Ethernet controller with the new MAC.
> > The address stored in these registers is used for IEEE 802.3x Ethernet
> > flow control, which is already enabled.
> >
> > This patch also tries reading the MAC address stored in these registers
> > when probing the driver, to use the MAC address set by the bootloader
> > and avoid using a random one.
>
> Hmm, the wording here seems odd. I think the preference should be:
>
> 1) bootloader-supplied addr via DT
> 2) addr read from device
> 3) randomly generated one.
I agree. I'll update that.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com,
alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/8] net: pxa168_eth: get and set the mac address on the Ethernet controller
Date: Tue, 9 Sep 2014 18:36:22 +0200 [thread overview]
Message-ID: <20140909163622.GA28752@kwain> (raw)
In-Reply-To: <20140909162958.GS30828@titan.lakedaemon.net>
Jason,
On Tue, Sep 09, 2014 at 12:29:58PM -0400, Jason Cooper wrote:
> On Tue, Sep 09, 2014 at 04:44:05PM +0200, Antoine Tenart wrote:
> > When changing the MAC address, in addition to updating the dev_addr in
> > the net_device structure, this patch also update the MAC address
> > registers (high and low) of the Ethernet controller with the new MAC.
> > The address stored in these registers is used for IEEE 802.3x Ethernet
> > flow control, which is already enabled.
> >
> > This patch also tries reading the MAC address stored in these registers
> > when probing the driver, to use the MAC address set by the bootloader
> > and avoid using a random one.
>
> Hmm, the wording here seems odd. I think the preference should be:
>
> 1) bootloader-supplied addr via DT
> 2) addr read from device
> 3) randomly generated one.
I agree. I'll update that.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-09 16:36 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 14:44 [PATCH v2 0/8] ARM: Berlin: Ethernet support Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 1/8] net: pxa168_eth: clean up Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 2/8] net: pxa168_eth: add device tree support Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 3/8] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 15:58 ` Arnd Bergmann
2014-09-09 15:58 ` Arnd Bergmann
2014-09-09 16:01 ` Antoine Tenart
2014-09-09 16:01 ` Antoine Tenart
2014-09-09 16:01 ` Antoine Tenart
2014-09-09 17:47 ` Arnd Bergmann
2014-09-09 17:47 ` Arnd Bergmann
2014-09-09 17:47 ` Arnd Bergmann
2014-09-09 17:52 ` Mark Rutland
2014-09-09 17:52 ` Mark Rutland
2014-09-09 17:52 ` Mark Rutland
2014-09-09 14:44 ` [PATCH v2 4/8] net: pxa168_eth: fix Ethernet flow control status Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-10 15:39 ` Andrew Lunn
2014-09-10 15:39 ` Andrew Lunn
2014-09-10 15:39 ` Andrew Lunn
2014-09-10 17:44 ` Antoine Tenart
2014-09-10 17:44 ` Antoine Tenart
2014-09-10 17:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 5/8] net: pxa168_eth: get and set the mac address on the Ethernet controller Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 15:59 ` Arnd Bergmann
2014-09-09 15:59 ` Arnd Bergmann
2014-09-09 16:29 ` Jason Cooper
2014-09-09 16:29 ` Jason Cooper
2014-09-09 16:29 ` Jason Cooper
2014-09-09 16:36 ` Antoine Tenart [this message]
2014-09-09 16:36 ` Antoine Tenart
2014-09-09 16:36 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 6/8] net: pxa168_eth: allow Berlin SoCs to use the pxa168_eth driver Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 7/8] ARM: dts: berlin: add the Ethernet node Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 8/8] ARM: dts: berlin: enable the Ethernet port on the BG2Q DMP Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909163622.GA28752@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.