From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller
Date: Tue, 09 Sep 2014 19:47:35 +0200 [thread overview]
Message-ID: <2897714.QyEFFDa5hL@wuerfel> (raw)
In-Reply-To: <20140909160136.GA26051@kwain>
On Tuesday 09 September 2014 18:01:36 Antoine Tenart wrote:
>
> On Tue, Sep 09, 2014 at 05:58:12PM +0200, Arnd Bergmann wrote:
> > On Tuesday 09 September 2014 16:44:03 Antoine Tenart wrote:
> > > +- clocks: pointer to the clock for the device.
> > > +- clock-names: should be "MFUCLK".
> >
> > Clock names are normally not capitalized. Are you able to change
> > that name when providing a binding or make it an anoymous clock?
> > What does MFU stand for anyway?
>
> Sure. I could have make it an anonymous clock but the name "MFUCLK" was
> already used by the pxa168 Ethernet driver so I didn't wanted to change
> that.
I believe you can just ask for an anonymous clock anyway and get the
first one even if it has a name, but I didn't check.
In any case, we should not just take a clock name in a DT binding
because it happened to be used by platform code. It's easy fix the
platform code when someone makes a mistake there, but very hard to
fix DT strings once there are users relying on a particular convention.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Antoine Tenart
<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v2 3/8] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller
Date: Tue, 09 Sep 2014 19:47:35 +0200 [thread overview]
Message-ID: <2897714.QyEFFDa5hL@wuerfel> (raw)
In-Reply-To: <20140909160136.GA26051@kwain>
On Tuesday 09 September 2014 18:01:36 Antoine Tenart wrote:
>
> On Tue, Sep 09, 2014 at 05:58:12PM +0200, Arnd Bergmann wrote:
> > On Tuesday 09 September 2014 16:44:03 Antoine Tenart wrote:
> > > +- clocks: pointer to the clock for the device.
> > > +- clock-names: should be "MFUCLK".
> >
> > Clock names are normally not capitalized. Are you able to change
> > that name when providing a binding or make it an anoymous clock?
> > What does MFU stand for anyway?
>
> Sure. I could have make it an anonymous clock but the name "MFUCLK" was
> already used by the pxa168 Ethernet driver so I didn't wanted to change
> that.
I believe you can just ask for an anonymous clock anyway and get the
first one even if it has a name, but I didn't check.
In any case, we should not just take a clock name in a DT binding
because it happened to be used by platform code. It's easy fix the
platform code when someone makes a mistake there, but very hard to
fix DT strings once there are users relying on a particular convention.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, jszhang@marvell.com,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v2 3/8] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller
Date: Tue, 09 Sep 2014 19:47:35 +0200 [thread overview]
Message-ID: <2897714.QyEFFDa5hL@wuerfel> (raw)
In-Reply-To: <20140909160136.GA26051@kwain>
On Tuesday 09 September 2014 18:01:36 Antoine Tenart wrote:
>
> On Tue, Sep 09, 2014 at 05:58:12PM +0200, Arnd Bergmann wrote:
> > On Tuesday 09 September 2014 16:44:03 Antoine Tenart wrote:
> > > +- clocks: pointer to the clock for the device.
> > > +- clock-names: should be "MFUCLK".
> >
> > Clock names are normally not capitalized. Are you able to change
> > that name when providing a binding or make it an anoymous clock?
> > What does MFU stand for anyway?
>
> Sure. I could have make it an anonymous clock but the name "MFUCLK" was
> already used by the pxa168 Ethernet driver so I didn't wanted to change
> that.
I believe you can just ask for an anonymous clock anyway and get the
first one even if it has a name, but I didn't check.
In any case, we should not just take a clock name in a DT binding
because it happened to be used by platform code. It's easy fix the
platform code when someone makes a mistake there, but very hard to
fix DT strings once there are users relying on a particular convention.
Arnd
next prev parent reply other threads:[~2014-09-09 17:47 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 14:44 [PATCH v2 0/8] ARM: Berlin: Ethernet support Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 1/8] net: pxa168_eth: clean up Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 2/8] net: pxa168_eth: add device tree support Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 3/8] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 15:58 ` Arnd Bergmann
2014-09-09 15:58 ` Arnd Bergmann
2014-09-09 16:01 ` Antoine Tenart
2014-09-09 16:01 ` Antoine Tenart
2014-09-09 16:01 ` Antoine Tenart
2014-09-09 17:47 ` Arnd Bergmann [this message]
2014-09-09 17:47 ` Arnd Bergmann
2014-09-09 17:47 ` Arnd Bergmann
2014-09-09 17:52 ` Mark Rutland
2014-09-09 17:52 ` Mark Rutland
2014-09-09 17:52 ` Mark Rutland
2014-09-09 14:44 ` [PATCH v2 4/8] net: pxa168_eth: fix Ethernet flow control status Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-10 15:39 ` Andrew Lunn
2014-09-10 15:39 ` Andrew Lunn
2014-09-10 15:39 ` Andrew Lunn
2014-09-10 17:44 ` Antoine Tenart
2014-09-10 17:44 ` Antoine Tenart
2014-09-10 17:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 5/8] net: pxa168_eth: get and set the mac address on the Ethernet controller Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 15:59 ` Arnd Bergmann
2014-09-09 15:59 ` Arnd Bergmann
2014-09-09 16:29 ` Jason Cooper
2014-09-09 16:29 ` Jason Cooper
2014-09-09 16:29 ` Jason Cooper
2014-09-09 16:36 ` Antoine Tenart
2014-09-09 16:36 ` Antoine Tenart
2014-09-09 16:36 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 6/8] net: pxa168_eth: allow Berlin SoCs to use the pxa168_eth driver Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 7/8] ARM: dts: berlin: add the Ethernet node Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
2014-09-09 14:44 ` [PATCH v2 8/8] ARM: dts: berlin: enable the Ethernet port on the BG2Q DMP Antoine Tenart
2014-09-09 14:44 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2897714.QyEFFDa5hL@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.