From: Robin Gong <b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<marex-ynQEQJNshbs@public.gmane.org>,
<shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
<Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v5] spi: spi-imx: add DMA support
Date: Wed, 10 Sep 2014 16:28:55 +0800 [thread overview]
Message-ID: <20140910082853.GA29906@Robin-OptiPlex-780> (raw)
In-Reply-To: <5412055.BAOgFikuh9@wuerfel>
On Wed, Sep 10, 2014 at 10:17:14AM +0200, Arnd Bergmann wrote:
> On Wednesday 10 September 2014 09:30:04 Robin Gong wrote:
> > Enable DMA support on i.mx6. The read speed can increase from 600KB/s
> > to 1.2MB/s on i.mx6q. You can disable or enable dma function in dts.
> > If not set "dma-names" in dts, spi will use PIO mode. This patch only
> > validate on i.mx6, not i.mx5, but encourage ones to apply this patch
> > on i.mx5 since they share the same IP.
> >
> > Note:
> > Sometime, there is a weid data in rxfifo after one full tx/rx
> > transfer finish by DMA on i.mx6dl, so we disable dma functhion on
> > i.mx6dl.
> >
> > Signed-off-by: Frank Li <Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > Signed-off-by: Robin Gong <b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >
> >
>
> The patch looks good to me, but you need to also update the
> Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt file to
> document the additional optional properties.
>
> Arnd
Thanks for your reminding, I'll add it in the v6.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: b38343@freescale.com (Robin Gong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] spi: spi-imx: add DMA support
Date: Wed, 10 Sep 2014 16:28:55 +0800 [thread overview]
Message-ID: <20140910082853.GA29906@Robin-OptiPlex-780> (raw)
In-Reply-To: <5412055.BAOgFikuh9@wuerfel>
On Wed, Sep 10, 2014 at 10:17:14AM +0200, Arnd Bergmann wrote:
> On Wednesday 10 September 2014 09:30:04 Robin Gong wrote:
> > Enable DMA support on i.mx6. The read speed can increase from 600KB/s
> > to 1.2MB/s on i.mx6q. You can disable or enable dma function in dts.
> > If not set "dma-names" in dts, spi will use PIO mode. This patch only
> > validate on i.mx6, not i.mx5, but encourage ones to apply this patch
> > on i.mx5 since they share the same IP.
> >
> > Note:
> > Sometime, there is a weid data in rxfifo after one full tx/rx
> > transfer finish by DMA on i.mx6dl, so we disable dma functhion on
> > i.mx6dl.
> >
> > Signed-off-by: Frank Li <Frank.Li@freescale.com>
> > Signed-off-by: Robin Gong <b38343@freescale.com>
> >
> >
>
> The patch looks good to me, but you need to also update the
> Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt file to
> document the additional optional properties.
>
> Arnd
Thanks for your reminding, I'll add it in the v6.
WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <b38343@freescale.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>, <broonie@kernel.org>,
<marex@denx.de>, <shawn.guo@linaro.org>, <Frank.Li@freescale.com>,
<linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v5] spi: spi-imx: add DMA support
Date: Wed, 10 Sep 2014 16:28:55 +0800 [thread overview]
Message-ID: <20140910082853.GA29906@Robin-OptiPlex-780> (raw)
In-Reply-To: <5412055.BAOgFikuh9@wuerfel>
On Wed, Sep 10, 2014 at 10:17:14AM +0200, Arnd Bergmann wrote:
> On Wednesday 10 September 2014 09:30:04 Robin Gong wrote:
> > Enable DMA support on i.mx6. The read speed can increase from 600KB/s
> > to 1.2MB/s on i.mx6q. You can disable or enable dma function in dts.
> > If not set "dma-names" in dts, spi will use PIO mode. This patch only
> > validate on i.mx6, not i.mx5, but encourage ones to apply this patch
> > on i.mx5 since they share the same IP.
> >
> > Note:
> > Sometime, there is a weid data in rxfifo after one full tx/rx
> > transfer finish by DMA on i.mx6dl, so we disable dma functhion on
> > i.mx6dl.
> >
> > Signed-off-by: Frank Li <Frank.Li@freescale.com>
> > Signed-off-by: Robin Gong <b38343@freescale.com>
> >
> >
>
> The patch looks good to me, but you need to also update the
> Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt file to
> document the additional optional properties.
>
> Arnd
Thanks for your reminding, I'll add it in the v6.
next prev parent reply other threads:[~2014-09-10 8:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 1:30 [PATCH v5] spi: spi-imx: add DMA support Robin Gong
2014-09-10 1:30 ` Robin Gong
2014-09-10 4:16 ` Varka Bhadram
2014-09-10 4:16 ` Varka Bhadram
[not found] ` <540FD084.6000805-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-10 5:46 ` Robin Gong
2014-09-10 5:46 ` Robin Gong
2014-09-10 5:46 ` Robin Gong
[not found] ` <1410312604-31949-1-git-send-email-b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-09-10 8:17 ` Arnd Bergmann
2014-09-10 8:17 ` Arnd Bergmann
2014-09-10 8:17 ` Arnd Bergmann
2014-09-10 8:28 ` Robin Gong [this message]
2014-09-10 8:28 ` Robin Gong
2014-09-10 8:28 ` Robin Gong
2014-09-10 10:21 ` Mark Brown
2014-09-10 10:21 ` Mark Brown
[not found] ` <20140910102105.GR2601-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-10 11:22 ` Robin Gong
2014-09-10 11:22 ` Robin Gong
2014-09-10 11:22 ` Robin Gong
2014-09-10 11:45 ` Mark Brown
2014-09-10 11:45 ` Mark Brown
2014-09-10 11:45 ` Mark Brown
[not found] ` <20140910114530.GD7960-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-10 15:18 ` Robin Gong
2014-09-10 15:18 ` Robin Gong
2014-09-10 15:18 ` Robin Gong
2014-09-10 15:52 ` Mark Brown
2014-09-10 15:52 ` Mark Brown
2014-09-10 15:52 ` Mark Brown
2014-09-11 1:37 ` Robin Gong
2014-09-11 1:37 ` Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910082853.GA29906@Robin-OptiPlex-780 \
--to=b38343-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.