From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Robin Gong <b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
marex-ynQEQJNshbs@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org
Subject: Re: [PATCH v5] spi: spi-imx: add DMA support
Date: Wed, 10 Sep 2014 12:45:30 +0100 [thread overview]
Message-ID: <20140910114530.GD7960@sirena.org.uk> (raw)
In-Reply-To: <20140910112258.GA30794@Robin-OptiPlex-780>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On Wed, Sep 10, 2014 at 07:22:59PM +0800, Robin Gong wrote:
> On Wed, Sep 10, 2014 at 11:21:05AM +0100, Mark Brown wrote:
> > This isn't going to work, anything that looks at the usedma flag will
> > see the result of the last thing that was checked which may or may not
> > be the transfer that it's handling. The driver should check to see if
> > the core mapped the transfer for DMA.
> Yes, you're right. I should use "transfer->tx_sg->sgl == NULL" or
> "transfer->rx_sg->sgl == NULL" instead of usedma flag in driver, right?
Right.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] spi: spi-imx: add DMA support
Date: Wed, 10 Sep 2014 12:45:30 +0100 [thread overview]
Message-ID: <20140910114530.GD7960@sirena.org.uk> (raw)
In-Reply-To: <20140910112258.GA30794@Robin-OptiPlex-780>
On Wed, Sep 10, 2014 at 07:22:59PM +0800, Robin Gong wrote:
> On Wed, Sep 10, 2014 at 11:21:05AM +0100, Mark Brown wrote:
> > This isn't going to work, anything that looks at the usedma flag will
> > see the result of the last thing that was checked which may or may not
> > be the transfer that it's handling. The driver should check to see if
> > the core mapped the transfer for DMA.
> Yes, you're right. I should use "transfer->tx_sg->sgl == NULL" or
> "transfer->rx_sg->sgl == NULL" instead of usedma flag in driver, right?
Right.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140910/6247a2a4/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Robin Gong <b38343@freescale.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, marex@denx.de,
shawn.guo@linaro.org, Frank.Li@freescale.com
Subject: Re: [PATCH v5] spi: spi-imx: add DMA support
Date: Wed, 10 Sep 2014 12:45:30 +0100 [thread overview]
Message-ID: <20140910114530.GD7960@sirena.org.uk> (raw)
In-Reply-To: <20140910112258.GA30794@Robin-OptiPlex-780>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On Wed, Sep 10, 2014 at 07:22:59PM +0800, Robin Gong wrote:
> On Wed, Sep 10, 2014 at 11:21:05AM +0100, Mark Brown wrote:
> > This isn't going to work, anything that looks at the usedma flag will
> > see the result of the last thing that was checked which may or may not
> > be the transfer that it's handling. The driver should check to see if
> > the core mapped the transfer for DMA.
> Yes, you're right. I should use "transfer->tx_sg->sgl == NULL" or
> "transfer->rx_sg->sgl == NULL" instead of usedma flag in driver, right?
Right.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-10 11:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 1:30 [PATCH v5] spi: spi-imx: add DMA support Robin Gong
2014-09-10 1:30 ` Robin Gong
2014-09-10 4:16 ` Varka Bhadram
2014-09-10 4:16 ` Varka Bhadram
[not found] ` <540FD084.6000805-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-10 5:46 ` Robin Gong
2014-09-10 5:46 ` Robin Gong
2014-09-10 5:46 ` Robin Gong
[not found] ` <1410312604-31949-1-git-send-email-b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-09-10 8:17 ` Arnd Bergmann
2014-09-10 8:17 ` Arnd Bergmann
2014-09-10 8:17 ` Arnd Bergmann
2014-09-10 8:28 ` Robin Gong
2014-09-10 8:28 ` Robin Gong
2014-09-10 8:28 ` Robin Gong
2014-09-10 10:21 ` Mark Brown
2014-09-10 10:21 ` Mark Brown
[not found] ` <20140910102105.GR2601-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-10 11:22 ` Robin Gong
2014-09-10 11:22 ` Robin Gong
2014-09-10 11:22 ` Robin Gong
2014-09-10 11:45 ` Mark Brown [this message]
2014-09-10 11:45 ` Mark Brown
2014-09-10 11:45 ` Mark Brown
[not found] ` <20140910114530.GD7960-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-09-10 15:18 ` Robin Gong
2014-09-10 15:18 ` Robin Gong
2014-09-10 15:18 ` Robin Gong
2014-09-10 15:52 ` Mark Brown
2014-09-10 15:52 ` Mark Brown
2014-09-10 15:52 ` Mark Brown
2014-09-11 1:37 ` Robin Gong
2014-09-11 1:37 ` Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910114530.GD7960@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.