From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@freescale.com>
Cc: timur@tabi.org, Li.Xiubo@freescale.com, lgirdwood@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Thu, 11 Sep 2014 15:57:37 -0700 [thread overview]
Message-ID: <20140911225737.GA13926@Alpha> (raw)
In-Reply-To: <27584da8e3ab291ab8dbcbb411579613f8384a59.1410413734.git.shengjiu.wang@freescale.com>
On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote:
> Move the ipg clock enable and disable operation to startup and shutdown,
> that is only enable ipg clock when ssi is working. Keep clock is disabled
> when ssi is in idle.
> otherwise, _fsl_ssi_set_dai_fmt function need to be called in probe,
> so add ipg clock control for it.
It seems to be no objection so far against my last suggestion to
use regmap's mmio_clk() for named ipg clk only. So you may still
consider about that.
Anyway, I'd like to do thing in parallel. So I just simply tested
it on my side and its works fine, it may still need to be tested
by others though.
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@freescale.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.de,
Li.Xiubo@freescale.com, timur@tabi.org, perex@perex.cz,
broonie@kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Thu, 11 Sep 2014 15:57:37 -0700 [thread overview]
Message-ID: <20140911225737.GA13926@Alpha> (raw)
In-Reply-To: <27584da8e3ab291ab8dbcbb411579613f8384a59.1410413734.git.shengjiu.wang@freescale.com>
On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote:
> Move the ipg clock enable and disable operation to startup and shutdown,
> that is only enable ipg clock when ssi is working. Keep clock is disabled
> when ssi is in idle.
> otherwise, _fsl_ssi_set_dai_fmt function need to be called in probe,
> so add ipg clock control for it.
It seems to be no objection so far against my last suggestion to
use regmap's mmio_clk() for named ipg clk only. So you may still
consider about that.
Anyway, I'd like to do thing in parallel. So I just simply tested
it on my side and its works fine, it may still need to be tested
by others though.
Nicolin
next prev parent reply other threads:[~2014-09-11 22:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 5:38 [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module Shengjiu Wang
2014-09-11 5:38 ` Shengjiu Wang
2014-09-11 5:38 ` Shengjiu Wang
2014-09-11 22:57 ` Nicolin Chen [this message]
2014-09-11 22:57 ` Nicolin Chen
2014-09-12 2:01 ` Shengjiu Wang
2014-09-12 2:01 ` Shengjiu Wang
2014-09-12 2:01 ` Shengjiu Wang
2014-09-12 6:17 ` Markus Pargmann
2014-09-12 6:17 ` Markus Pargmann
2014-09-12 7:14 ` Shengjiu Wang
2014-09-12 7:14 ` Shengjiu Wang
2014-09-12 7:14 ` Shengjiu Wang
2014-09-12 8:54 ` Markus Pargmann
2014-09-12 8:54 ` Markus Pargmann
2014-09-12 10:40 ` Shengjiu Wang
2014-09-12 10:40 ` Shengjiu Wang
2014-09-12 10:40 ` Shengjiu Wang
2014-09-12 2:43 ` Timur Tabi
2014-09-12 5:11 ` Shengjiu Wang
2014-09-12 5:11 ` Shengjiu Wang
2014-09-12 5:11 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911225737.GA13926@Alpha \
--to=nicoleotsuka@gmail.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@freescale.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.