From: Shengjiu Wang <shengjiu.wang@freescale.com>
To: Timur Tabi <timur@tabi.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
Li.Xiubo@freescale.com, lgirdwood@gmail.com,
nicoleotsuka@gmail.com, broonie@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Fri, 12 Sep 2014 13:11:42 +0800 [thread overview]
Message-ID: <20140912051140.GA3644@audiosh1> (raw)
In-Reply-To: <54125DEF.4090101@tabi.org>
On Thu, Sep 11, 2014 at 09:43:59PM -0500, Timur Tabi wrote:
> Shengjiu Wang wrote:
> >+ ret = clk_prepare_enable(ssi_private->clk);
> >+ if (ret)
> >+ return ret;
>
> Will this work on PowerPC, where ssi_private->clk is always NULL?
When ssi_private->clk is NULL, then ret = 0, so here will not return,
the code in below will be continuously executed.
I think it work on PowerPC.
wang shengjiu
WARNING: multiple messages have this Message-ID (diff)
From: Shengjiu Wang <shengjiu.wang@freescale.com>
To: Timur Tabi <timur@tabi.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
Li.Xiubo@freescale.com, lgirdwood@gmail.com, perex@perex.cz,
nicoleotsuka@gmail.com, broonie@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Fri, 12 Sep 2014 13:11:42 +0800 [thread overview]
Message-ID: <20140912051140.GA3644@audiosh1> (raw)
In-Reply-To: <54125DEF.4090101@tabi.org>
On Thu, Sep 11, 2014 at 09:43:59PM -0500, Timur Tabi wrote:
> Shengjiu Wang wrote:
> >+ ret = clk_prepare_enable(ssi_private->clk);
> >+ if (ret)
> >+ return ret;
>
> Will this work on PowerPC, where ssi_private->clk is always NULL?
When ssi_private->clk is NULL, then ret = 0, so here will not return,
the code in below will be continuously executed.
I think it work on PowerPC.
wang shengjiu
WARNING: multiple messages have this Message-ID (diff)
From: Shengjiu Wang <shengjiu.wang@freescale.com>
To: Timur Tabi <timur@tabi.org>
Cc: <nicoleotsuka@gmail.com>, <Li.Xiubo@freescale.com>,
<lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.de>, <alsa-devel@alsa-project.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Fri, 12 Sep 2014 13:11:42 +0800 [thread overview]
Message-ID: <20140912051140.GA3644@audiosh1> (raw)
In-Reply-To: <54125DEF.4090101@tabi.org>
On Thu, Sep 11, 2014 at 09:43:59PM -0500, Timur Tabi wrote:
> Shengjiu Wang wrote:
> >+ ret = clk_prepare_enable(ssi_private->clk);
> >+ if (ret)
> >+ return ret;
>
> Will this work on PowerPC, where ssi_private->clk is always NULL?
When ssi_private->clk is NULL, then ret = 0, so here will not return,
the code in below will be continuously executed.
I think it work on PowerPC.
wang shengjiu
next prev parent reply other threads:[~2014-09-12 5:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 5:38 [PATCH V2] ASoC: fsl_ssi: refine ipg clock usage in this module Shengjiu Wang
2014-09-11 5:38 ` Shengjiu Wang
2014-09-11 5:38 ` Shengjiu Wang
2014-09-11 22:57 ` Nicolin Chen
2014-09-11 22:57 ` Nicolin Chen
2014-09-12 2:01 ` Shengjiu Wang
2014-09-12 2:01 ` Shengjiu Wang
2014-09-12 2:01 ` Shengjiu Wang
2014-09-12 6:17 ` Markus Pargmann
2014-09-12 6:17 ` Markus Pargmann
2014-09-12 7:14 ` Shengjiu Wang
2014-09-12 7:14 ` Shengjiu Wang
2014-09-12 7:14 ` Shengjiu Wang
2014-09-12 8:54 ` Markus Pargmann
2014-09-12 8:54 ` Markus Pargmann
2014-09-12 10:40 ` Shengjiu Wang
2014-09-12 10:40 ` Shengjiu Wang
2014-09-12 10:40 ` Shengjiu Wang
2014-09-12 2:43 ` Timur Tabi
2014-09-12 5:11 ` Shengjiu Wang [this message]
2014-09-12 5:11 ` Shengjiu Wang
2014-09-12 5:11 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912051140.GA3644@audiosh1 \
--to=shengjiu.wang@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.