From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.de,
linux-kernel@vger.kernel.org, broonie@kernel.org, timur@tabi.org,
Li.Xiubo@freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver
Date: Tue, 16 Sep 2014 19:50:15 -0700 [thread overview]
Message-ID: <20140917025014.GA6048@Asurada> (raw)
In-Reply-To: <20140917023127.GA16456@dragon>
On Wed, Sep 17, 2014 at 10:31:28AM +0800, Shawn Guo wrote:
> On Tue, Sep 16, 2014 at 07:24:40PM -0700, Nicolin Chen wrote:
> > It's not supported in the clock API or just not implemented in our
> > code? Can we just register a clock without CLK_SET_RATE_PARENT to
> > achieve the purpose? (We are just trying to fix those PRED and PODF
> > dividers when the driver calls set_rate to their GATE clock.)
>
> It seems I misunderstood your question. Yes, if we drop flag
> CLK_SET_RATE_PARENT for the gate clock in question, the rate change
> request will not be propagated to upstream dividers.
Okay. Since there's a solution that allows us to handle it better,
problem solved then.
@Shengjiu
Would you please take a look at the clock driver to implement a
new clock register function? And make sure to register the GATE
clock only without the flag CLK_SET_RATE_PARENT, as we may still
need to set a reasonable rate for the clock by setting its PODF
clock node instead.
Thank you both
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.de,
linux-kernel@vger.kernel.org, broonie@kernel.org, timur@tabi.org,
perex@perex.cz, Li.Xiubo@freescale.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver
Date: Tue, 16 Sep 2014 19:50:15 -0700 [thread overview]
Message-ID: <20140917025014.GA6048@Asurada> (raw)
In-Reply-To: <20140917023127.GA16456@dragon>
On Wed, Sep 17, 2014 at 10:31:28AM +0800, Shawn Guo wrote:
> On Tue, Sep 16, 2014 at 07:24:40PM -0700, Nicolin Chen wrote:
> > It's not supported in the clock API or just not implemented in our
> > code? Can we just register a clock without CLK_SET_RATE_PARENT to
> > achieve the purpose? (We are just trying to fix those PRED and PODF
> > dividers when the driver calls set_rate to their GATE clock.)
>
> It seems I misunderstood your question. Yes, if we drop flag
> CLK_SET_RATE_PARENT for the gate clock in question, the rate change
> request will not be propagated to upstream dividers.
Okay. Since there's a solution that allows us to handle it better,
problem solved then.
@Shengjiu
Would you please take a look at the clock driver to implement a
new clock register function? And make sure to register the GATE
clock only without the flag CLK_SET_RATE_PARENT, as we may still
need to set a reasonable rate for the clock by setting its PODF
clock node instead.
Thank you both
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
timur@tabi.org, Li.Xiubo@freescale.com, lgirdwood@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver
Date: Tue, 16 Sep 2014 19:50:15 -0700 [thread overview]
Message-ID: <20140917025014.GA6048@Asurada> (raw)
In-Reply-To: <20140917023127.GA16456@dragon>
On Wed, Sep 17, 2014 at 10:31:28AM +0800, Shawn Guo wrote:
> On Tue, Sep 16, 2014 at 07:24:40PM -0700, Nicolin Chen wrote:
> > It's not supported in the clock API or just not implemented in our
> > code? Can we just register a clock without CLK_SET_RATE_PARENT to
> > achieve the purpose? (We are just trying to fix those PRED and PODF
> > dividers when the driver calls set_rate to their GATE clock.)
>
> It seems I misunderstood your question. Yes, if we drop flag
> CLK_SET_RATE_PARENT for the gate clock in question, the rate change
> request will not be propagated to upstream dividers.
Okay. Since there's a solution that allows us to handle it better,
problem solved then.
@Shengjiu
Would you please take a look at the clock driver to implement a
new clock register function? And make sure to register the GATE
clock only without the flag CLK_SET_RATE_PARENT, as we may still
need to set a reasonable rate for the clock by setting its PODF
clock node instead.
Thank you both
Nicolin
next prev parent reply other threads:[~2014-09-17 2:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 11:46 [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver Shengjiu Wang
2014-09-16 11:46 ` Shengjiu Wang
2014-09-16 11:46 ` Shengjiu Wang
2014-09-16 18:19 ` Nicolin Chen
2014-09-16 18:19 ` Nicolin Chen
2014-09-16 18:19 ` Nicolin Chen
2014-09-16 18:32 ` Mark Brown
2014-09-16 18:32 ` Mark Brown
2014-09-17 1:32 ` Shawn Guo
2014-09-17 1:32 ` Shawn Guo
2014-09-17 1:32 ` Shawn Guo
2014-09-17 2:24 ` Nicolin Chen
2014-09-17 2:24 ` Nicolin Chen
2014-09-17 2:24 ` Nicolin Chen
2014-09-17 2:31 ` Shawn Guo
2014-09-17 2:31 ` Shawn Guo
2014-09-17 2:31 ` Shawn Guo
2014-09-17 2:50 ` Nicolin Chen [this message]
2014-09-17 2:50 ` Nicolin Chen
2014-09-17 2:50 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917025014.GA6048@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shawn.guo@freescale.com \
--cc=shengjiu.wang@freescale.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.