All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: at91: remove no-MMU at91x40 support
Date: Wed, 24 Sep 2014 18:10:09 +0200	[thread overview]
Message-ID: <20140924161009.GK3026@piout.net> (raw)
In-Reply-To: <3874734.x93Q9kHIES@wuerfel>

On 24/09/2014 at 17:09:14 +0200, Arnd Bergmann wrote :
> On Wednesday 24 September 2014 17:03:11 Nicolas Ferre wrote:
> > > I think these can be simplified further: AT91_SAM9G45_RESET and
> > > AT91_SAM9_ALT_RESET can just go away and the files put into
> > > obj-y.
> > 
> > Yes, I had the same idea before realizing that these two directives will
> > move away in a patch already sent for 3.18. So, as this material is
> > probably 3.19-ish, I kept them as they are and keep in mind to remove
> > them when I merge them with 3.18-rc1...
> 
> Ok.
> 
> > > OLD_CLK_AT91 is the same as AT91_USE_OLD_CLK, so you could
> > > just use that instead. I suspect the 'USE_OF' dependency for
> > > COMMON_CLK_AT91 can also go away, since all platforms are
> > > either board file based and select AT91_USE_OLD_CLK, or they
> > > are DT based and don't.
> > 
> > Here also, I didn't want to touch more because we need to remove the
> > arch/arm/mach-at91/Kconfig.non_dt file very soon (3.19) and I don't want
> > to change this file (or all the SoC files) before the chunks related to
> > these directives simply go away.
> > 
> > Tell me if it makes sense.
> 
> Yes, I agree your approach is better then.
> 

Yeah and what you proposed would actually break the possibility to
compile a kernel that can both boot DT and non DT platforms. My guess is
that this is why we have both OLD_CLK_AT91 and AT91_USE_OLD_CLK.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-arm-kernel@lists.infradead.org,
	u.kleine-koenig@pengutronix.de, gerg@uclinux.org,
	Olof Johansson <olof@lixom.net>, ARM Maintainers <arm@kernel.org>,
	linux-kernel@vger.kernel.org,
	Patrice Vilchez <patrice.vilchez@atmel.com>,
	Ludovic Desroches <ludovic.desroches@atmel.com>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [RFC PATCH] ARM: at91: remove no-MMU at91x40 support
Date: Wed, 24 Sep 2014 18:10:09 +0200	[thread overview]
Message-ID: <20140924161009.GK3026@piout.net> (raw)
In-Reply-To: <3874734.x93Q9kHIES@wuerfel>

On 24/09/2014 at 17:09:14 +0200, Arnd Bergmann wrote :
> On Wednesday 24 September 2014 17:03:11 Nicolas Ferre wrote:
> > > I think these can be simplified further: AT91_SAM9G45_RESET and
> > > AT91_SAM9_ALT_RESET can just go away and the files put into
> > > obj-y.
> > 
> > Yes, I had the same idea before realizing that these two directives will
> > move away in a patch already sent for 3.18. So, as this material is
> > probably 3.19-ish, I kept them as they are and keep in mind to remove
> > them when I merge them with 3.18-rc1...
> 
> Ok.
> 
> > > OLD_CLK_AT91 is the same as AT91_USE_OLD_CLK, so you could
> > > just use that instead. I suspect the 'USE_OF' dependency for
> > > COMMON_CLK_AT91 can also go away, since all platforms are
> > > either board file based and select AT91_USE_OLD_CLK, or they
> > > are DT based and don't.
> > 
> > Here also, I didn't want to touch more because we need to remove the
> > arch/arm/mach-at91/Kconfig.non_dt file very soon (3.19) and I don't want
> > to change this file (or all the SoC files) before the chunks related to
> > these directives simply go away.
> > 
> > Tell me if it makes sense.
> 
> Yes, I agree your approach is better then.
> 

Yeah and what you proposed would actually break the possibility to
compile a kernel that can both boot DT and non DT platforms. My guess is
that this is why we have both OLD_CLK_AT91 and AT91_USE_OLD_CLK.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-09-24 16:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 14:18 [RFC PATCH] ARM: at91: remove no-MMU at91x40 support Nicolas Ferre
2014-09-24 14:18 ` Nicolas Ferre
2014-09-24 14:47 ` Arnd Bergmann
2014-09-24 14:47   ` Arnd Bergmann
2014-09-24 15:03   ` Nicolas Ferre
2014-09-24 15:03     ` Nicolas Ferre
2014-09-24 15:09     ` Arnd Bergmann
2014-09-24 15:09       ` Arnd Bergmann
2014-09-24 16:10       ` Alexandre Belloni [this message]
2014-09-24 16:10         ` Alexandre Belloni
2014-09-25  0:03 ` Greg Ungerer
2014-09-25  0:03   ` Greg Ungerer
2014-09-25  6:26 ` Uwe Kleine-König
2014-09-25  6:26   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924161009.GK3026@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.