All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: at91: remove no-MMU at91x40 support
Date: Wed, 24 Sep 2014 16:47:47 +0200	[thread overview]
Message-ID: <3700375.DRR5iB2NGi@wuerfel> (raw)
In-Reply-To: <1411568281-3924-1-git-send-email-nicolas.ferre@atmel.com>

On Wednesday 24 September 2014 16:18:01 Nicolas Ferre wrote:
> As there is currently no-one to take care of this old !MMU target and as its
> support in recent kernels is a bit rotten, remove this at91x40 support and the
> board file associated with it (at91eb01).
> There are modern ARM !MMU in Mainline now so this target is not interesting for
> building tests anymore. It would be better to start from these modern ARM !MMU
> platforms to reintroduce at91x40 support if needed.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 807b22dadcb6..f3bd8abd25c0 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -18,26 +18,22 @@ config HAVE_AT91_DBGU2
>  config AT91_USE_OLD_CLK
>  	bool
>  
> -config AT91_PMC_UNIT
> -	bool
> -	default !ARCH_AT91X40
> -
>  config COMMON_CLK_AT91
>  	bool
> -	default AT91_PMC_UNIT && USE_OF && !AT91_USE_OLD_CLK
> +	default USE_OF && !AT91_USE_OLD_CLK
>  	select COMMON_CLK
>  
>  config OLD_CLK_AT91
>  	bool
> -	default AT91_PMC_UNIT && AT91_USE_OLD_CLK
> +	default AT91_USE_OLD_CLK
>  
>  config AT91_SAM9_ALT_RESET
>  	bool
> -	default !ARCH_AT91X40
> +	default y
>  
>  config AT91_SAM9G45_RESET
>  	bool
> -	default !ARCH_AT91X40
> +	default y
>  
>  config AT91_SAM9_TIME
>  	bool

I think these can be simplified further: AT91_SAM9G45_RESET and
AT91_SAM9_ALT_RESET can just go away and the files put into
obj-y.

OLD_CLK_AT91 is the same as AT91_USE_OLD_CLK, so you could
just use that instead. I suspect the 'USE_OF' dependency for
COMMON_CLK_AT91 can also go away, since all platforms are
either board file based and select AT91_USE_OLD_CLK, or they
are DT based and don't.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org,
	u.kleine-koenig@pengutronix.de, gerg@uclinux.org,
	Olof Johansson <olof@lixom.net>, ARM Maintainers <arm@kernel.org>,
	linux-kernel@vger.kernel.org,
	Patrice Vilchez <patrice.vilchez@atmel.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Ludovic Desroches <ludovic.desroches@atmel.com>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [RFC PATCH] ARM: at91: remove no-MMU at91x40 support
Date: Wed, 24 Sep 2014 16:47:47 +0200	[thread overview]
Message-ID: <3700375.DRR5iB2NGi@wuerfel> (raw)
In-Reply-To: <1411568281-3924-1-git-send-email-nicolas.ferre@atmel.com>

On Wednesday 24 September 2014 16:18:01 Nicolas Ferre wrote:
> As there is currently no-one to take care of this old !MMU target and as its
> support in recent kernels is a bit rotten, remove this at91x40 support and the
> board file associated with it (at91eb01).
> There are modern ARM !MMU in Mainline now so this target is not interesting for
> building tests anymore. It would be better to start from these modern ARM !MMU
> platforms to reintroduce at91x40 support if needed.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 807b22dadcb6..f3bd8abd25c0 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -18,26 +18,22 @@ config HAVE_AT91_DBGU2
>  config AT91_USE_OLD_CLK
>  	bool
>  
> -config AT91_PMC_UNIT
> -	bool
> -	default !ARCH_AT91X40
> -
>  config COMMON_CLK_AT91
>  	bool
> -	default AT91_PMC_UNIT && USE_OF && !AT91_USE_OLD_CLK
> +	default USE_OF && !AT91_USE_OLD_CLK
>  	select COMMON_CLK
>  
>  config OLD_CLK_AT91
>  	bool
> -	default AT91_PMC_UNIT && AT91_USE_OLD_CLK
> +	default AT91_USE_OLD_CLK
>  
>  config AT91_SAM9_ALT_RESET
>  	bool
> -	default !ARCH_AT91X40
> +	default y
>  
>  config AT91_SAM9G45_RESET
>  	bool
> -	default !ARCH_AT91X40
> +	default y
>  
>  config AT91_SAM9_TIME
>  	bool

I think these can be simplified further: AT91_SAM9G45_RESET and
AT91_SAM9_ALT_RESET can just go away and the files put into
obj-y.

OLD_CLK_AT91 is the same as AT91_USE_OLD_CLK, so you could
just use that instead. I suspect the 'USE_OF' dependency for
COMMON_CLK_AT91 can also go away, since all platforms are
either board file based and select AT91_USE_OLD_CLK, or they
are DT based and don't.

	Arnd

  reply	other threads:[~2014-09-24 14:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 14:18 [RFC PATCH] ARM: at91: remove no-MMU at91x40 support Nicolas Ferre
2014-09-24 14:18 ` Nicolas Ferre
2014-09-24 14:47 ` Arnd Bergmann [this message]
2014-09-24 14:47   ` Arnd Bergmann
2014-09-24 15:03   ` Nicolas Ferre
2014-09-24 15:03     ` Nicolas Ferre
2014-09-24 15:09     ` Arnd Bergmann
2014-09-24 15:09       ` Arnd Bergmann
2014-09-24 16:10       ` Alexandre Belloni
2014-09-24 16:10         ` Alexandre Belloni
2014-09-25  0:03 ` Greg Ungerer
2014-09-25  0:03   ` Greg Ungerer
2014-09-25  6:26 ` Uwe Kleine-König
2014-09-25  6:26   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3700375.DRR5iB2NGi@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.