From: Shawn Guo <shawn.guo@freescale.com>
To: Stefan Agner <stefan@agner.ch>
Cc: linus.walleij@linaro.org, gnurou@gmail.com,
kernel@pengutronix.de, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bpringlemeir@nbsps.com
Subject: Re: [PATCH v2 1/5] pinctrl: imx: detect uninitialized pins
Date: Thu, 25 Sep 2014 10:15:49 +0800 [thread overview]
Message-ID: <20140925021547.GA6405@dragon> (raw)
In-Reply-To: <6d676a88eb82a47f8fa9e16abbc768e3e9ac236a.1411492954.git.stefan@agner.ch>
On Tue, Sep 23, 2014 at 07:37:53PM +0200, Stefan Agner wrote:
> The pinctrl driver initialized the register offsets for the pins
> with 0. On Vybrid an offset of 0 is a valid offset for the pinctrl
> mux register. So far, this was solved using the ZERO_OFFSET_VALID
> flag which allowed offsets of 0. However, this does not allow to
> verify whether a pins struct imx_pmx_func was initialized or not.
>
> Use signed offset values for register offsets and initialize those
> with -1 in order to detect uninitialized offset values reliable.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Shawn Guo <shawn.guo@freescale.com>
WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] pinctrl: imx: detect uninitialized pins
Date: Thu, 25 Sep 2014 10:15:49 +0800 [thread overview]
Message-ID: <20140925021547.GA6405@dragon> (raw)
In-Reply-To: <6d676a88eb82a47f8fa9e16abbc768e3e9ac236a.1411492954.git.stefan@agner.ch>
On Tue, Sep 23, 2014 at 07:37:53PM +0200, Stefan Agner wrote:
> The pinctrl driver initialized the register offsets for the pins
> with 0. On Vybrid an offset of 0 is a valid offset for the pinctrl
> mux register. So far, this was solved using the ZERO_OFFSET_VALID
> flag which allowed offsets of 0. However, this does not allow to
> verify whether a pins struct imx_pmx_func was initialized or not.
>
> Use signed offset values for register offsets and initialize those
> with -1 in order to detect uninitialized offset values reliable.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Shawn Guo <shawn.guo@freescale.com>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: Stefan Agner <stefan@agner.ch>
Cc: <linus.walleij@linaro.org>, <gnurou@gmail.com>,
<kernel@pengutronix.de>, <linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <bpringlemeir@nbsps.com>
Subject: Re: [PATCH v2 1/5] pinctrl: imx: detect uninitialized pins
Date: Thu, 25 Sep 2014 10:15:49 +0800 [thread overview]
Message-ID: <20140925021547.GA6405@dragon> (raw)
In-Reply-To: <6d676a88eb82a47f8fa9e16abbc768e3e9ac236a.1411492954.git.stefan@agner.ch>
On Tue, Sep 23, 2014 at 07:37:53PM +0200, Stefan Agner wrote:
> The pinctrl driver initialized the register offsets for the pins
> with 0. On Vybrid an offset of 0 is a valid offset for the pinctrl
> mux register. So far, this was solved using the ZERO_OFFSET_VALID
> flag which allowed offsets of 0. However, this does not allow to
> verify whether a pins struct imx_pmx_func was initialized or not.
>
> Use signed offset values for register offsets and initialize those
> with -1 in order to detect uninitialized offset values reliable.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Shawn Guo <shawn.guo@freescale.com>
next prev parent reply other threads:[~2014-09-25 2:15 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 17:37 [PATCH v2 0/5] vf610: Add GPIO support Stefan Agner
2014-09-23 17:37 ` Stefan Agner
2014-09-23 17:37 ` [PATCH v2 1/5] pinctrl: imx: detect uninitialized pins Stefan Agner
2014-09-23 17:37 ` Stefan Agner
2014-09-25 2:15 ` Shawn Guo [this message]
2014-09-25 2:15 ` Shawn Guo
2014-09-25 2:15 ` Shawn Guo
2014-09-23 17:37 ` [PATCH v2 2/5] pinctrl: imx: add gpio pinmux support for vf610 Stefan Agner
2014-09-23 17:37 ` Stefan Agner
2014-09-25 2:47 ` Shawn Guo
2014-09-25 2:47 ` Shawn Guo
2014-09-25 2:47 ` Shawn Guo
2014-09-25 7:00 ` Stefan Agner
2014-09-25 7:00 ` Stefan Agner
2014-09-25 9:07 ` Shawn Guo
2014-09-25 9:07 ` Shawn Guo
2014-09-25 9:07 ` Shawn Guo
2014-09-25 9:36 ` Stefan Agner
2014-09-25 9:36 ` Stefan Agner
2014-09-25 16:43 ` Bill Pringlemeir
2014-09-25 16:43 ` Bill Pringlemeir
2014-09-26 10:50 ` Stefan Agner
2014-09-26 10:50 ` Stefan Agner
2014-09-29 15:05 ` Bill Pringlemeir
2014-09-29 15:05 ` Bill Pringlemeir
2014-09-29 15:05 ` Bill Pringlemeir
2014-09-29 17:25 ` Stefan Agner
2014-09-29 17:25 ` Stefan Agner
2014-09-23 17:37 ` [PATCH v2 3/5] gpio: vf610: add gpiolib/IRQ chip driver for Vybrid Stefan Agner
2014-09-23 17:37 ` Stefan Agner
2014-09-23 17:37 ` Stefan Agner
2014-09-25 5:55 ` Shawn Guo
2014-09-25 5:55 ` Shawn Guo
2014-09-25 5:55 ` Shawn Guo
2014-09-25 8:10 ` Stefan Agner
2014-09-25 8:10 ` Stefan Agner
2014-09-23 17:37 ` [PATCH v2 4/5] ARM: dts: vf610: use new GPIO support Stefan Agner
2014-09-23 17:37 ` Stefan Agner
2014-09-23 17:37 ` [PATCH v2 5/5] Documentation: dts: Add bindings for Vybrid GPIO/PORT module Stefan Agner
2014-09-23 17:37 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925021547.GA6405@dragon \
--to=shawn.guo@freescale.com \
--cc=bpringlemeir@nbsps.com \
--cc=gnurou@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.