From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable()
Date: Thu, 25 Sep 2014 09:17:56 -0700 [thread overview]
Message-ID: <20140925161756.GA25798@infradead.org> (raw)
In-Reply-To: <1411647632-28240-2-git-send-email-david@fromorbit.com>
> index d36bdbc..9073895 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -607,7 +607,7 @@ xfs_mount_reset_sbqflags(
> * If the fs is readonly, let the incore superblock run
> * with quotas off but don't flush the update out to disk
> */
> - if (mp->m_flags & XFS_MOUNT_RDONLY)
> + if (!xfs_fs_writable(mp, SB_UNFROZEN))
This adds a new caller of xfs_fs_writable, which isn't mentioned in the
changelog.
> + /*
> + * We can be called during the fs freeze process, and we need to be
> + * able to write the superblock in that case.
> + */
> + if (!xfs_fs_writable(mp, SB_FREEZE_FS))
> return 0;
And this already changes the checked freeze level, also not mentioned.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-25 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 12:20 [PATCH 0/3 v2] xfs: superblock logging rework Dave Chinner
2014-09-25 12:20 ` [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable() Dave Chinner
2014-09-25 16:17 ` Christoph Hellwig [this message]
2014-09-25 21:03 ` Dave Chinner
2014-09-26 9:44 ` Christoph Hellwig
2014-09-29 12:18 ` Brian Foster
2014-09-25 12:20 ` [PATCH 2/3] xfs: remove bitfield based superblock updates Dave Chinner
2014-09-26 9:45 ` Christoph Hellwig
2014-09-26 23:01 ` Dave Chinner
2014-09-26 10:00 ` Christoph Hellwig
2014-09-26 23:02 ` Dave Chinner
2014-09-25 12:20 ` [PATCH 3/3] xfs: consolidate superblock logging functions Dave Chinner
2014-09-29 13:20 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925161756.GA25798@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.